Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp220500rwd; Tue, 6 Jun 2023 21:55:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4kMAT/ZvLqfmdOcTJx4YlHbsanhMVHg43J44kBTdm8Ey/TZiJJQ7KmsYmHeAkx+uxzjj/R X-Received: by 2002:a05:6a20:9185:b0:117:a86:6c7e with SMTP id v5-20020a056a20918500b001170a866c7emr2258148pzd.18.1686113753544; Tue, 06 Jun 2023 21:55:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686113753; cv=none; d=google.com; s=arc-20160816; b=q1CCdQ8Q+7X3kHBmva7iU3UL+zlAi/pNbE6eivup4iKTYJUDwv373nVi1bOx1hod48 labNf9VAOBY86DhZx4s40WYPkXjJ4rnbPQpe5bvfnQJMZRiC9Lys1YqSghbpPyVCZgW0 k54if2HN0qO8DdcYpHfVXgSoDbp0elUZqANoIlPHyDzD/b3MwENbq0SAgVEISIuifzNp YOgh8WDyzM6gD1W+eRGFNFeCxiMNMD0E4KyKow+YdBMvdxi1Bx2SdMd5TppKKqa02sMX ku9aBvSKlbpSTZjT35JUNnnvlssECCPAoeyr+nEQM8tjK79xJBJTf6ueuQGRWRMKudB4 4bIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1IHridDsfSPuH24iSbbouzSANZmBBWMHIennNjAgQhc=; b=LNXtrPQiChb7ghhjBgRQPOeQameMxruMGnlTHEr6o9rVQTcBTtNF5IhCafiPpxiwmU X7tE64Eia1xkQ2UCLB6H1waMZRkbMpaOtfAViAwCIORQUsdm/7qIXsOM5WIhWkvZsWRb 9R5wl8jFZ09QEUhNuBedk9m/ynaA+htOMC54BuEu+JBgVjJcLfznG5Uc/D/BZXGdy0tT U7KQpcAPX8bk1tJbvZzwJ7/4uJ9aSJwM7OFTmk4w3NzzgEzTf5qwx++k6hfGqFdlA/X6 qt9rLlBizxxuYzSwUXBrBXgzh/TsbuOtTX6+lXJp8qiMDDe1NSWoBN/5LwTOyiPGVf90 G6lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QCV6XLfl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i71-20020a63874a000000b0053fee0e4606si8249774pge.232.2023.06.06.21.55.36; Tue, 06 Jun 2023 21:55:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QCV6XLfl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240893AbjFGDzu (ORCPT + 99 others); Tue, 6 Jun 2023 23:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240813AbjFGDym (ORCPT ); Tue, 6 Jun 2023 23:54:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3964019B9 for ; Tue, 6 Jun 2023 20:54:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C80646393B for ; Wed, 7 Jun 2023 03:54:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B54CC433EF; Wed, 7 Jun 2023 03:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686110079; bh=lipBdfsrWW5U0xjBpTPT3ABPpxcdQFIPfd2IFiOUgNc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QCV6XLflw/NJOGtOegGp36oA4bQY0p+0RGE1AEmJjv5H22cdKjzlh/chTPZSCqo7d o4sUJdtoHGCBdw1euRdxLQB5HqDooBMdFj6eA4JnDP9gkY5j3epfFaobL4/4I7BQUq j+nbKWAwIWKBpwLxea+zZPyAzAE6Sx6/QtsHM9gUPSJ9H+5+b5MBMX4wqIjBIrocGA EoEdbZu11I60omxq/SZtoACfjxvGwvHFUH/xXfjzSxTy9XliOdyojXgk0ADcnjcRGM OUrbNPCOazk3O6FKI7uVjlbMjTz3QIPDoo8z9LsFvWfTclJIiHwfHW86jvz88yys82 jIew+n89qRt3Q== Date: Tue, 6 Jun 2023 20:54:37 -0700 From: Jakub Kicinski To: Justin Chen Cc: netdev@vger.kernel.org, simon.horman@corigine.com, "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Daniil Tatianin , Marco Bonelli , Gal Pressman , Jiri Pirko , Sean Anderson , Vincent Mailhol , Kuniyuki Iwashima , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net-next] ethtool: ioctl: improve error checking for set_wol Message-ID: <20230606205437.49378d25@kernel.org> In-Reply-To: <1685990778-34039-1-git-send-email-justin.chen@broadcom.com> References: <1685990778-34039-1-git-send-email-justin.chen@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Jun 2023 11:46:16 -0700 Justin Chen wrote: > + if (wol.wolopts & ~cur_wol.supported) > + return -EOPNOTSUPP; One small comment - I think we should return -EINVAL here. That's what netlink return and we seem to mostly return -EOPNOTSUPP if the operation is completely not supported. -- pw-bot: cr