Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp221865rwd; Tue, 6 Jun 2023 21:57:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6mW9eDvGzGzeldEAXg4c8NFHCAPJLyC7bDglhWf3y9Yt2RLHspUOHd02FlcoYLCnVSfBvA X-Received: by 2002:a05:6808:617:b0:398:477e:2e8e with SMTP id y23-20020a056808061700b00398477e2e8emr4559907oih.8.1686113863615; Tue, 06 Jun 2023 21:57:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686113863; cv=none; d=google.com; s=arc-20160816; b=u9Uqrh43NTP68gcB8HZabqqpqVfMEqWTTq93ZPzp/nNmzbv/KXqSwndGU+bnKsHV3P MULOaObMXK8D34tuEb4XkwApcOfVVCIAo1ZCNIfwnelQkb5rCzjH/3Cif9XRtjOJ/1kK jyI/8F/rQniuLrcp3CqJ/ADKg3d16LFzVy+1HUnHg+t3uVmCDR/atZkEEStVoJW8eBSu 3Baqf4imO1m3pcSV6aVmkc+0BXZnqgs16JOJgfYYNtxGCDoTEErkynWeuCFTxfuYLu07 zcMcImk9NWWP8KuuZcBd75LteufYs/x06GYwIWaHh000+8vWDR3JWXMEwUG5Dzah2Cfo 3yRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=fo4PkLfngXYHY6ja+unUd5R8bGmOlUuTUPgWhxoPbLc=; b=V+9RrSgMbGRGJGqixxLjF8s99kIa2P5kV5J0dItgow1hwVx0Li2QSUcSFEdZPV7wvC xDymxIW8hHdR9rtZVja6JCmJgxiS3SGqGaptILgKI9p9SpPHtmVysaSLwCWmskLacLmh O6EAdI+9DfsoNEtwlil0+WENShL40ACfz3Ch8+Z12GC2pgqXYCYN1SBm7Pov3undeq6h OYFEL6Np7e9C9L60BCuhJIKpff6v3PB27/CKgoRN1buFQ1TZk/UACAoZnj7OXD3zRpy4 9WqcPTfWqG4VvMJZN9P1RWTNFwFVSfPaIs76r/LinGFz8yGXrFQ/PkM2FxVz5u7LTeuL vFyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kyWP28qN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7-20020a170903120700b001ae5eb838edsi8674111plh.152.2023.06.06.21.57.12; Tue, 06 Jun 2023 21:57:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kyWP28qN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233678AbjFGErH (ORCPT + 99 others); Wed, 7 Jun 2023 00:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233696AbjFGErF (ORCPT ); Wed, 7 Jun 2023 00:47:05 -0400 Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3755E60 for ; Tue, 6 Jun 2023 21:47:02 -0700 (PDT) Received: by mail-vs1-xe36.google.com with SMTP id ada2fe7eead31-43b87490a27so996164137.0 for ; Tue, 06 Jun 2023 21:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1686113222; x=1688705222; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fo4PkLfngXYHY6ja+unUd5R8bGmOlUuTUPgWhxoPbLc=; b=kyWP28qN8Jys8ZFdoulObIZ5HN99D2774We5lAq1N4NhWeKJpOyDBaA1fL/QwG5r9T +3HVez47RYtr0CFUkMYtD5KbpilQxz81OXdUv4lHqQp2EvPn4UUcIo4RkpjyIm/AQYst nGZxKi2mYvdsj4X0GO+TasNUe0729O/BU1Ay8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686113222; x=1688705222; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fo4PkLfngXYHY6ja+unUd5R8bGmOlUuTUPgWhxoPbLc=; b=Nhefd2Q0/dmGmZ5QL4+HRS/CbU9kB+PUamU3eqWRvqS37Tj31gGoQrNQMgOkzXEqZC CCuN3Z+IiffdMSGmu68Rc5EKNvy/7upNuxoN4otJ/PElVZXOODGyoVS9oJILIRhSUmEv bVl5SQfdDTOflVsKPS4MBkycjaccZlVnLJqAVPOdoWfUnshue9YuwMzyXjLMN+MHgz/x P7QB27ihPgGZ8M5Eij0fcUCLn/1LnMEnZtR6LlC2KWuk6jpXryn0SNjq33AFdE/mbb9x BdITYJNwRZ+qujI/LXeSiaq8jD6C3NRywjcbq7oM0NajmBGKyZDykwT2sFuzOiJWzdU/ lvvw== X-Gm-Message-State: AC+VfDxIL2dwh0q1ds6OtZihNJAIcaLpZ5I2LpEZfEeK+Kz8fq/V9zVP f6jSQevcU+sB0UshydxlMiU87RjQkVvAOJ1Atv+W7A== X-Received: by 2002:a05:6102:102:b0:43b:1b47:670 with SMTP id z2-20020a056102010200b0043b1b470670mr688543vsq.20.1686113222153; Tue, 06 Jun 2023 21:47:02 -0700 (PDT) MIME-Version: 1.0 References: <20230602083335.GA181647@google.com> <87a5xii33r.fsf@jogness.linutronix.de> <20230603054139.GR14287@atomide.com> <20230603063533.GS14287@atomide.com> <20230605061511.GW14287@atomide.com> <20230605122447.GY14287@atomide.com> <20230605131803.GA14287@atomide.com> <20230606122059.GC14287@atomide.com> In-Reply-To: <20230606122059.GC14287@atomide.com> From: Chen-Yu Tsai Date: Wed, 7 Jun 2023 12:46:51 +0800 Message-ID: Subject: Re: [PATCH v12 1/1] serial: core: Start managing serial controllers to enable runtime PM To: Tony Lindgren Cc: John Ogness , Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Dhruva Gole , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 6, 2023 at 8:21=E2=80=AFPM Tony Lindgren wro= te: > > * Chen-Yu Tsai [230606 09:17]: > > I ended up following 8250_dw's design, which seemed less convoluted. > > The original code was waaay too convoluted. > > OK that looks good to me thanks. Good to hear you got it sorted out. > > The 8250_dw style runtime PM is a good solution for simple cases. Where > it won't work are SoCs where runtime PM calls need to propagate up the > bus hierarchy. For example, 8250_omap needs runtime PM calls for the > interconnect and power domain to get register access working. Good to know. On MediaTek platforms I don't think there are any power domains covering the basic peripherals. (Or it's hidden from the kernel.) > > BTW, the Bluetooth breakage seems like a different problem. > > OK seems like we're good to go then :) Yup. After a bit more testing, it seems the Bluetooth problem is more like an undervolt issue. If I have WiFi and BT probe at the same time, Bluetooth fails. If they probe separately, everything works fine. ChenYu