Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp238244rwd; Tue, 6 Jun 2023 22:16:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7kgIpYK604VvbPu1RQI8qdyOoLtq0Q36Q0zM/C3L75nxetzbs+nMezt1l/udti2LeFcr8M X-Received: by 2002:a92:da12:0:b0:33a:abcd:4d14 with SMTP id z18-20020a92da12000000b0033aabcd4d14mr6331014ilm.2.1686114980252; Tue, 06 Jun 2023 22:16:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686114980; cv=none; d=google.com; s=arc-20160816; b=X7C0hq6SCFHRg0WAMvWwO//CpZJyKlRysSV/ixKe/Iv4SkmtXwgfYvtLD8Xs3p1Me2 G77RXc0HHi1gHnaX4TqWigD44wX5guBPdaIZYIEqQrWYN8q/rRh9as5UXsutGzsT94QW 7EZFKyL/lS7A/j3j4al1/qd+OsYA4R0WEhD2b9VsNO47HnCDXOLY83B1SFvM8ZDhY0e8 XkCGnQDsgV6aJdUT6z/QF0WTdvZSZk3AQvNv94XsD+DtMN3K3HHmNguU9HSH6hoM2HKh L8xxJjS8NAUQADSV2n40fZvT91w2u3WGMp21KRmRjSiKVHtmcscFk/XrTVKIWLblTFgu eMtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=NYTBP7t2VkiKw//W7AYPQ7KQ/DEv1v6h9NXrKQRPRJw=; b=GjgOeq2srzkWtObNQO0vHAxUxpwoyzqlBOQcNf0ZaDEbCULK2BcZJawy5xrOvwJxr8 GpqSd6EGNLjKlyB+/rkraIueA8yZ5MwAoXNBPrVsbuQUPifM+swbuG2qpgCX5nKWsPYb vT1ruErofGqZdcBlrNbD8eztu0roSM8+FskC4nYrC8yawAnHes7oO4X5IUE6Un1pTiWs vwRrhj9dDJDB+Gy/0K4SCpDAfY9JAOKgJkvGwx/ya6uJmcOJ6Xdb+GxMslSAGapCoreK MUO1P7Pki/28b5ltDwyYTq52ofNm3Mj6g0TPsXxbVLThJ0+SGnqBWt6U4uiv4Og2kb1p b2uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ORF8nz1A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j14-20020a636e0e000000b00541bf36f2d2si8416085pgc.208.2023.06.06.22.16.08; Tue, 06 Jun 2023 22:16:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ORF8nz1A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233951AbjFGEYU (ORCPT + 99 others); Wed, 7 Jun 2023 00:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233227AbjFGEXo (ORCPT ); Wed, 7 Jun 2023 00:23:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9B51FE6 for ; Tue, 6 Jun 2023 21:20:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7904C6355C for ; Wed, 7 Jun 2023 04:20:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id C93BEC4339B; Wed, 7 Jun 2023 04:20:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686111622; bh=jEWyIKzMhyKk+pCIj7/Ov4ot3qtkNUAnCrmXnIRx7NU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ORF8nz1ALg92XVLC69qgRiJDg/9XVH82dJ4eP8OUfhYRpn+DmGWNkgoG7n8vTS0O3 YY0aZ/KVEJ7lvVvVVRaP4tnqgpdf6elKUDbRvlh3W4sRcFG8rbbvQm9u02rbULkp/2 KtcX0c0NTaJG667zNAEoYLuAoZ7kw1HX4PNLd4DZtAWUKNdzndqLI5t2+/5ZxOSGM6 +xvLEjScykeHsczOYeBYhXlH5+a1U4G3e4ZS0JDyKP+842Kyc4jNHzD0Wo5H/NIIwG kaD0ezU6jwxqA+qRrEiJ6CdyF5UcS6ljaJyKvUiDbHvahU0r/6Tm3ltR6byiO8kv1G PMLfUF6fOlUtQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id A370DE8723C; Wed, 7 Jun 2023 04:20:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] pds_core: Fix FW recovery detection From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168611162266.32150.3491600977084749075.git-patchwork-notify@kernel.org> Date: Wed, 07 Jun 2023 04:20:22 +0000 References: <20230605195116.49653-1-brett.creeley@amd.com> In-Reply-To: <20230605195116.49653-1-brett.creeley@amd.com> To: Brett Creeley Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, shannon.nelson@amd.com X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 5 Jun 2023 12:51:16 -0700 you wrote: > Commit 523847df1b37 ("pds_core: add devcmd device interfaces") included > initial support for FW recovery detection. Unfortunately, the ordering > in pdsc_is_fw_good() was incorrect, which was causing FW recovery to be > undetected by the driver. Fix this by making sure to update the cached > fw_status by calling pdsc_is_fw_running() before setting the local FW > gen. > > [...] Here is the summary with links: - [net] pds_core: Fix FW recovery detection https://git.kernel.org/netdev/net/c/4f48c30312b7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html