Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760348AbXJOKD1 (ORCPT ); Mon, 15 Oct 2007 06:03:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756076AbXJOKDR (ORCPT ); Mon, 15 Oct 2007 06:03:17 -0400 Received: from il.qumranet.com ([82.166.9.18]:49196 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753751AbXJOKDR (ORCPT ); Mon, 15 Oct 2007 06:03:17 -0400 Message-ID: <47133ABD.8050608@qumranet.com> Date: Mon, 15 Oct 2007 12:02:37 +0200 From: Avi Kivity User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Ingo Molnar CC: Laurent Vivier , linux-kernel Subject: Re: [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting. References: <46E550EF.5080209@bull.net> <20071015093800.GA22818@elte.hu> <47133732.2090809@qumranet.com> <20071015095125.GB28367@elte.hu> In-Reply-To: <20071015095125.GB28367@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 871 Lines: 35 Ingo Molnar wrote: > * Avi Kivity wrote: > > >> This bit can go; for the external module I can add it back in >> external-module-compat.h. No need to pollute mainline with backward >> compatibility stuff. >> > > hm: > > static inline void kvm_guest_enter(void) > { > current->flags |= PF_VCPU; > } > > static inline void kvm_guest_exit(void) > { > } > > shouldnt PF_VCPU be cleared in kvm_guest_exit()? > IIRC the accounting code clears it, but yes, it may not have been called at all, so clearing it here is needed. -- error compiling committee.c: too many arguments to function - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/