Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 09:49:44 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Michael Riesch <michael.riesch@wolfvision.net>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        libcamera-devel@lists.libcamera.org,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Matthias Fend <Matthias.Fend@wolfvision.net>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 1/6] media: v4l2-ctrls: fix documentation of
 V4L2_CID_FOCUS_ABSOLUTE unit
Message-ID: <20230607064944.GA4663@pendragon.ideasonboard.com>
References: <20230406-feature-controls-lens-v2-0-faa8ad2bc404@wolfvision.net>
 <20230406-feature-controls-lens-v2-1-faa8ad2bc404@wolfvision.net>
 <20230606103421.GA25774@pendragon.ideasonboard.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230606103421.GA25774@pendragon.ideasonboard.com>
Precedence: bulk

On Tue, Jun 06, 2023 at 01:34:21PM +0300, Laurent Pinchart wrote:
> On Tue, Apr 25, 2023 at 11:45:11AM +0200, Michael Riesch wrote:
> > The current unit description of the V4L2_CID_FOCUS_ABSOLUTE does not
> > make sense and was probably copy-pasted from V4L2_CID_FOCUS_RELATIVE.
> > Fix the unit description in the documentation.
> > 
> > Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> > ---
> >  Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
> > index daa4f40869f8..df29150dce7b 100644
> > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
> > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-camera.rst
> > @@ -140,8 +140,8 @@ enum v4l2_exposure_metering -
> >  
> >  ``V4L2_CID_FOCUS_ABSOLUTE (integer)``
> >      This control sets the focal point of the camera to the specified
> > -    position. The unit is undefined. Positive values set the focus
> > -    closer to the camera, negative values towards infinity.
> > +    position. The unit is undefined. Larger values move the focus closer to
> > +    the camera, smaller values move the focus to infinity.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I just noticed that the UVC specification states

  4.2.2.1.6 Focus (Absolute) Control

  The Focus (Absolute) Control is used to specify the distance to the
  optimally focused target. This value is expressed in millimeters. The
  default value is implementation-specific.

This is the opposite of the V4L2_CID_FOCUS_ABSOLUTE control :-( I
suppose this will need to be solved in the uvcvideo driver by converting
the value.

> >  
> >  ``V4L2_CID_FOCUS_RELATIVE (integer)``
> >      This control moves the focal point of the camera by the specified
> > 

-- 
Regards,

Laurent Pinchart