Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp349943rwd; Wed, 7 Jun 2023 00:23:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6TmOxJ1jFy8pnJipKV+FE3YBUWCgtQ8KS72cUjq9sOkmLGlZIepvU6wyne1l4qWACIWRxj X-Received: by 2002:aa7:8759:0:b0:657:1fe5:eb63 with SMTP id g25-20020aa78759000000b006571fe5eb63mr4866412pfo.7.1686122587459; Wed, 07 Jun 2023 00:23:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686122587; cv=none; d=google.com; s=arc-20160816; b=FrH0/30HotIZi2Tf6Nio5o6+60EFVmNoSD3GCYn45z8858EcJb7P6q2KASso+0SU66 AjLkMNrBP5ST/jnSeBzwoS2Z34D19ypUE9EbqKom0KpYZsmRhLWOGwasuqOGNb2Z9XhF nsUESZXhXaEt3DiTW/NxPNix+faHAe69Q/5nhBPvNBIBONn537SoOIvszTMVaOwmqW0J JiJzaGX0wQOXeCJSgpQbUGlats4MpbxYZwQvkC0oj5GBacw7Odlg4UT7qDyFfMPAIn99 geFOQu6louPjVTq+gHRXHRkrjmLtsF3BjcIKj7EWDmOPsfAYETn+7rLXPT4FeRtkDMMJ Aq2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=4HtcYeeSFJX97ey2U3FsO6n3a4Uc4lf1gY3baMGyOsg=; b=Q2JGLB+kI6C/lQK9Sy0+SytzKJULhP881FhgnR2bTum1MVJSLbA4vQFMZXL42RoDSH IyLnkM+eNuRtDD9zHg1IxGpkvNE2ic9URNGzdYpzs7xc90KIZoeH5taMEaLHF2Qfn4Jq jQg9fz4WiBvdhYs9JGPa+oUUaOxLFzmxwr8zA0sTKKn8Jl5dUxgUxiUK0ZT29N1YFau+ 1+bCXM4KY2Azd5ZBbktF6KwIMVmKl2f7HLW+0Y7FfnW23TVnm6IsSKaCFiBbOqgdAbwg CaQmeWqSHg3t5B0T8JkB/rGr5W/PffBUJtYFuasifRc5cUIRiowxdT8GxY2JYqnocT9V uzBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aqzGV9aN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y12-20020aa79aec000000b00660b5630927si2009363pfp.133.2023.06.07.00.22.55; Wed, 07 Jun 2023 00:23:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aqzGV9aN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238665AbjFGHHy (ORCPT + 99 others); Wed, 7 Jun 2023 03:07:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238669AbjFGHHu (ORCPT ); Wed, 7 Jun 2023 03:07:50 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D09A91A7 for ; Wed, 7 Jun 2023 00:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686121620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4HtcYeeSFJX97ey2U3FsO6n3a4Uc4lf1gY3baMGyOsg=; b=aqzGV9aNDCngZzfskhQt/xNNzQdH81q23DBbBomUSv95AfYMQWUT+avo0CLoXodTOsB2Oj SyVwc5afV4vJRPQzYpqlxj0FnQiu/J4Nevqt81hmoGAdKlts26hvnE+diS/ornoXCvl3/k vO6KCuw8bavrz854qEj2XFKBowhTZ5g= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-k6EZqqTYM-aPUEkh-2V8fg-1; Wed, 07 Jun 2023 03:06:59 -0400 X-MC-Unique: k6EZqqTYM-aPUEkh-2V8fg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f603fed174so39503605e9.2 for ; Wed, 07 Jun 2023 00:06:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686121618; x=1688713618; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4HtcYeeSFJX97ey2U3FsO6n3a4Uc4lf1gY3baMGyOsg=; b=PdDTAnkhDPaxPSAth85Qj9LYSODKGr+aPq7Bnm5RGJ/gV5QF88u2a/Ej8zjKrPebWO jOoD8Ffy4IfQ7POQ1I2OYoo4HFu4uAP7yXcctfdM89i1IycsB/bfIzXU+rOEdPKx0Fae CvIcDtmWSl/cFpAjLYqeAq9KTBWb7lbs9IIk+/UKOasR/UnbNS/U6TSuVkX/HeDqy0Wx rOkCAok0p/Xs811id+YlZFDVRlO9TxXuoBj4H5nEp34tjQH0vqm7tc8MKrAVslmg7e3+ uIn0OAgxPe/iSi0oGTtH6k+MvjIWxeLLzD8bx+eL+ns/B0a4T8kl/T1ZDOnqQUZzh10o vbww== X-Gm-Message-State: AC+VfDwODKBPQVgL1Yn8dko2x0Xc3sth59etTUJGZcM/tUthD0tMbGyo AUNDb17oaBXTAR+7lR2b340B2tKsTr8Kop8L6lOQOz08t1oTNC1n1jyg/7mGJrRMlOUhCffL/AN vPEtnF2YduAGUsDWv04EwSlr3sSwc7G0E X-Received: by 2002:adf:d083:0:b0:30e:46d4:64ee with SMTP id y3-20020adfd083000000b0030e46d464eemr3948781wrh.29.1686121618405; Wed, 07 Jun 2023 00:06:58 -0700 (PDT) X-Received: by 2002:adf:d083:0:b0:30e:46d4:64ee with SMTP id y3-20020adfd083000000b0030e46d464eemr3948757wrh.29.1686121617971; Wed, 07 Jun 2023 00:06:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9c00:8d26:3031:d131:455c? (p200300cbc70e9c008d263031d131455c.dip0.t-ipconnect.de. [2003:cb:c70e:9c00:8d26:3031:d131:455c]) by smtp.gmail.com with ESMTPSA id y5-20020adfd085000000b003095bd71159sm14743684wrh.7.2023.06.07.00.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 00:06:57 -0700 (PDT) Message-ID: Date: Wed, 7 Jun 2023 09:06:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] mm/sparse: remove unused parameters in sparse_remove_section() To: Yajun Deng , akpm@linux-foundation.org, osalvador@suse.de Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230607023952.2247489-1-yajun.deng@linux.dev> Content-Language: en-US From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230607023952.2247489-1-yajun.deng@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07.06.23 04:39, Yajun Deng wrote: > These parameters ms and map_offset are not used in > sparse_remove_section(), so remove them. > > The __remove_section() is only called by __remove_pages(), remove it. > And put the WARN_ON_ONCE() in sparse_remove_section(). > > Signed-off-by: Yajun Deng > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb