Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
From:   Rob Herring <robh@kernel.org>
To:     Piyush Mehta <piyush.mehta@amd.com>
Cc:     git@amd.com, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        nava.manne@xilinx.com, michal.simek@xilinx.com,
        linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
        siva.durga.prasad.paladugu@amd.com, michal.simek@amd.com,
        conor+dt@kernel.org, devicetree@vger.kernel.org,
        linux-usb@vger.kernel.org
In-Reply-To: <20230607065121.2265076-3-piyush.mehta@amd.com>
References: <20230607065121.2265076-1-piyush.mehta@amd.com>
 <20230607065121.2265076-3-piyush.mehta@amd.com>
Message-Id: <168612336540.2153788.14132885081062462478.robh@kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: firmware: add reset-controller
 property
Date:   Wed, 07 Jun 2023 01:36:05 -0600
Precedence: bulk


On Wed, 07 Jun 2023 12:21:21 +0530, Piyush Mehta wrote:
> The reset controller is responsible for managing both device-level resets
> and individual PMC (Power Management Controller) block resets.
> 
> To facilitate this functionality reset-controller property is added to the
> firmware device tree binding.
> 
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> ---
>  .../firmware/xilinx/xlnx,zynqmp-firmware.yaml         | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/reset/xlnx,zynqmp-reset.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.example.dtb: versal-firmware: reset-controller: False schema does not allow {'compatible': ['xlnx,zynqmp-reset'], '#reset-cells': [[1]]}
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.example.dtb: /example-0/versal-firmware/reset-controller: failed to match any schema with compatible: ['xlnx,zynqmp-reset']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230607065121.2265076-3-piyush.mehta@amd.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.