Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 09:49:24 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Shradha Gupta <shradhagupta@linux.microsoft.com>
Cc:     linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
        netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Long Li <longli@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>,
        "David S. Miller" <davem@davemloft.net>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH v6] hv_netvsc: Allocate rx indirection table size
 dynamically
Message-ID: <ZIA2hEhz0G8Oe5pf@corigine.com>
References: <1685964606-24690-1-git-send-email-shradhagupta@linux.microsoft.com>
 <ZH8Bv624GxCf1PKq@corigine.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZH8Bv624GxCf1PKq@corigine.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fnnTlFAZHLB2dbAUA4o4lzYlsMPypWRPTrRQuci+qlogVSDXX3en5ExV7jsm?=
 =?us-ascii?Q?zXX6ZTKtU8XxczMY3ry/jNOZgo1VohlFQuLcOv2teKq5WTpAZm0d3yyhrwbK?=
 =?us-ascii?Q?WVQ3if4USGWl2G6xdv9QSKemOVaHRc2pV84B6MEaXhag9R6oMOWIuwGaoCoH?=
 =?us-ascii?Q?0kKmOdq5kmmxpyFLCBrnXsbyER8+MB+42YhbSPJQN0mpWpTdCATmZMzl3eYV?=
 =?us-ascii?Q?lcsHS7bPyvnaUoMcdXQ4VhEnLlO2Ak1EPrSaROT0VtUUCjw/JC9S2qiYSGr3?=
 =?us-ascii?Q?yHQPXtVqhC1nSzGWOqKIschYUVpBdSlHBxlCOxSrPHXXBjMh/f5WNHdHf57N?=
 =?us-ascii?Q?FagCfqRbHsJe1YWuMeO6tdjj53QyV5cYuBpuE/8biCI49+ixm+lM6kjj6+h/?=
 =?us-ascii?Q?m2U39ASFToNK1j15/evy5v/tROz6mLVIVG3tvbpIyCyvFTLGpl0vtKheQM8V?=
 =?us-ascii?Q?vceyo2/xLAwVA5tjT7nz9YMMnT8de1EuwS/YIuy+VvLcDAEk5HXMQUkbQUsH?=
 =?us-ascii?Q?UbW0U8/fA6WtGJnwvinilxucLngpmEseV0z4HyLCtxQZbFUEImhgl/i/q/jG?=
 =?us-ascii?Q?O7iNK5Y3t4owMoQkdfA07hPCs7U9NSpTkSS/FyEb9j5Ppckil5z/DvOaAY2Q?=
 =?us-ascii?Q?6FmZhKLHfaimj4Asx8fEq5Xq+bACxklgBGUBS91Gwp+z/Co7qtz2Lm+dXHU9?=
 =?us-ascii?Q?bb9SVUi8fPznq578Rl4HZeNKyByhIvJk/wyz48JlssYKykNUJIYKjfNoXb3j?=
 =?us-ascii?Q?0xtpgFucYPttvLjOIkao42F8hAmuboxUgqIxc7oAFbyDea2GtzxpwYUvLObl?=
 =?us-ascii?Q?aJVRSrIxvg8UCEIKW/80f2HqcAbvK6mzGX5OemfgEoCkkMHV2SRr82jdXx1e?=
 =?us-ascii?Q?EENst7c/bjvRg2v0SCWXR3UZcLIbcxeYLfMOy5xVmhAwsfZk58tO7rKOkpNT?=
 =?us-ascii?Q?yKAlZ807ixoEoX/fS0q29orF6RNACJng9tADBIzx1vUbGp7GXt/pxKuYjHfd?=
 =?us-ascii?Q?b7JdqXuw1+70ITJfaD2X8SoqME4CnCRWJ+Gfj3Mxqi6Lw6F8Oh6xrLx8toQu?=
 =?us-ascii?Q?Qtf3dPbig1APggpNXRKqjvPVQFDLYZTMXNuQx3MUTw1VgNWM05BTZe8So+Rp?=
 =?us-ascii?Q?jMLNulHQRbSySt3WVpj8WwdPbZrvF2zb7NxV2YvT01O00K5ZbtOL9LroSMAR?=
 =?us-ascii?Q?vgNPMcNk0kv0SQhGlO9H4Ui50ZvPNR1/ZG70P+NwUfLF4RrmNdsD96RFCrv0?=
 =?us-ascii?Q?oKNV5J+y1FjCcJgF2zEsGbqVIy8yvMKNWe3W5EKXeQpCefsQVzKsYc0QquaK?=
 =?us-ascii?Q?AoG3QQovBFTW42hHK9olPnfafgYf/og0CD5xVOSnWaQDXear3VPlk9egsbyd?=
 =?us-ascii?Q?2pkSSx8+jvw4NE1KFBnJAbZI/OAOIHHGJYm8X25CqWy7X2xtkl8y90C/LI91?=
 =?us-ascii?Q?kbxl9mU5TWKafflkg0ObzD7+EZitn773VT9QrBu6bRX+3S/oNSicLjDOhMsT?=
 =?us-ascii?Q?HcPo3h1hkV7rWUJ1fm4k9HEeQ4JwolLYkZYDc5kElRq6sJXSTfH/2fIeaYdp?=
 =?us-ascii?Q?iZ7GDiaPTDaLPmJMMzkNC3AxNSgSCRjUvb10P+7Qtx/t2Z9BW+XC3gJ+i3f0?=
 =?us-ascii?Q?b4WZY0+b+IKxU2wvRPNtv2IX3kY11ChKSVXyUaeISVlJ8/JgVBNnzlNkf4fE?=
 =?us-ascii?Q?rgbcqg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93c34a08-4287-4823-8bbf-08db672bbb41
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 07:49:32.7460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Kj2lT5zGW8G4VtwvNgH02OFJOoM0a3WWsLLoYS0ay+14cZJPxj8I7Mup0RV2gx4R/PZvEZP06uZ8/JC+tNqFg2ADdkzpPw2D0gDCjY+J9o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5317
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 06, 2023 at 11:52:06AM +0200, Simon Horman wrote:
> + Praveen Kumar
> 
> On Mon, Jun 05, 2023 at 04:30:06AM -0700, Shradha Gupta wrote:
> > Allocate the size of rx indirection table dynamically in netvsc
> > from the value of size provided by OID_GEN_RECEIVE_SCALE_CAPABILITIES
> > query instead of using a constant value of ITAB_NUM.
> > 
> > Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> > Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> > Tested-on: Ubuntu22 (azure VM, SKU size: Standard_F72s_v2)
> > Testcases:
> > 1. ethtool -x eth0 output
> > 2. LISA testcase:PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-Synthetic
> > 3. LISA testcase:PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-SRIOV
> 
> Hi Praveen, all,
> 
> it seems that there has not been any non-trivial review of this
> patchset since v3. But at that point there was some feedback
> from you. So I'd like to ask if you have any feedback on v6 [1].
> 
> [1] https://lore.kernel.org/all/1685964606-24690-1-git-send-email-shradhagupta@linux.microsoft.com/
> 

For the record:

I see that Praveen has now provided a Reviewed-by for v3 [2], thanks!

I think this patch is clear now.

Reviewed-by: Simon Horman <simon.horman@corigine.com>

[2] https://lore.kernel.org/all/bb461c30-3eb0-74c0-d637-c4a3bdf84565@linux.microsoft.com/