Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 10:13:16 +0200
From:   Joel Granados <j.granados@samsung.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 0/8] Remove child from struct ctl_table
Message-ID: <20230607081316.wlnj5w5megkphcbd@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="tzto3k5whkt5xwze"
Content-Disposition: inline
In-Reply-To: <ZH+BWiQOSQGNDQCv@bombadil.infradead.org>
CMS-TYPE: 201P
References: <CGME20230602110640eucas1p11b79cbd7f116be6828a670f9873ed24e@eucas1p1.samsung.com>
        <20230602110638.789426-1-j.granados@samsung.com>
        <ZH+BWiQOSQGNDQCv@bombadil.infradead.org>
Precedence: bulk

--tzto3k5whkt5xwze
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 06, 2023 at 11:56:26AM -0700, Luis Chamberlain wrote:
> On Fri, Jun 02, 2023 at 01:06:30PM +0200, Joel Granados wrote:
> > Resending as the first set got mangled with smtp error.
> >=20
> > This is part of the effort to remove the empty element of the ctl_table
> > structures (used to calculate size) and replace it with an ARRAY_SIZE c=
all. By
> > replacing the child element in struct ctl_table with a flags element we=
 make
> > sure that there are no forward recursions on child nodes and therefore =
set
> > ourselves up for just using an ARRAY_SIZE. We also added some self test=
s to
> > make sure that we do not break anything.
> >=20
> > Patchset is separated in 4: parport fixes, selftests fixes, selftests a=
dditions and
> > replacement of child element. Tested everything with sysctl self tests =
and everything
> > seems "ok".
> >=20
> > 1. parport fixes: @mcgrof: this is related to my previous series and it=
 plugs a
> >    sysct table leak in the parport driver. Please tell me if you want m=
e to repost
> >    the parport series with this one stiched in.
> >=20
> > 2. Selftests fixes: Remove the prefixed zeros when passing a awk field =
to the
> >    awk print command because it was causing $0009 to be interpreted as =
$0.
> >    Replaced continue with return in sysctl.sh(test_case) so the test ac=
tually
> >    gets skipped. The skip decision is now in sysctl.sh(skip_test).
> >=20
> > 3. Selftest additions: New test to confirm that unregister actually rem=
oves
> >    targets. New test to confirm that permanently empty targets are inde=
ed
> >    created and that no other targets can be created "on top".
> >=20
> > 4. Replaced the child pointer in struct ctl_table with a u8 flag. The f=
lag
> >    is used to differentiate between permanently empty targets and non-e=
mpty ones.
> >=20
> > Comments/feedback greatly appreciated
>=20
> This all looks great, thanks so much for doing all this work! I pushed
> to sysctl-next.
I have a version where I replace the u8 flag with an enumeration with
two memebers. Tell me if it make sense to post the V2 and I'll send it
out after fixing it up a bit.

Best

Joel Granados

--tzto3k5whkt5xwze
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmSAPBYACgkQupfNUreW
QU/B3Qv7BliPNCxcKiu609ndtujxW6iO7EA/HFy7swUM+02NicOH2cjTWtW68W/n
4oT534vjY9rCTopitHQ6xqgJIqM02L5YFRAoq+BV2NyX2X/qNIcEb1Sv7+j1cPzO
z0D+UvnlqIb9Fu46dg3uLdWIXT2gzUuObwPfC4FTM1D2j8pp7ZdS4mQwSvDSNCSw
p2KzQQPsWzRt4UNAFsXo3cuDfPs/K3TiC7Cs3aV68MuH8MhUm3LjfKIw6FSlhqPi
pegwNEj+mGgABl0K/cPf0uuKaieQKNmx2PORr/3nZ5d14aUuYR/k6JSyWNq2DmJT
siBGSAz5l1BaqCKvVmVUbjfAXF3wTKOV+idoh0W1IGZnExu3EToAIIGLlghbOfYc
CNsp6LDRoGo2VFVveKhG01GYRSfv9fAbgwYjNDj0tHICB+vdRUAii2Y4pIwyDeGu
8Zw63t+SYhyOH94EJatbTDlCw187ypm35l5G8aEpNzYDu35L9VwESwckvupRK4wU
SWuXixYO
=lAan
-----END PGP SIGNATURE-----

--tzto3k5whkt5xwze--