Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20230530232914.3689712-3-mcgrof@kernel.org>
References: <20230530232914.3689712-3-mcgrof@kernel.org> <20230530232914.3689712-1-mcgrof@kernel.org>
To:     Luis Chamberlain <mcgrof@kernel.org>
Cc:     dhowells@redhat.com, keescook@chromium.org, yzaikin@google.com,
        jarkko@kernel.org, paul@paul-moore.com, jmorris@namei.org,
        serge@hallyn.com, j.granados@samsung.com, brauner@kernel.org,
        ebiederm@xmission.com, patches@lists.linux.dev,
        linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sysctl: move security keys sysctl registration to its own file
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2003476.1686127009.1@warthog.procyon.org.uk>
Date:   Wed, 07 Jun 2023 09:36:49 +0100
Message-ID: <2003477.1686127009@warthog.procyon.org.uk>
Precedence: bulk

Luis Chamberlain <mcgrof@kernel.org> wrote:

> The security keys sysctls are already declared on its own file,
> just move the sysctl registration to its own file to help avoid
> merge conflicts on sysctls.c, and help with clearing up sysctl.c
> further.
> 
> This creates a small penalty of 23 bytes:
> 
> ./scripts/bloat-o-meter vmlinux.1 vmlinux.2
> add/remove: 2/0 grow/shrink: 0/1 up/down: 49/-26 (23)
> Function                                     old     new   delta
> init_security_keys_sysctls                     -      33     +33
> __pfx_init_security_keys_sysctls               -      16     +16
> sysctl_init_bases                             85      59     -26
> Total: Before=21256937, After=21256960, chg +0.00%
> 
> But soon we'll be saving tons of bytes anyway, as we modify the
> sysctl registrations to use ARRAY_SIZE and so we get rid of all the
> empty array elements so let's just clean this up now.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

Acked-by: David Howells <dhowells@redhat.com>