Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <966758fd-53ab-c49b-e045-24ab1d12c0d9@amd.com>
Date:   Wed, 7 Jun 2023 11:20:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [Lima] [PATCH] drm/lima: fix sched context destroy
Content-Language: en-US
To:     Qiang Yu <yuq825@gmail.com>, Vasily Khoruzhick <anarsoul@gmail.com>
Cc:     Erico Nunes <nunes.erico@gmail.com>,
        dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, luben.tuikov@amd.com,
        daniel@ffwll.ch, airlied@gmail.com
References: <20230606143247.433018-1-nunes.erico@gmail.com>
 <CA+E=qVcv4CrGki1cTYb53p5Ys0AgF=qfrK7XYB7X0gvu9knD-g@mail.gmail.com>
 <CAKGbVbs2uwap-EuQkn00+rZqOB+Fohd9FmazMs051Yn+VSjmmA@mail.gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <CAKGbVbs2uwap-EuQkn00+rZqOB+Fohd9FmazMs051Yn+VSjmmA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjN4Vis3Z2pnUEx3cHBMU0EyM0U2YjVBVVJYVjhQMS9lTVNRTlRONlZ1clY3?=
 =?utf-8?B?T3JISmdWNU05anlTRGIydWlnRDlrRFdzVXI0UnVmWTdLdU5COW9ZUVJHZ2tk?=
 =?utf-8?B?NjBHWkxrU01xSjJHbTVzbTU2aWM4clRFS2VHUjUvOHFhT2V1azFPME5DaWlI?=
 =?utf-8?B?ZjlTYnI3L1lmbUpWT1A2NHhWQlBpTCtWYURaY1hKQnJmSnhML3ZQRVJsU3Jp?=
 =?utf-8?B?TVgydzBwZElXTXZ3Yk11NHFpNUxVMW1PMWFkV25wcEdxN1VCTUlGUTc0U3h6?=
 =?utf-8?B?ZVpHUGk4N2ZtcHFqdXlCNW1MRUNxSGRLZTd2YTU2UGF6YW9uZEV5UCtTTjFL?=
 =?utf-8?B?SGtrOG93SkxzTTdOdzdXT0RqVlc4ZVpCVkN6T0FBN3JCNk1IVkFVYWQreXd5?=
 =?utf-8?B?R2RBQUlzZEFZMnJ1WHZnNjBrVXdwL21aV2lGTGtUWHNLS0xFejJJUzF4bitL?=
 =?utf-8?B?aHhDMXV2WkpneG8vRlBlTndibWFqUHBFajVMd3Z4czZWUGtNVmNqcXA1YWx3?=
 =?utf-8?B?MjBqNS9XZ1QwWERZa3JQT1ROQWsxaDViclRBQzMvRTd4MUdSN3VJWnVVLzVv?=
 =?utf-8?B?UzBaa0lqUnI2QWxnUzlPekZxbUpqOG9halJQMTU3TVJ5OENwM3dkVnpmV0pk?=
 =?utf-8?B?aWd3SERNakFVcmJNajZxaUJCL3RuaFZIajRzYlNpa1BvQVhkZnd6UjRJU0dJ?=
 =?utf-8?B?QlhXUW9zKzg4akRHaDZ5K1VRdDhKUlo5eUw5UGtZUG5sZGZvV1NSenI4Vm9D?=
 =?utf-8?B?UGFOSXQydS9KQjc5RlBnWTlhM2lRbVZNZERMUWU2NmpEZ253MVpqRm1iWnV2?=
 =?utf-8?B?c3RVTlAzRkNQVVVSWDhZanNodGJuZVkraFczT05CT0hxcDJOZEZqek94VnAx?=
 =?utf-8?B?b0RqeVNKUW9zZndiOTZkVEhBYWFLVHdrRG9JTzB5M2hQT29NSEh3VVdjNmVP?=
 =?utf-8?B?K0ZLbXBoTnUydlJKQWRpS0M5N2pSZ3h3RFY5UXo3THc1aysrelA0UFhxMUdP?=
 =?utf-8?B?TjdFcVozaUcwcTE5Ymp1REpvazJPV0lIdGdBeE10RFhCVFhuTTBpQ29VSEdm?=
 =?utf-8?B?ck1zRTJhUmFjdlJXNXE4UWFQajRMYVJtSHNlSjVLMjlYa1lxWis4d1V0VlNE?=
 =?utf-8?B?bTg3M3I2ZXpjVGZOVysvOTEvamw0OW11Znk3OXFjR2hma2tyS3NDWlRUaUc4?=
 =?utf-8?B?Z2Zad3F4YkhZYWREYUxHdUN6MWF1SVVwYkhCNzlONUpLYjV0dXQzZEFzMHRy?=
 =?utf-8?B?UVFLQjIxOVlZL0dqRkFCa2todGRvMHREL3MxZktualBnRktjc05FS2k2Sjhq?=
 =?utf-8?B?dWdoa3NHa1p6SkdnNVN1V0hxek8wYUdRWUdmK1hVY0t2Q0pSblp4ZHR2MXZL?=
 =?utf-8?B?WkJubDRNNk4vM1YyOUgyK3lCdEpFbzMyT2lmZkNZR3NRVmVZTTBYUENyVmZH?=
 =?utf-8?B?blgxSnNmSURNbDYzTFFrM01SMzQyR0lxQzEyKzhjRlQ0SE04QlAyRFNuMTRS?=
 =?utf-8?B?WitxV0pzbXF0RVJmSkZxbCtWWnp2MjVsZmFaMGVFUzNpaFpOUENLMVBUT3VB?=
 =?utf-8?B?RVBRN2xleWRQaEN2UjZBYXdaOWRhN3pmVjczUUpnTkY0eXZkcThKWnRCVkZ3?=
 =?utf-8?B?UkIvbVM4UlVZRWR4aGhuUjB1WGhJQmd5aUQ0QnBoY1UwNGZkRml5T0hVTGpo?=
 =?utf-8?B?R2lXUjUrai94ajdIRWphdW50V3VrTllWam4vUWZsOHI3ajUza241OVNBaVNy?=
 =?utf-8?B?eldWbGo4NVV5a21EU1BQL1FjNEtFN3FoSG1SK3JSb1JXMGNhN21uWUV0YXpS?=
 =?utf-8?B?Q0paTWNyK1V1SzcvcGpGc3kraUJXcFptWnhIKzFveUVqSFF2R25PbjdxK0s0?=
 =?utf-8?B?YWdSMUdSd0FPaG9vZ0FjV0hjcWNzUS9aMExCWXZrVy9NUGYrSnhWMlRJVWMz?=
 =?utf-8?B?RGljTlVzK2JDaTRyZUJkbUZXRjdtNHgvT3pBSkRZVnFKYTBlUUkvMEVsZktK?=
 =?utf-8?B?elVWdHpHSjhFWlJlY2p5VVh5U0tXM3ZzeHBwRnpmMDlyVFJJUkJQWmsrTGU1?=
 =?utf-8?B?Nk96dmVsQUg5cFdKcS96elZBU1lDYytJSElLb0QrTnR1a0c4b1VmT2d3SEtZ?=
 =?utf-8?B?ZEhZN3NxcDF4WFR1MkxOVkIrOUJBY1g2bi9tOEZ1dzhjV3phZzMxb3UzQ2xX?=
 =?utf-8?Q?T5OPLg9Z1Z6zRx9e6zujg0sVGzsYo6rEQbsQgbhH80Co?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f6c1c86-bd64-4de4-f68a-08db67388327
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 09:21:02.1833
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sr2FaDIE6IZkeGbmMR5GqdU8DaqZp7W7FnFgoXl5Ii37Jk9p+lRvrNylo6dH7Ebj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8929
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Acked-by: Christian König <christian.koenig@amd.com>

While you are at it: It's beneficial for drivers to implement the flush 
callback on the file descriptor.

This way you can still send a SIGKILL when a terminating application 
waits for the entity to be flushed out to the hardware and all the 
pending jobs are canceled.

Regards,
Christian.

Am 07.06.23 um 06:04 schrieb Qiang Yu:
> Reviewed-by: Qiang Yu <yuq825@gmail.com>
>
> Applied to drm-misc-fixes.
>
> On Wed, Jun 7, 2023 at 9:18 AM Vasily Khoruzhick <anarsoul@gmail.com> wrote:
>> On Tue, Jun 6, 2023 at 7:33 AM Erico Nunes <nunes.erico@gmail.com> wrote:
>>> The drm sched entity must be flushed before finishing, to account for
>>> jobs potentially still in flight at that time.
>>> Lima did not do this flush until now, so switch the destroy call to the
>>> drm_sched_entity_destroy() wrapper which will take care of that.
>>>
>>> This fixes a regression on lima which started since the rework in
>>> commit 2fdb8a8f07c2 ("drm/scheduler: rework entity flush, kill and fini")
>>> where some specific types of applications may hang indefinitely.
>>>
>>> Fixes: 2fdb8a8f07c2 ("drm/scheduler: rework entity flush, kill and fini")
>>> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
>> Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
>>
>>> ---
>>>   drivers/gpu/drm/lima/lima_sched.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
>>> index ff003403fbbc..ffd91a5ee299 100644
>>> --- a/drivers/gpu/drm/lima/lima_sched.c
>>> +++ b/drivers/gpu/drm/lima/lima_sched.c
>>> @@ -165,7 +165,7 @@ int lima_sched_context_init(struct lima_sched_pipe *pipe,
>>>   void lima_sched_context_fini(struct lima_sched_pipe *pipe,
>>>                               struct lima_sched_context *context)
>>>   {
>>> -       drm_sched_entity_fini(&context->base);
>>> +       drm_sched_entity_destroy(&context->base);
>>>   }
>>>
>>>   struct dma_fence *lima_sched_context_queue_task(struct lima_sched_task *task)
>>> --
>>> 2.40.1
>>>