Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 12:16:06 +0200
From:   Michal Hocko <mhocko@suse.com>
To:     Haifeng Xu <haifeng.xu@shopee.com>
Cc:     rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone
Message-ID: <ZIBY5niJ/7vvwdHC@dhcp22.suse.cz>
References: <20230607090734.1259-1-haifeng.xu@shopee.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230607090734.1259-1-haifeng.xu@shopee.com>
Precedence: bulk

On Wed 07-06-23 09:07:34, Haifeng Xu wrote:
> If freesize is less than dma_reserve, print warning message to report
> this case.

Why?

> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> ---
>  mm/mm_init.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 232efac9a929..9a9d6a52471c 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1561,9 +1561,14 @@ static void __init free_area_init_core(struct pglist_data *pgdat)
>  		}
>  
>  		/* Account for reserved pages */
> -		if (j == 0 && freesize > dma_reserve) {
> -			freesize -= dma_reserve;
> -			pr_debug("  %s zone: %lu pages reserved\n", zone_names[0], dma_reserve);
> +		if (j == 0) {
> +			if (freesize >= dma_reserve) {
> +				freesize -= dma_reserve;
> +				pr_debug("  %s zone: %lu pages reserved\n",
> +					 zone_names[0], dma_reserve);
> +			} else
> +				pr_warn("  %s zone: %lu reserved pages exceeds freesize %lu\n",
> +					zone_names[0], dma_reserve, freesize);
>  		}
>  
>  		if (!is_highmem_idx(j))
> -- 
> 2.25.1

-- 
Michal Hocko
SUSE Labs