Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 13:16:22 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Paolo Abeni <pabeni@redhat.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
        Peilin Ye <yepeilin.cs@gmail.com>,
        Pedro Tammela <pctammela@mojatatu.com>
Subject: Re: [PATCH RESEND net-next 2/5] net/sched: taprio: keep child Qdisc
 refcount elevated at 2 in offload mode
Message-ID: <20230607101622.bhrentqv2y4c5ewj@skbuf>
References: <20230602103750.2290132-1-vladimir.oltean@nxp.com>
 <20230602103750.2290132-3-vladimir.oltean@nxp.com>
 <6bce1c55e1cd4295a3f36cb4b37398d951ead07b.camel@redhat.com>
 <20230606155605.so7xpob6zbuugnwv@skbuf>
 <c4707459ac2cb0b48cb9552e83ad4057ae5b9300.camel@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c4707459ac2cb0b48cb9552e83ad4057ae5b9300.camel@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vBePksbl2uPqg2suEQxqbk80kOTRR4o9QiwaVnYf2DB47hRHTBt6IQs8NuBk?=
 =?us-ascii?Q?Cc4xDpwR5OOI6hBFJCdBvL8v33oS1oPWmrfzCUgLmuXfjBIXuFCqlmRRKJ//?=
 =?us-ascii?Q?xnyGvSMLyo319C8KneXXFSJ4Uo4Yq8Xw1dNlqUBNUc6+0d7DDV9g7DMLXqnT?=
 =?us-ascii?Q?n/qu7lw/RsyIiyWxFbMf/1j+U5a5KxRjYtwWVLNbMZ8G7994HWtw0Za4B+KL?=
 =?us-ascii?Q?H8jR3ALbPx2Zvflqqp6RRwrqv9PuEeXlbttfoiL525/pJW5Wi1iigakXJt4A?=
 =?us-ascii?Q?5D6mTvghWs31X64M586/VIkE76S1NnrWyLqC3HIuxd+slnhjjedRVspQB6JW?=
 =?us-ascii?Q?O80G9pOi17ZR6iPFKIPqIK4xkFN6bkQsyMQ414La/KdRJtCjBjtsUHvOqynR?=
 =?us-ascii?Q?FoQFMZwn9n/gsqw2vvtd++otGlM9jvPZOSrwNSZymR/1ACOZtDlFK07KbTkO?=
 =?us-ascii?Q?dJk91yn44QX6qFjS/27kjKX7fVuO3PmJNXRpXQTacqZQBY6Fq6Bb2+5xR6IK?=
 =?us-ascii?Q?Ltkzou3U3hnucd2FgpZ8FjvGFJqk0g482yhfY1YEUJuvMxdsO5YZZfnoX4D6?=
 =?us-ascii?Q?VhP8KJMXsmNdFZmRhNG/mL9lQVMpa+np1salWrpn/tEeUnLTtxjzdach2HKI?=
 =?us-ascii?Q?y1wguJIbsshgD7LQWi5txgFK8IX4tlXJ5pj/qcm5wBkSCYVZmwBHnAeLvnk2?=
 =?us-ascii?Q?p7A/zt1E7eq7QMHZTSXlRVnGZH45HzWf5dqsKTnJ/6dVMqbeheFeMNPVLYhV?=
 =?us-ascii?Q?uNU8g67ya1FE/egIp9huCrU6l9KrDA0Qlg+ajdMk+BgrRDsDWllGOO4oZh4W?=
 =?us-ascii?Q?euu2ZDivwCBUKthSvc9b1fuYlEczMRDgH+3bUZW+RjfTcacMu1cUbYLD8Z/7?=
 =?us-ascii?Q?aFmQ8CmvGs4fU2pWGO64xJXi9as3B1FjM81RhtHZXk+8QijzopAxv9uJkoDp?=
 =?us-ascii?Q?7XwW4P4aw7lLWrtvOlkKWmH6fGke/OyJMhDUNy/6rc81oiMcFkDJyIDzVUdg?=
 =?us-ascii?Q?+3Gca6ELDfUgxSaf9bcL2pbYVaqnJvJiLU6oXj7XhnQhbAFx83yYgifqYn6A?=
 =?us-ascii?Q?55X87i4ygc5D1P88dUD1Fwqc6X7/QE+zJIhTbymzPrIUiKt2KbFmjmeWXdrz?=
 =?us-ascii?Q?qsdqLye1pBqJichxw/EQX4O4Dx+KNFRdOLzW/AMTHrKG2MJ5VjobnX4gxq2j?=
 =?us-ascii?Q?jbBGI8UXA+7UsAHDvfQhonJLuoosrzCMYZ0gZRLzutFzMSAKebhACahYfRM6?=
 =?us-ascii?Q?RKvf2aK49MqzTcvExrLlT3DpXYBteRkG/HVdYFRmcQsvRAm1Mva0X0HVjNYc?=
 =?us-ascii?Q?+hNllyAJzBRCQCk2DTwiF8jp9fexQyRFW5McGWUJPXW9K57Vu91iBVLWXbLf?=
 =?us-ascii?Q?bEbgyEJwMCArWfhTlPP0kLNGhEz8TLhJOQdGNK66E/s9zz03z/z8AxqvtNvy?=
 =?us-ascii?Q?P/T9HfpypKW6CMKePJNycGm0kxdbRbgb4D7oftQ7uQBTxSSJPLErvgHJIkRr?=
 =?us-ascii?Q?KGcLXRmzG+kUwQumGSzmYECscyneRuU5BGnA9pcFXkDA5zYZoES48UbXefBi?=
 =?us-ascii?Q?7D8ARW6PQFU2PuocQYNtjlQyBmtq5AW/HD4kqfAE+gUK3lLcSEUMVtmqlRZX?=
 =?us-ascii?Q?YA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 697d3234-6f47-472a-0b6f-08db67404040
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 10:16:25.8309
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J1y4tsb3a82b3cp8um0dgUUfWwU6mhP7jJaetCD1P6As3RRQ76a7iI/dsTPot0tkrV4nf/P7AE4U1NhY6czvIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8075
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 07, 2023 at 12:05:19PM +0200, Paolo Abeni wrote:
> Perhaps the above chunk could be:
> 
> 	*old = q->qdiscs[cl - 1];
> 	if (FULL_OFFLOAD_IS_ENABLED(q->flags)) {
> 		WARN_ON_ONCE(dev_graft_qdisc(dev_queue, new) != *old);
> 		if (new)
> 			qdisc_refcount_inc(new);
> 		if (*old)
> 			qdisc_put(*old);
> 	}
> 
> (boldly assuming I'm not completely lost, which looks a wild bet ;)

Yeah, could be like that. In full offload mode, q->qdiscs[cl - 1] is
also what's grafted to the TXQ, so the WARN_ON() would be indicative of
a serious bug if it triggered.

> > > BTW, what about including your tests from the cover letter somewhere under tc-testing?
> > 
> > I don't know about that. Does it involve adding taprio hw offload to netdevsim,
> > so that both code paths are covered?
> 
> I guess I underlooked the needed effort and we could live without new
> tests here.

Let's see how the discussion progresses.