Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ccc68b26-0896-2f2d-ba54-038f34e9eaa2@redhat.com>
Date:   Wed, 7 Jun 2023 12:22:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] mm/mm_init.c: add debug messsge for dma zone
Content-Language: en-US
To:     Michal Hocko <mhocko@suse.com>, Haifeng Xu <haifeng.xu@shopee.com>
Cc:     rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20230607090734.1259-1-haifeng.xu@shopee.com>
 <ZIBY5niJ/7vvwdHC@dhcp22.suse.cz>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <ZIBY5niJ/7vvwdHC@dhcp22.suse.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07.06.23 12:16, Michal Hocko wrote:
> On Wed 07-06-23 09:07:34, Haifeng Xu wrote:
>> If freesize is less than dma_reserve, print warning message to report
>> this case.
> 
> Why?

I'd like to second that question, and add

a) Did you run into that scenario?
b) What can an admin do in that case with that error messages?

If it reveals a buggy situation, maybe a WARN_ON_ONCE() is warranted ... 
but maybe only if anybody actually ran into that issue.

-- 
Cheers,

David / dhildenb