Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <496889ff-dd61-51af-c716-b9b9e2300be7@nvidia.com>
Date:   Wed, 7 Jun 2023 11:55:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] gpio: tegra186: Check PMC driver status before any
 request
Content-Language: en-US
From:   Jon Hunter <jonathanh@nvidia.com>
To:     Prathamesh Shete <pshete@nvidia.com>, linus.walleij@linaro.org,
        brgl@bgdev.pl, thierry.reding@gmail.com,
        linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     smangipudi@nvidia.com, Manish Bhardwaj <mbhardwaj@nvidia.com>
References: <20230606071717.8088-1-pshete@nvidia.com>
 <56dcfcff-3b36-25ea-eb72-2b9d2f8f3883@nvidia.com>
In-Reply-To: <56dcfcff-3b36-25ea-eb72-2b9d2f8f3883@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGhqVlUyd0VHQ20xc1F2ajc4Tmx1S3F1eXVzQU1GeDFWQWd5L3JuTjlYVjNC?=
 =?utf-8?B?bWg3NUtxcDNrM0xFWU9zZUV2ZjRiNGg2WnpEZXc0QzlYTkdTaEhLNUNTSTVZ?=
 =?utf-8?B?TG9zaVhacXZRTUhnRTlrL0wvUFFmcFQvMXg5OWRYSEhoRThIc1d4V2hjbytq?=
 =?utf-8?B?ZW9rU05XZzNJOXFIQmZYRHZZMzB0REdyS0hpNTU2VDdoS041bEVxa2RiSXk2?=
 =?utf-8?B?Wjd0RFNJdXJZN2hwNGRKVEQwTEF5N3lxd2c5QmxteHRVeTlac1lmZjMvcnRO?=
 =?utf-8?B?RVlUWjR1aTB1ZjlMMk52K3FaZzB5bGRZTE4yL1o2LytXejRLcU95OVluUFAy?=
 =?utf-8?B?a0NvOG1ZUmRDWCs2OUlxL2hHMGZJa0plY3hhWWlmV2dsRXQvQ0JzWER3aDJL?=
 =?utf-8?B?Ykdicnd5UzlJWHZ0SGFOU2N5dWo1aWtzU3ZTcDBCVUtnWjl4VnN1V1dLKzZM?=
 =?utf-8?B?dkJHKzRnMWszbDlDbHpodSs0SG8rMCtUMGJzWmxYQmxEVzZreDZseThrb3Nk?=
 =?utf-8?B?ZENGSSthYVVTK3NMUGduSnc5T0NKUEV6Qk1HdEVSYVVJdkdaZnA5NW9Qcm9H?=
 =?utf-8?B?ZVFMemxXNWo1ZlNEK1luV0d6NVlzelp1bDkzTjNlaDl5Z0xlTitkZzUzZFVw?=
 =?utf-8?B?TE45Um9IZGhKZEwzMFJORzNLY2hoV2hHZVorWkdTZkpHVjNPN2kvRzh0bEl6?=
 =?utf-8?B?cDFGdS9qdmpZa2JKTXpTTVhzUTBoNGN0VUNPL1E3L0YxcElmclQ1SHRzNlF0?=
 =?utf-8?B?SnREK1FsZXR0V25JS3R0YTVzTGlyT1l5NHpBS3NBRWpFREMzZ1IyZnlNa25B?=
 =?utf-8?B?WDhOeUZEdjI3UGFZakhSZVhYL3VXZ21HZFM4clZhR0lHYmxSZkhHd2pHc1B1?=
 =?utf-8?B?elpTZ1pqb2x3OU0zSmVqZ201d29wUFE3ZFBiZ3ZiSTQrN3lIbG5uelA1VjB4?=
 =?utf-8?B?M29HNEhLamdvWjdWeTl2UlR1MmYvQ0ZObkdRTXdPYklMYmtwMmFEbm1vRU5z?=
 =?utf-8?B?SUkvcno1dHpoNlE2U2psTmhSZE5sZjhDdXN6WlhScE1CZzhMaFRHVW5YRXJo?=
 =?utf-8?B?WVJKcDRQR3lmUVNrUDJOYXMzdEJYV3huUWJaSzJ3TEZNZEk1YXIza2hoem8v?=
 =?utf-8?B?V05UUnhTM2drSVhsVFZlMGdyOENxZFJkc3g2Y0hIb09mQkpQdis4RkJqY0Jv?=
 =?utf-8?B?ZW1za0NaTHZVZGZLRVYzalZaSS9JcFdHNHAzaXpnc2hUMnJ0NnhKVW41Wmg2?=
 =?utf-8?B?dEh6VDNlUEhRUExNM0pDS3dxVkc5T3FvWitVMVF5UVpJdTRCem91czkyb0t2?=
 =?utf-8?B?SVhJcXFIbTZiYm5Md1lEWVhZdjdUSk1VY3lWWTJsMHBRUExBS2kyODh0OXAv?=
 =?utf-8?B?MXF4TUEzaWlBeVA0L0FKZXlUUERsSEc5Z1B5UlhQVzBUTEw2Q213bWhwU09S?=
 =?utf-8?B?T0RsQXA0WmVkUmhZTmNlb25LK3ZqSGNLQ0JncmZyUzIwZ0JaSmFocmkzbUZF?=
 =?utf-8?B?RlJDVW5pbnRZc2xOV1lXUkw3dnFrYWhDSkRDaGFab0pGeEYzWkdGTjFXWnJz?=
 =?utf-8?B?RWg3RU5pU25zRjRiOU4vT3huV3l3Vm11QmplQUFSdFFWTzgzMmlFbzBheXRk?=
 =?utf-8?B?cU8wMEZYNkhlb3NkbkRkdHZHa3dCbmdQVkhaZTNIUVluTitiaGo0SVZRNFBs?=
 =?utf-8?B?U0pHeXovWHM3OVZPT3U5c2djRzBiNzYvK3o3N0xaTmxkL245Y2o2aFIweW1T?=
 =?utf-8?B?VG9lMExVa2JxckxSNWloaWZPTHF2MVl2a3hBeEoxM2ZhbTJZMThLNWs1WHRx?=
 =?utf-8?B?c3hpWXo1RUdzdGpmRFBrSTlDTnFXWWFuSzhkSWZyaW83Q04xWXlOUXNMdEN1?=
 =?utf-8?B?ZG1uM3V6eitiTUhYVE9wYjNnbWpScjRVQjV6M0VPVTVvZ2dXakc5RkN2YVR0?=
 =?utf-8?B?Vmx5TDJjenptVWN6b1RhNFBFYTM1UXVLVVY2ckVSVEsvMmxCazQxZWlSMEVV?=
 =?utf-8?B?Y29pc3BYR1VQUFFDSVYrT2VPa2lTNzVrQVVBSUJKdzBZelhtWXFtTW1IdlIw?=
 =?utf-8?B?cGVxeUNMTVdYS3U4c1dIM1RzVjE5RE5zOEovZWJsUkpDalV0c3MwUnRzNU5Q?=
 =?utf-8?B?THpWWHNzMXFuUUJRRkx6aFhDWjgzU2pFTUhtTEp4bnlTcklJVksrUGNVMzVn?=
 =?utf-8?B?Q1ZTYWV3OE56b1NMblJtdHJ6US8wM3BVbjFxelY0UlBWUEx2UVRSSVg2WmFj?=
 =?utf-8?B?VExqaEpKcms4UzF0NFpQOUU3SldnPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d67cb3c4-90e2-47eb-2cfe-08db6745b6a0
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 10:55:32.0166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7ltX42xOptV7xjGEJobxZ4xpPxe/h6eGiv6zdvbjybPu50F/wtBO3iohxvBXhL8tSenqysf/59GQ5NurPbMLKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7725
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 06/06/2023 09:53, Jon Hunter wrote:
> 
> On 06/06/2023 08:17, Prathamesh Shete wrote:
>> This patch fixes the issue where even if PMC driver status is
>> disabled still we are trying to look up for the IRQ domain
>> that PMC driver would've registered if it had been enabled.
> 
> It might be clearer to say ...
> 
> When the PMC device is disabled, probing of the Tegra186 GPIO driver 
> fails because the IRQ domain that is registered by the PMC driver is not 
> found. Fix this by checking to see if the PMC device is enabled before 
> attempting to lookup the IRQ domain registered by the PMC.

It could also be worth noting that it is OK to skip the PMC IRQ domain 
in this case because this only impacts wake-ups and not GPIO 
functionality in general.

Jon

-- 
nvpublic