Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 13:07:12 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     <wei.fang@nxp.com>
CC:     <claudiu.manoil@nxp.com>, <vladimir.oltean@nxp.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 net] net: enetc: correct the indexes of highest and
 2nd highest TCs
Message-ID: <ZIBk4P1MGWsdKozn@boxer>
References: <20230607091048.1152674-1-wei.fang@nxp.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230607091048.1152674-1-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GLT+Tog0HzcVUdVS4EcYp5j7Uk0M/8dqM3yf6nsKxAf9irGd4j5C4LMEBhSo?=
 =?us-ascii?Q?Ib+mKc04GA6OTBpH8Z4qFPW5SkFprtL1L+rQVXEBxzym4KLG3thi2I13NGYl?=
 =?us-ascii?Q?RswSFPYm7WctKrmUlpnc3v4w8NbAqcc5jNlQf1dnLOCgaaGOmhni2znpyQp+?=
 =?us-ascii?Q?jtAqc6ClUGi5AjLQCBr+/MGVwXtDWiZfl1AaJ42y9QA5oWojqn/uSioeK+YI?=
 =?us-ascii?Q?fQd0/K1B9ZCpPOoBftvX7nV15JPeikjaCnpMuLGRRVhjHWiCgi0h0rEPOYB/?=
 =?us-ascii?Q?w7VKysx8hMwI6MsHlfXRf/9e4+WZRJll/s5yqtE7BeiHMkGpfYpuJU8yUZ2u?=
 =?us-ascii?Q?juqOofnijVRxZ/odNB4QvqSgzDkEmOjTRRHRs7ylZZZboZ7O06q8nzF8n/0Q?=
 =?us-ascii?Q?nGIEyXzMJ+aU++Y4vfUf0Kklvi1838HVINMmFoPr++zpJAF/wb+mTKFin2k0?=
 =?us-ascii?Q?CYmI8zMo8lkpj4RqqGe3Yp2Hn/G+IG3vWZ3yzd9akY9qYzqD6Wct8f1wG9tR?=
 =?us-ascii?Q?dU2ONOf+CzgsbKmR1pQj34FQNV8Z2gDVTKvRUDRj0wUKctgHa6ya5GH5QQ6M?=
 =?us-ascii?Q?3Sc5ptLI2t63QFl95gEJqjwm3mrao8g87SwOLv5L8qrIyHXLDzvgPlZAHOmY?=
 =?us-ascii?Q?x04kYguGYKRS07CrLFqkaZDBDdamtLfwKMRkQ2exX/VzJBX9XmFawyM6ohUQ?=
 =?us-ascii?Q?ASQXH4bXPsGOo10UF4bRa4J/KQaO7ihxc9f4dzF40KSTyFt6UJl0trCVDQhq?=
 =?us-ascii?Q?n638vfOASc1Hmd1TlKKbE6gWSd2hYSLyqe3ar9Tvt2/05VeeBwHpOOvzT6B7?=
 =?us-ascii?Q?mtvdoJDXLHIoNNe5PtKDz31Q0jHi+87S+xEvVszCIamLQ4IOxFZRIQB4TRbJ?=
 =?us-ascii?Q?wGoBKH/2Mlka2mXnknL2INMrXNBExuMdNYVJol00X0lKSQxoGoQrJ3nWAs5y?=
 =?us-ascii?Q?D6khQn0dUYEBdI42naEKFGNJCqFlb5wFJk0uWBtVuB9G8Oetir+saji7BR/1?=
 =?us-ascii?Q?WjYbQUzxjnP9wICgkXqyv0CaZ5YYNBoo747uqcrkWvdB7Id6vhi9LMn4na7V?=
 =?us-ascii?Q?BNJHgDsLGcz3gghE4ayniLLor3Vzwnwy6M1RsxETYZCm+c0xxDez6PXV2biA?=
 =?us-ascii?Q?PLTb3FBbVYOMtuF415LPrr9QwTkx/te9ZqjCTL4qEmLRBhb2BkY82A8+41As?=
 =?us-ascii?Q?JG/dz8DWKi5LUdmO4ZSnn4DwM1ESHhzWHsR5mdLHSMiz2+sbHTsl78ZxUFv0?=
 =?us-ascii?Q?twfjrFseZw8JQOAGdP9orVffYWLKlcLnPG+9Bh1gcGVryjT3MFegFC8TPFQK?=
 =?us-ascii?Q?uAo04sDWz9A8r9GvIAZ1jzAjlZtoEikX3ZPF1q25VO5BY9dL9et0DhpWM5Pc?=
 =?us-ascii?Q?HxQRTR6Q/QtUCDLkWtTceQrwVjNJC0Lshbz9ksKRm8hgGrnDGo5TnG7FRIdA?=
 =?us-ascii?Q?d5pcBV8ST1hHvnzn/v9IUkracsgsiRaQRnsmoo9NeklTIQ8dCKVk28GJuBwl?=
 =?us-ascii?Q?p8eZhlW0PjdQZHKqR9ey47eHG3gkcqBUucHWryTHIwsScduyHwgBbFKrNIU2?=
 =?us-ascii?Q?mZBLmX085SJnLK9L+/PgVKhg98KC4aiq7YwH+/cOxrasjzngNHceQ+WeLulw?=
 =?us-ascii?Q?Solib4cyJEAQth2gmL6TGrU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 56510d7a-34e6-4258-50bd-08db67475c5e
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 11:07:19.4816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zdOJQ42j9ZmOu8rPAn949WgHzWNUz0sA3RDl0uwhoFVETySsgqEO8jNhak+zd3hagA/o2Vj8cW5W1h3EnJHNqg6s8WLsqUz6aDOq/7327hs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4663
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 07, 2023 at 05:10:48PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> For ENETC hardware, the TCs are numbered from 0 to N-1, where N
> is the number of TCs. Numerically higher TC has higher priority.
> It's obvious that the highest priority TC index should be N-1 and
> the 2nd highest priority TC index should be N-2.
> 
> However, the previous logic uses netdev_get_prio_tc_map() to get
> the indexes of highest priority and 2nd highest priority TCs, it
> does not make sense and is incorrect to give a "tc" argument to
> netdev_get_prio_tc_map(). So the driver may get the wrong indexes
> of the two highest priotiry TCs which would lead to failed to set
> the CBS for the two highest priotiry TCs.
> 
> e.g.
> $ tc qdisc add dev eno0 parent root handle 100: mqprio num_tc 6 \
> 	map 0 0 1 1 2 3 4 5 queues 1@0 1@1 1@2 1@3 2@4 2@6 hw 1
> $ tc qdisc replace dev eno0 parent 100:6 cbs idleslope 100000 \
> 	sendslope -900000 hicredit 12 locredit -113 offload 1
> $ Error: Specified device failed to setup cbs hardware offload.
>   ^^^^^
> 
> In this example, the previous logic deems the indexes of the two
> highest priotiry TCs should be 3 and 2. Actually, the indexes are
> 5 and 4, because the number of TCs is 6. So it would be failed to
> configure the CBS for the two highest priority TCs.
> 
> Fixes: c431047c4efe ("enetc: add support Credit Based Shaper(CBS) for hardware offload")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

Thanks!

> ---
> V2:
> Improved the commit message based on Maciej's comments.
> ---
>  drivers/net/ethernet/freescale/enetc/enetc_qos.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
> index 83c27bbbc6ed..126007ab70f6 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
> @@ -181,8 +181,8 @@ int enetc_setup_tc_cbs(struct net_device *ndev, void *type_data)
>  	int bw_sum = 0;
>  	u8 bw;
>  
> -	prio_top = netdev_get_prio_tc_map(ndev, tc_nums - 1);
> -	prio_next = netdev_get_prio_tc_map(ndev, tc_nums - 2);
> +	prio_top = tc_nums - 1;
> +	prio_next = tc_nums - 2;
>  
>  	/* Support highest prio and second prio tc in cbs mode */
>  	if (tc != prio_top && tc != prio_next)
> -- 
> 2.25.1
>