Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 14:19:57 +0300
From:   kirill.shutemov@linux.intel.com
To:     Kai Huang <kai.huang@intel.com>
Cc:     linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
        peterz@infradead.org, hpa@zytor.com, konrad.wilk@oracle.com,
        rostedt@goodmis.org, jpoimboe@kernel.org
Subject: Re: [PATCH] x86/kexec: Add a comment to relocate_kernel() for better
 readability
Message-ID: <20230607111957.sppocwpkhfb2e2vf@box.shutemov.name>
References: <20230607103910.407779-1-kai.huang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230607103910.407779-1-kai.huang@intel.com>
Precedence: bulk

On Wed, Jun 07, 2023 at 10:39:10PM +1200, Kai Huang wrote:
> The reason to save %rcx to %r11 before calling swap_pages isn't that
> obvious w/o looking into the swap_pages itself.  Add a comment to
> improve the readability.
> 
> Signed-off-by: Kai Huang <kai.huang@intel.com>
> ---
>  arch/x86/kernel/relocate_kernel_64.S | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S
> index 56cab1bb25f5..97deae3c5e6c 100644
> --- a/arch/x86/kernel/relocate_kernel_64.S
> +++ b/arch/x86/kernel/relocate_kernel_64.S
> @@ -169,6 +169,10 @@ SYM_CODE_START_LOCAL_NOALIGN(identity_mapped)
>  	wbinvd
>  1:
>  
> +	/*
> +	 * Save the preserve_context to %r11 as
> +	 * swap_pages clobbers %rcx.
> +	 */

Line split is not needed. It fits nicely under 80-characters.

+	/* Save the preserve_context to %r11 as swap_pages clobbers %rcx. */

Otherwise, LGTM.

>  	movq	%rcx, %r11
>  	call	swap_pages
>  
> 
> base-commit: 409bf2895d71bb68bc5b8589036e5ed1ca30bada
> -- 
> 2.40.1
> 

-- 
  Kiryl Shutsemau / Kirill A. Shutemov