Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 12:44:25 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Walker Chen <walker.chen@starfivetech.com>
Cc:     Claudiu Beznea <Claudiu.Beznea@microchip.com>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Takashi Iwai <tiwai@suse.com>,
        Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ASoC: starfive: Cleanup and fix error check for
 JH7110 TDM
Message-ID: <3eb7ffc5-a16a-4ac2-93a0-260f7cb1f81c@sirena.org.uk>
References: <20230607081439.1517-1-walker.chen@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="LfKPoAKPg/endcMK"
Content-Disposition: inline
In-Reply-To: <20230607081439.1517-1-walker.chen@starfivetech.com>
Precedence: bulk


--LfKPoAKPg/endcMK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 07, 2023 at 04:14:39PM +0800, Walker Chen wrote:

> Some minor issues were found during addtional testing and static
> analysis. The patch fixed these minor issues.
> 1.Use BIT() macro to indicate configuration for TDM registers.
>=20
> 2.Fix the check for devm_reset_control_array_get_exclusive return
> value. The devm_reset_control_array_get_exclusive() function may return
> NULL if it's an optional request. If optional is intended then NULL
> should not be treated as an error case, but as a special kind of success
> case. So here the IS_ERR() is used to check better.

As covered in submitting-patches.rst please submit one patch per change
rather than combining multiple changes into a single patch, it makes
things much easier to review and handle.

> -	datarx =3D (tdm->rx.ifl << IFL_BIT) |
> -		  (tdm->rx.wl << WL_BIT) |
> -		  (tdm->rx.sscale << SSCALE_BIT) |
> -		  (tdm->rx.sl << SL_BIT) |
> -		  (tdm->rx.lrj << LRJ_BIT);
> +	datarx =3D (tdm->rxwl << 8) |
> +		  (tdm->rxsscale << 4) |
> +		  (tdm->rxsl << 2) |
> +		  TDM_PCMRXCR_LEFT_J;

I'm not sure this change to use numbers here is a win - the _BIT
definitions look fine (I might've called them _SHIFT but whatever).

> -static const struct of_device_id jh7110_tdm_of_match[] =3D {
> +static const struct of_device_id jh7110_tdm_match[] =3D {
>  	{ .compatible =3D "starfive,jh7110-tdm", },
>  	{}
>  };
> =20
> -MODULE_DEVICE_TABLE(of, jh7110_tdm_of_match);
> +MODULE_DEVICE_TABLE(of, jh7110_tdm_match);

This rename wasn't mentioned in the changelog.

--LfKPoAKPg/endcMK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSAbZgACgkQJNaLcl1U
h9A99wf+NSaIxGIf4YZKSPJ7aahCikFSJ8QzZ93+jeCBXfB3MhCCrzVLVzFnUrv3
SQWddp2m5MWKBSt4icNmTEmweGEtv2Ec6FtXgo8dRimVUCd6W1EFxtT4UvzKJbiT
oFA3XyST93OE3gZxQpNehPIf6pXrgvtVfBlZLoqk4FdL1YS1VpD7EeOh5Y+afwYD
rWilBo5XnXxhx8a0rexNC9N/aDx6m3JGItGftPghXqQpGutTp0mRse92+pCiH79A
tfaG4ZEI9ugOXFuk+4uDhr5N2/6so5mS/ND5AHaFFSPLZ0AW0Q0Gr33vggAzxGCe
2QvWgXdAEkJikvqwETOVosS0KMHehA==
=CVs9
-----END PGP SIGNATURE-----

--LfKPoAKPg/endcMK--