Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02418a3d-ce8f-0f00-ba93-06ceb3531490@redhat.com>
Date:   Wed, 7 Jun 2023 13:38:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 2/2] mm/mm_init.c: remove reset_node_present_pages()
Content-Language: en-US
To:     Haifeng Xu <haifeng.xu@shopee.com>
Cc:     rppt@kernel.org, osalvador@suse.de, mhocko@kernel.org,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <d92273f6-28be-dc37-3ca5-a9579a75f8c4@redhat.com>
 <20230607025056.1348-1-haifeng.xu@shopee.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230607025056.1348-1-haifeng.xu@shopee.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07.06.23 04:50, Haifeng Xu wrote:
> reset_node_present_pages() only get called in hotadd_init_pgdat(), move
> the action that clear present pages to free_area_init_core_hotplug(), so
> the helper can be removed.
> 
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
> ---
> v2:
> - declare 'struct zone' within the for loop
> - fix comment layout
> ---
>   mm/memory_hotplug.c | 18 ------------------
>   mm/mm_init.c        | 15 +++++++++++++--
>   2 files changed, 13 insertions(+), 20 deletions(-)

As Michal said, we could be clearer that this simplifies the code (and 
removes a TODO).

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb