Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 15:03:44 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org
Cc:     Vladimir Oltean <olteanv@gmail.com>, linux-kernel@vger.kernel.org,
        Lisa Chen <minjie.chen@geekplus.com>
Subject: Re: [PATCH] spi: fsl-dspi: avoid SCK glitches with continuous
 transfers
Message-ID: <20230607120344.ui2ubzdkb6cbjm5o@skbuf>
References: <20230529223402.1199503-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230529223402.1199503-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+u/7DNGhfgXBihbBpt3+angrIfVEeV9Nqlk4SiiId7/7I2B9G4HpKSi4Y6m3?=
 =?us-ascii?Q?GgsCCwCFUhgcOSIYxQl2y04DAcY9lsWNNG6G0CvQui7eN3FOJEH1Iy6D2yrM?=
 =?us-ascii?Q?pN2muS8pDxMj0XOZDKm7mbwZvK08Oq1t9rTqa0rNHHbUooodgLlj86bSLz/e?=
 =?us-ascii?Q?Jro7ekDnmEhBh7mQgW0k9cg0MCHoL9jMl4j1vBC6MBUqj/ofpaNivOC21UL2?=
 =?us-ascii?Q?xqSLjHobJJ6Wzs5T4gQrub/uJvzimbulrD2BnnZ/yQLkkqrUmuEU0TBpSi6K?=
 =?us-ascii?Q?hjWTTGag4BHNVIYlOEHQ7b3187uRLdUPpR+v8T+QuPchJNUFhcKUxmL0DXSL?=
 =?us-ascii?Q?XVjjhRGe0MnTBK0TNCY9ci2xxECsSdbhkTkGSiePAllQeBX5J+Otnt7LzZmn?=
 =?us-ascii?Q?JEIhqh0rXQj4AKRxINEplUDLVtMQQnRNysrc8sEyacKJXngp/XKa/QuhezpI?=
 =?us-ascii?Q?jwZaivoA83pZapX8lvi08qNrKG3xuTojkkwbKwMXOKlEv0nJ0flWZ50hK5cS?=
 =?us-ascii?Q?1873LGym6f1PnVwbLOP3VgDUd/kXmrdYmddeyBdVtdr+VMd0siHqGM+QyuNv?=
 =?us-ascii?Q?z8HH/AJeP+mfLt0gg9wWST2geLTbRsWRLIzKNQ+BkmW4DEFrOzyvpGu9yyAW?=
 =?us-ascii?Q?vHS1nMuMJKEL47cpdZct7a1dTLKB6UT25ePAJBxIfZmlmuFHZdo4rqc8LQmH?=
 =?us-ascii?Q?1sHjhtLNoKJvLjq5ssIufXuSFeSNxZY+DrOk3lX6zRH4txkR0dNPiA65fcER?=
 =?us-ascii?Q?PRzPeSrlQFC2/A7MJ8RWrYaxxLW0BnHf6hYoP+nTLQLPvfFj4O8TsSiRlFRh?=
 =?us-ascii?Q?5ziuhfOXAe06rYMSdhzfIyPX/jX0nayK+5Mivz1Jv/2n8XScbYrxvC8Hr4in?=
 =?us-ascii?Q?5yVUglTeupQrDGV/FgrceJJQy/PIKjmOWasE16SUCoo7G7W741LuZUsZbCgT?=
 =?us-ascii?Q?iYGJBHVbpcP/uBIDl2Zq03vgNgdoellKBHkfCUhnEMyVWmPvNledijEGvcgt?=
 =?us-ascii?Q?SaceyAVb553iiSYfMhdAy0K8yd+/HDzmyOQQdayWOq3qD9lWVGDVK5FhjqNf?=
 =?us-ascii?Q?oSPWEwWRVRZPF6sxe2lo655BZmzoXFj6FhgpM5uskyOhmxLrtN/9nPMUt4Q+?=
 =?us-ascii?Q?NPDGXDIFrwzRtoWPddSAc5iTw64ZZOgxlE+2p35WqQjC49suinOBuVPOkLdY?=
 =?us-ascii?Q?2mzrDVupMJDeM1QI6ivDBHoPXvznFTPzI92xusCUNwadTcGNelQ/2PMcbIQ3?=
 =?us-ascii?Q?n7wDxd2p9YczKuETa9806kzKE/4FF0SigY0gfDJlup2ubG707RgUjS843MVw?=
 =?us-ascii?Q?dgKzYeC7uIKqrvFlmxQuHJDRZiuWfV+PjXrxTtnCE2Ye6kj5/3/8TZxHR87t?=
 =?us-ascii?Q?UJgMQbPFvxb3m9vhevEbTs3nlpzRnr2OJYRXuuioQfkH9pfUEzlL6SLRVIkc?=
 =?us-ascii?Q?mqgdZdPTLt9tUAmWKdzui0HR8C6DDvZRWrXunQ3TCgisEloNqxznTR4tcd3A?=
 =?us-ascii?Q?EqIB4opGVDHVd2FY2xLr0XvM6dL+fCJwvyTdRjrbnjFvqNo5mfjEIrl6be4+?=
 =?us-ascii?Q?Ern5PDVi7S7YbLV6G0ISLQ/YyzM+QuKky4ftwnecL2YTKU0o07dh9q83OT3+?=
 =?us-ascii?Q?Mg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abbf311e-fbdd-45a1-bc2b-08db674f3fa4
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 12:03:47.5617
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UuaeEQpXQBNjP5jbj0dTEfa8Tmvw2Bckm9LFxb6h5LYJAlWVTp2h5WVZ9Cd6nzab/3m59stJo1MbDq4djfU9RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8677
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

On Tue, May 30, 2023 at 01:34:02AM +0300, Vladimir Oltean wrote:
> In other words, the default values (of 0 and 0 ns) result in SCK
> glitches where the SCK transition to the idle state, as well as the SCK
> transition from the idle state, will have no delay in between, and it
> may appear that a SCK cycle has simply gone missing. The resulting
> timing violation might cause data corruption in many peripherals, as
> their chip select is asserted.

I know you don't appreciate content-free pings, but is this patch on
your radar?

Thanks,
Vladimir