Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1379d94-66a5-8538-abdf-de7770befb7d@prevas.dk>
Date:   Wed, 7 Jun 2023 15:15:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH V8 0/7] drm: bridge: samsung-dsim: Support variable
 clocking
Content-Language: en-US, da
To:     Adam Ford <aford173@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     aford@beaconembedded.com, Inki Dae <inki.dae@samsung.com>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Marek Vasut <marex@denx.de>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230526030559.326566-1-aford173@gmail.com>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <20230526030559.326566-1-aford173@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmhENmJwV2JHVGlNamV4c0Q2ejB0UVRNaWFadGlzUVNqdm9QTk9kUEVmb1kz?=
 =?utf-8?B?YnBuaTVrMC9HWGRYZDh2N1FEOFdIK3lyemNRRkxZMUZxTWRIOFhuV2R6cXdQ?=
 =?utf-8?B?aDJiSEZUZTc1VlVuWU40N0NEQSs3ZDZsL2FBSm5rTWJQeGxPbUFnOExsdFVm?=
 =?utf-8?B?N3BpUWh1aDkzc2VCajRhaGhMd0RGbkhaQXF4YlpuNWhra0tqZzhobmtaYlA2?=
 =?utf-8?B?Yjl6bHJISE81SEJ2Uloza2Fsb3FCVlpxWit2YmlDZUZ0WEQ5NGJWb2ZtcTNu?=
 =?utf-8?B?UTBKa1A3aVBEVnFjY2NoZzc0enJJMGNnbmJYVzlXaTg2TXhpdkZFalNocU1x?=
 =?utf-8?B?ek1Pb1A1NXlqREk1cTZIWnl2b3NSNzBqMkthdVNYRzZSVDhjM0g0akpVSm5G?=
 =?utf-8?B?WTh1ejlZVUk2RUFZR3dGSjZ5UnVWV2wvY0tTUzlXcmJjSkt3eVBUUnFWKzNO?=
 =?utf-8?B?ZG5PcFhScEY3Z0szU3F2NVNBOTdoRlZ1MCs4VWJ3OVZscDZlbldhTlNhVGQv?=
 =?utf-8?B?Kzg3WlkwcHF0NStvUlozSFREVkZWNndJL1pjUUhkV21SWEE5dTF0RUJlK1FE?=
 =?utf-8?B?MldsaXdJb3lWWUgyTXBKNUx5enlrZVhnMm5mL3dwSXlMMngvR1N2aG9ydDE4?=
 =?utf-8?B?ZmQ5QjB3SkgvdUZrUTJzK09rL3o3bG5XT3ZGL2p0WnJXSVZWTWF3MFpVMlh2?=
 =?utf-8?B?UUZWcW1idGRTS0ZBNnV1R3paR25TeHBJcEkxckRjN0Q5QVRHaExHdWNVQWVT?=
 =?utf-8?B?ajA1emtobXBPM0ZjSFFnRkU5QWlDSnV6K3MwU3RVeU5uZDZZUjIwYTZvbU8w?=
 =?utf-8?B?Q3hlRU95S0N2VHNCQk5id1ptUjdoNWR6d05pUXpQNDQvc0txOUE4Y1B1ckNZ?=
 =?utf-8?B?MkpZZlR6QUNDOVhNTlBUMWcyVWlnR3YrMlhpUEdrMldqelRaSHIrYWVXY25D?=
 =?utf-8?B?ODM2M3hoU2N3TUZSVlRBTVFBamE0R3hkMWpEN0JGMXE1bWt2TndNSWpNK0do?=
 =?utf-8?B?TlhtaEhtTW82eGFVWVNPaEdOYkNJRmNocWNmK0dCMUF5cU9uSXlXS3YwRS81?=
 =?utf-8?B?MWNEWlNuUUxJbHZkT3lNNWgxelUrbW12dlVteGRjMGtuVFcyYkJIcWVJVzly?=
 =?utf-8?B?R1VzYVRIdHlVRDl2QWo4bWtSMnFXSkJIUm94RFJvdUpZMEZVS2Y1SVFjQ1Zr?=
 =?utf-8?B?bE1aeUNtMEtKQ21tTGR6cDlBT1kvRStjQ1hQallha1I4elVURW5oVllLQzhN?=
 =?utf-8?B?TTdVbDBWelU2di93c3pma0ZqbWpOSHFZVURWSVZFYUFrSlVieDh3NUJBYUd3?=
 =?utf-8?B?b0lYckppb1N3TWRZOVgzTnIxQU5URlhvWUMzREcwd3BpQm5zSmlDbjM1VVRB?=
 =?utf-8?B?R3hzdmtOMlRSL0pQdmh0TXdnU1lPU0R3VVlZUHQxcG5DYzZnODREWXNpcFdh?=
 =?utf-8?B?YUU2MldCVUp3WGV6bkkxVVNqUlptWmtxcUQyUk83L25FR3NNRFRab2NLM05Y?=
 =?utf-8?B?VEZzZTZTYm9uejF2dWVYNll4WVdrOUJTbjN6aE9US2hXd0haSTZrSUpTUlVj?=
 =?utf-8?B?dG9BK0xOYmdqalB6MC8ydXVPYnRtRk9XNUM1MVBpUVNsbkM3WjA4WXRhZE0z?=
 =?utf-8?B?VHdnNjRjUjNYWnBxend0QUhsd2oyYWlvdlVFVWU5ZXd5R2RwaGt2ZHdlQ21s?=
 =?utf-8?B?UjQ4UVVzMTRXUWcrN1NHZWVnZFJBTWdaTTNUbW05WmIrYmYxeWZLMFh5K0Zx?=
 =?utf-8?B?cG0wOUdieWRkTUpxMnRpS1I5SWF3WExlUWtSQWdOSkNqVzcwdEdlOWxPYlJZ?=
 =?utf-8?B?R0o2SnNpQWlGQkFGVzd1QkxQczBjVktaU2wwaTQwdTM5Rld5WVduaXg5QlYw?=
 =?utf-8?B?ZGpRZ2J0N205aW9ITjBubk1wVTJqMEJFZjhKOVVrV2VkOVpLMGt6cy9PK0t6?=
 =?utf-8?B?MTU4ZDU0LzlDK2dXTVlaWkU4UUE0VUI1VTZyZWU3V2VOVDJZZnRKOXd3ekk3?=
 =?utf-8?B?RkJqZ3FtbnF5L2dmenZ0a2ttaEt1MU1XMnBIZGlaSU5xQ0c1RUdpSks2WUx1?=
 =?utf-8?B?ZVp3WEZDdjlybW1jaFM0dEFFTDNYZ2g5UTFra2F6aHp4blNGa3lJbUdrc2Ju?=
 =?utf-8?B?bUNlSjFUMnNIWWhzWE9iUkE0R2daYlBTUm5ORytVOFIyOFN1ZkFXdGZEdERG?=
 =?utf-8?B?dlE9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: c207f283-537c-4980-4e3c-08db67594e9b
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 13:15:47.2761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DgKOzeUOSHMsC4jU/2QU16tqxBFgsBoZXMNlb6Cywb+MOuqqU4yu6vMQx3uBm6otZY703Hmhkz6pzlbigXTuuXBzvVMCDkYlZZCMPlGuJf4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR10MB7779
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE,T_SPF_PERMERROR,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 26/05/2023 05.05, Adam Ford wrote:
> This series fixes the blanking pack size and the PMS calculation.  It then
> adds support to allows the DSIM to dynamically DPHY clocks, and support
> non-burst mode while allowing the removal of the hard-coded clock values
> for the PLL for imx8m mini/nano/plus, and it allows the removal of the
> burst-clock device tree entry when burst-mode isn't supported by connected
> devices like an HDMI brige.  In that event, the HS clock is set to the
> value requested by the bridge chip.
> 
> This has been tested on both an i.MX8M Nano and i.MX8M Plus, and should
> work on i.MX8M Mini as well. Marek Szyprowski has tested it on various
> Exynos boards.

Hi all

We're testing this on top of v6.4-rc4 on our imx8mp board, which has a
ti-sn65dsi86 DSI -> DisplayPort bridge. We do get an image at
1920x1200, but the monitor says it's only at 58Hz, and measuring on the
DSI signals does seem to confirm that the update frequency is about 57.7
or 57.8Hz (it's pretty hard to get a good measurement). It looks like
it's the lines that are too long, by a time that corresponds to about 80
pixels. But all the frontporch/backporch/hsync values look sane and
completely standard for that resolution.

Setting samsung,burst-clock-frequency explicitly to something large
enough or letting it be derived from the 154MHz pixel clock makes no
difference.

Any ideas?

Thanks,
Rasmus