Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230530112050.5635-1-aford173@gmail.com> <20230530112050.5635-3-aford173@gmail.com>
 <CAMuHMdXJaZCSN18aB1yBvhuTk=DQoe4B6aVHgoZvyLsZcRfrDA@mail.gmail.com>
In-Reply-To: <CAMuHMdXJaZCSN18aB1yBvhuTk=DQoe4B6aVHgoZvyLsZcRfrDA@mail.gmail.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Wed, 7 Jun 2023 08:31:30 -0500
Message-ID: <CAHCN7xJbi4ej2s6SOvC7o7aMcjv2awztKkNoAZTiVFn4GJRVXw@mail.gmail.com>
Subject: Re: [RFC 3/3] arm64: dts: renesas: r8a774a1: Add GPU Node
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com,
        marek.vasut+renesas@gmail.com, cstevens@beaconembedded.com,
        aford@beaconembedded.com,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 7, 2023 at 8:21=E2=80=AFAM Geert Uytterhoeven <geert@linux-m68k=
.org> wrote:
>
> Hi Adam,
>
> On Tue, May 30, 2023 at 1:21=E2=80=AFPM Adam Ford <aford173@gmail.com> wr=
ote:
> > With the 3dge and ZG clocks now available, the generic GPU node can
> > be added.  Until proper firmware is made, it is not usable.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > This is based on the assumption that the Rogue 6250 could use
> > generic driver [1] and firmware [2] being implemebted by the Mesa group
> > and others.  In practice, the firmware isn't really compatible since
> > the 6250 in the RZ/G2M appears to be a different variant.
> >
> > [1] - https://gitlab.freedesktop.org/frankbinns/powervr/-/tree/powervr-=
next
> > [2] - https://gitlab.freedesktop.org/frankbinns/linux-firmware/-/tree/p=
owervr/powervr
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > @@ -226,6 +226,27 @@ extalr_clk: extalr {
> >                 clock-frequency =3D <0>;
> >         };
> >
> > +       gpu_opp_table: opp-table {
> > +               compatible =3D "operating-points-v2";
> > +
> > +               opp-200000000 {
> > +                       opp-hz =3D /bits/ 64 <200000000>;
> > +                       opp-microvolt =3D <830000>;
> > +               };
> > +               opp-300000000 {
> > +                       opp-hz =3D /bits/ 64 <300000000>;
> > +                       opp-microvolt =3D <830000>;
> > +               };
> > +               opp-400000000 {
> > +                       opp-hz =3D /bits/ 64 <400000000>;
> > +                       opp-microvolt =3D <830000>;
> > +               };
> > +               opp-600000000 {
> > +                       opp-hz =3D /bits/ 64 <600000000>;
> > +                       opp-microvolt =3D <830000>;
> > +               };
> > +       };
> > +
> >         /* External PCIe clock - can be overridden by the board */
> >         pcie_bus_clk: pcie_bus {
> >                 compatible =3D "fixed-clock";
> > @@ -2347,6 +2368,18 @@ gic: interrupt-controller@f1010000 {
> >                         resets =3D <&cpg 408>;
> >                 };
> >
> > +               gpu@fd000000 {
> > +                       compatible =3D "img,powervr-series6xt";
> > +                       reg =3D <0 0xfd000000 0 0x40000>;
> > +                       interrupts =3D <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH=
>;
> > +                       clocks =3D <&cpg CPG_MOD 112>, <&cpg CPG_MOD 11=
2>,<&cpg CPG_MOD 112>;
> > +                       clock-names =3D "core", "mem", "sys";
> > +                       interrupt-names =3D "gpu";
> > +                       operating-points-v2 =3D <&gpu_opp_table>;
> > +                       power-domains =3D <&sysc R8A774A1_PD_3DG_B>;
> > +                       resets =3D <&cpg 112>;
> > +               };
> > +
> >                 pciec0: pcie@fe000000 {
> >                         compatible =3D "renesas,pcie-r8a774a1",
> >                                      "renesas,pcie-rcar-gen3";
>
> LGTM.  But obviously I cannot take this as-is, as there are no DT binding=
s
> for this device, and it didn't work for you...

It was mostly to follow up to the previous ones with links for the
mainline Rogue video driver in the hopes that someone from Renesas
might have some input on whether or not Renesas might be able to
support this and have a discussion.  I knew when I submitted it that
it wouldn't be accepted which is why I posted it as an RFC.
If I address concerns you have in the previous patches, would you be
OK with me submitting then as a formal patch to at least get the rest
of the system ready in the event the GPU driver/firmware becomes
available?  It seems harmless, but I also see the argument that it's
dead code without the GPU node.

If not, I'll shelve this for now, and hope to get some responses from Renes=
as.

adam
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6=
8k.org
>
> In personal conversations with technical people, I call myself a hacker. =
But
> when I'm talking to journalists I just say "programmer" or something like=
 that.
>                                 -- Linus Torvalds