Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp798329rwd; Wed, 7 Jun 2023 07:05:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7eidesvc44qI1HG2euXie1LnmRjIUm3MHoM9TM2/HPZpZ2Q4QziS6zgMrWsporHraU856P X-Received: by 2002:a05:6a21:3889:b0:114:7637:344f with SMTP id yj9-20020a056a21388900b001147637344fmr2919488pzb.49.1686146755997; Wed, 07 Jun 2023 07:05:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686146755; cv=none; d=google.com; s=arc-20160816; b=YTvCxFgCSbP6OR5To5auq5CfPDo19WIdiDSs7qM1XqyHMTo09xZebOcc2GDPTNoYxj J2GXvgtiVcatov6wgg1Dcf3xmiLXFWUUSsR0M9Q25boBFNE/LrHq8+2bBL/fmXiyWt8G eO3N0sZ4Bd/wgf+8hALEVFXM8VXp3XpY9RJoWHPCwp1TcXWolbGmeedVpex3wgpA8BBM gNNaORmLBt9PtTD3y3fySu3eFJRP5TK2TgbJxO8RnS8klUisksKE/KzLSjHWs3G2DUjS kmREnb1U6gIOGXRinr6FuaRB3VlCgCNhRuF/nZ90kCCXnchBjacN79lrWzb+TPtjI0HT wx7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=8pWjfG7YX2PU6lTg87BQzQgK5gQrtCZuLosIt3qtFrw=; b=tzUjT6Dx4jMFKJvxZJHF72Tu5yo6oGnT0NzmgW7cuTHWRHS+TigmSSrEWcRIV9ns55 AaRs0d4Tif+cDSrQ9yLtHxf+AuLNCb2xOYq70BsCFFXzhkk5QAY/iNEQ/1dxFhqoXF3V a7SyKGyn7mecHeivQxKqDWH6SIK5CvF9BOFSuLk5BFVDRk3DaNpPUs7H2o/XQF3okhUr 8M2wTm5NFtGizxXR9I8gCUQutK7Xnt210fwP8bg/Of9W/tCvXb1Hmoz1kApL8WJQXPgG w9X3+G8g1B6eu4188OWDEySsXhn/aPMHqetB5ZznPZUbeZ+RO+igMzPbI/0/GsNrflj/ scxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=QMGMlVX9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v2-20020aa799c2000000b00661ff0293a6si1027794pfi.41.2023.06.07.07.05.40; Wed, 07 Jun 2023 07:05:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=QMGMlVX9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235157AbjFGNwm (ORCPT + 99 others); Wed, 7 Jun 2023 09:52:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235623AbjFGNwh (ORCPT ); Wed, 7 Jun 2023 09:52:37 -0400 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C90D1BD9 for ; Wed, 7 Jun 2023 06:52:36 -0700 (PDT) Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-3f6a695a0b8so9271281cf.1 for ; Wed, 07 Jun 2023 06:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1686145955; x=1688737955; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8pWjfG7YX2PU6lTg87BQzQgK5gQrtCZuLosIt3qtFrw=; b=QMGMlVX9pT4+APXXvlD2HGaGEg55QMH0btBqGqRw+dtdVOGo1kh5q+IRJfikBCjoAZ vafj+YrmGCGYaOtKcFzs/g7GriOKBIzWtZZeh8BfNxsIDJ7VseMMJPYoiNuQt7caTcMI fbzdenPFcryIzgWI+zcXPps0vDUIFsZMliLzzzo2NMTbOU8IV+6GRTdzS4etu2E7bG1G zZy5GDzKAFGL863kgCYdqdlrRhzG8ovq7gNP99KiwoUnVzy58N3hDEkaisdrZi9QqDvh 12nHG5VND02dBavngpMxFq36XYe5fvooIddYSP6a8+XPAVtLp/lIB0YMBjMBb3y/nBpV Px9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686145955; x=1688737955; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8pWjfG7YX2PU6lTg87BQzQgK5gQrtCZuLosIt3qtFrw=; b=COcU4rYjLRszlWWr4AyCq/j7Pyclg2ei+xWTW7aBmFAPnN/KjUTzM+Y6LsaUNIQrsl InO60JnratHeAmis25S8DebqdlytAW3ck5eB9h9C1wL88GnFJH2RIIllMqahkqbq5fw4 QWWsEvXaFMAq3ju7k7A7CawFXRHers+BdpeBKXMcOMoynEC/fUE1lyNcN9Glgwop3g+K JO96ncBPcen4k21yUq6S+vUMgcRg+J2tDsXkF2xjOAy7itxacf7PifaDLof33JgT+VS5 H6IF5b9DMQ5k8prIT2iMdBQFf60qCXYvqzLwHuDNyd0MP4W9TapOGfQRYposrRoa0tBF zWvQ== X-Gm-Message-State: AC+VfDxSK9/B+kWkiPIkFCIIja8YWWCHlKddopcCaKIBqspAs/p4U0ta xCAnz1tfh08Gew2ZqWn7ajK1hA== X-Received: by 2002:a05:622a:1899:b0:3f9:ab2c:8895 with SMTP id v25-20020a05622a189900b003f9ab2c8895mr2173118qtc.3.1686145955449; Wed, 07 Jun 2023 06:52:35 -0700 (PDT) Received: from [127.0.0.1] ([50.234.116.5]) by smtp.gmail.com with ESMTPSA id s5-20020a05621412c500b0062119a7a7a3sm6141611qvv.4.2023.06.07.06.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 06:52:34 -0700 (PDT) From: Jens Axboe To: Tejun Heo , Josef Bacik , Waiman Long Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ming Lei In-Reply-To: <20230606180724.2455066-1-longman@redhat.com> References: <20230606180724.2455066-1-longman@redhat.com> Subject: Re: [PATCH] blk-cgroup: Reinit blkg_iostat_set after clearing in blkcg_reset_stats() Message-Id: <168614595386.134969.17908041000836291196.b4-ty@kernel.dk> Date: Wed, 07 Jun 2023 07:52:33 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-c6835 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Jun 2023 14:07:24 -0400, Waiman Long wrote: > When blkg_alloc() is called to allocate a blkcg_gq structure > with the associated blkg_iostat_set's, there are 2 fields within > blkg_iostat_set that requires proper initialization - blkg & sync. > The former field was introduced by commit 3b8cc6298724 ("blk-cgroup: > Optimize blkcg_rstat_flush()") while the later one was introduced by > commit f73316482977 ("blk-cgroup: reimplement basic IO stats using > cgroup rstat"). > > [...] Applied, thanks! [1/1] blk-cgroup: Reinit blkg_iostat_set after clearing in blkcg_reset_stats() commit: 3d2af77e31ade05ff7ccc3658c3635ec1bea0979 Best regards, -- Jens Axboe