Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c84f5983-930d-0bbe-b7fe-01875c045815@amd.com>
Date:   Wed, 7 Jun 2023 10:07:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Cc:     yazen.ghannam@amd.com, linux-kernel@vger.kernel.org, bp@alien8.de,
        mingo@redhat.com, mchehab@kernel.org, tony.luck@intel.com,
        nchatrad@amd.com, Muralidhara M K <muralidhara.mk@amd.com>
Subject: Re: [PATCH] EDAC/mce_amd: Remove SMCA Extended Error code
 descriptions
Content-Language: en-US
To:     Muralidhara M K <muralimk@amd.com>, linux-edac@vger.kernel.org,
        x86@kernel.org
References: <20230523085550.391768-1-muralimk@amd.com>
 <20230523085550.391768-2-muralimk@amd.com>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20230523085550.391768-2-muralimk@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3ZFYVBlTTB3VTdvNlkvM2s4d1RDVTc5UzNnMmZ6MlNWYkxZNnZTbjlBQzYr?=
 =?utf-8?B?dnBYb3ptZDVMY2w4bGRxdHB2bGxTNGI2S1d3QlZIRWZuRzhMMmNCTnF1cmZh?=
 =?utf-8?B?d2hrN3FpOTNZMHdRVllrMCtreHJ3UDh1ZkVuQmtRd29mcGovaDZHaFBEb1hV?=
 =?utf-8?B?MGM1YTBQVGwvVG1LUnluaXkwOWNxTFE2UmVPTjJxUjZDeWdwb25JblJZbmVC?=
 =?utf-8?B?L01SN2xvdE5MdlBIUkN5RjdtK0lGOG95R3N3YmN0cS9aM2dlNmw5V2VCR3Fa?=
 =?utf-8?B?c0l5cFZ3N1FEWGdKdjFWWnAvV2diRThPU2FpZHVqMlJmcXVFbUdjZFZXMWJY?=
 =?utf-8?B?VmxvbC9YcTZSQWxlaTJOcDRIVFY3dHZYTmxkQ0JyL2QzYnBTaDd3YytrRkJC?=
 =?utf-8?B?TDFvYmlnS0pxMjRNZkhLZ3VWaEF0d2RFWGFrNDRhU3ZaR2JmcTloRW5MSUVl?=
 =?utf-8?B?bFFoYzVXem1uVURoNHl4SDRnd0F2enVqdW83V2ZuTTdjb0NJcmxRMkEzRVk3?=
 =?utf-8?B?c3RKbkN4aSsxQ252T0JjLzhGRE8vbk00NlFBcjhXeVd5VkZyV0NjOWEzRG1Q?=
 =?utf-8?B?K2VEaEQrcS9qNGpCWFJPRGJBc0hUMHlQanlTREZJa2dJOFV4STdNZjRMRlhQ?=
 =?utf-8?B?ZzNsMitaalFsZlhHelBSVk5nbVJnMnFmdTY4RlpPV3NoaXE0MWJGUnVlejNu?=
 =?utf-8?B?SVNxZlBubFA1S2FuRFBXd2J2MFRwKzRrRldBRnZsOTNjS3dHR0czNWJUVmRa?=
 =?utf-8?B?UVJ0MzlqMFl4NEgvTHpnVUhvaTB5QTFsWWZxdVhvQjZGeFRYS3pjck15djMv?=
 =?utf-8?B?bFhRRGxOZ05lZXBmak5WS0xTeW9aNm9oVE1nMFp2U1ZCcytGa2p0YkRUWTJi?=
 =?utf-8?B?WUFaS0xHeU1icVFJc3NiWm9ZNC9TVldlNHhTWWlXeHErT0xKeFJJSVRjTkpy?=
 =?utf-8?B?MXk5M0hnOGxVOFBoRXpuWFFWdiswRkFCV0gwWFhSa2V2WkI1blpaN00zVWZj?=
 =?utf-8?B?cVNuQmlIM1NZWU8zaW04YmRrdERNeURrdlk0ejVlTFFlcXFMQ1lOVHlZS3VI?=
 =?utf-8?B?K3pYZ1pzYWdvZ2VaTDEwMTZ2VVBBM25sWUdScTZmZDN1Vkx3OFZqaVdqc25X?=
 =?utf-8?B?QU1LUG5lWkpobmIyMXNLRE5NQ2NyVk1wanc4K2NmSXV0ZjRxdnd0KzRFcGVN?=
 =?utf-8?B?ZHR0UkpEWEJxaUtUMUVneS9MdWlBMmdPL0FEakNoYUN0VDd3NWRueTBGaFRO?=
 =?utf-8?B?Slc2dC8rMlV3SGRLYTIzdlljNlBMWHdEM0hJa0R1V2Fjd2VkWHhZdXNpQkE5?=
 =?utf-8?B?dzFrMW9sdlYwRkZndkFRRlZDZzUzcjZ3YzJpNzFEZnpGVVNaOHVvQTRsOXpw?=
 =?utf-8?B?RDg0ZVlzbDBiOHBINEQ4OTEzaTFmRmhqaVRINVhpQ2NaTHpNMmNFcGdUMUVT?=
 =?utf-8?B?eEFsSk5kOCsyYVhmOC94MFV3VWsydkF3M3BwMWc2djgzZmlpeGVyT29jWlI5?=
 =?utf-8?B?REEvRW1QSGdQR3BBYUpkVitpNGRKVWZwSFRnWUlXSVRaQmg0VHhuWFBFMXNI?=
 =?utf-8?B?M3dEaEtkeE5mMWpKOHBRTzkvVXJLZDRjQmZQSjhBQllXbms2aW5KYXJobGFI?=
 =?utf-8?B?YjdxcStjSHpINnlyaDRVZFliRCtEYzZSTHkzSitzRVFTLzRMK2EyV0hmN1J2?=
 =?utf-8?B?NHJIaThTMDUwTlFjeU9pRHNOWWIzaXVleC80dEpJNXhqbWtkeVllL0FCWm5v?=
 =?utf-8?B?QWdLajJ4Q1duNzh4UzRtKzRXU0hQVWRmMEQrRGYwNTl2R3VVOGdMRkorY0wx?=
 =?utf-8?B?Y2ErNC9lMWV4Zlh2Vk1saWpGdnNaUmhDVVZhSzBCeFplQkI3bFgzQThVWk5Z?=
 =?utf-8?B?eVJTcExDOGFhVzJ4aTNxcmFrT3pZTnBCQm9hTjkyb05VcFczTlF1RHZRUGtN?=
 =?utf-8?B?RnNDNndGdzQxbENoNnU1a3Z6R1prMStaZERFMVo4N1FINDlCZjVXZWFaVloy?=
 =?utf-8?B?dVFUL1VLd3lNTjh6a2w2NzFTV0d4SC9FaDNYTEVKbzFVMnI5K0daaE5GZ1ox?=
 =?utf-8?B?QWFoazNmOTdKOXFPTHpFdUdOZDZvMzZVSHZtOE5kdmZpaWFEU2tWWEg4REFx?=
 =?utf-8?Q?pyqCH0YFWENoYOvHa6bZwZCHk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a59edfe3-4d1c-4014-bc9f-08db6760950f
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 14:07:51.9750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MGhFGhSV509R3YmLG+aCgdWT+0cM0XybYuH8xePS3ADy6d51PgRV/XcCC2KrZ/RAvulupUvvt7bDcxX1aMMy0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4238
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/23/23 4:55 AM, Muralidhara M K wrote:
> From: Muralidhara M K <muralidhara.mk@amd.com>
> 
> On AMD systems with Scalable MCA, each machine check error of a SMCA bank
> type has an associated bit position in the bank's control (CTL) register.
> 
> An error's bit position in the CTL register is used during error decoding
> for offsetting into the corresponding bank's error description structure.
> As new errors are being added in newer AMD systems for existing SMCA bank
> types, the underlying SMCA architecture guarantees that the bit positions
> of existing errors are not altered.
> 
> However, on some AMD systems some of the existing bit definitions in the
> CTL register of SMCA bank type are reassigned without defining new HWID
> and McaType. Consequently, the errors whose bit definitions have been
> reassigned in the CTL register are being erroneously decoded.
> 
> Remove SMCA Extended Error Code descriptions. This avoids decoding issues
> for incorrectly reassigned bits, and avoids the related maintenance burden
> in the kernel. This decoding can be done in external tools or by referring
> to AMD documentation. The bank type and Extended Error Code value for an
> error will continue to be printed as a convenience
>

Minor nit: there should be a (.) at the end of the last sentence.

> Signed-off-by: Muralidhara M K <muralidhara.mk@amd.com>
> ---
>  drivers/edac/mce_amd.c | 480 -----------------------------------------
>  1 file changed, 480 deletions(-)
> 

This patch is completely within EDAC, so it's not necessary to copy the
x86 or TIP maintainers.

Also, this patch was sent in-reply-to another patch that is not related.
Each of these can be sent independently.

Otherwise, this looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen