Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp900200rwd; Wed, 7 Jun 2023 08:18:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5rCp+7FJYdbojxtyP0SyU8hENd45nvwuC0QKO9v2FUkrlTffcHpeUm1INTsOhY8VQWV8Mx X-Received: by 2002:a05:6a21:398b:b0:10b:5abf:6f0d with SMTP id ad11-20020a056a21398b00b0010b5abf6f0dmr3330301pzc.40.1686151092006; Wed, 07 Jun 2023 08:18:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686151091; cv=none; d=google.com; s=arc-20160816; b=SrjaBGuaOpql+sL+U7gWlGcsNzclZ4aoc6srrJhKQzEY31Jfp6n0n0q3XGIXiJ/Cy9 V02MJHgtVzBeTvkSjqJc2XqoDhj/GW4k5BYW7R8V/kyhcQRgfh4A5lOQbV54DsXKoY+L 8W2oWAlJAeutrI/iMdTLHjOXy+g2kfNetDPZnBDeQJ7UcXa6I2jNBGzrC4k50catitm4 Jhgpjf5jDzbF1Lr8HtDLDT0wMcugkSAjsHElooXsZI4bUSizmpE0QKJoH44iIqg66nYo HgXZLjlxyW7e9DxL7DV/a4H+yuJmEi5mzIZEno6evr4Hu47MretKRGN875D5ORBvU7Gq iGuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=W5p2WzoMAd699TqoHJTiu99DkZxymavMq0558AjUk5I=; b=mjpyox5YNY0UUtuQkSYBRaTZyFlOe/Uuf3JauD26IDeb5qYcEaoSw+rmVVgyP+64Vv Mz9ahvTJuAoZfeukP67TNQBsDBHUyf/+oZKQt2fO3Nut1J7aNDpf6i1DAu8pkwFxGqFU N/0yQRMUl+ik878N1HReg3FRrjgk/tKbf21yntjyaymmEJ96CNjKki0CG/s/YQfEtATu ZdgCKSK5fmsM5mc98RQhF+AStVR/tSnoypGh0LN3kYK1B5MjY44/vP0QWTqEwXDNq4sJ gmbvTpxj4Pdf+Nux5Uq9DSpSIQGkZW+Ce4dO5HnQWCVtrJ/ZAYW3CAjBw77pxm48IU8p UCAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=a3UCvWa9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k187-20020a636fc4000000b004fb95253a18si8680384pgc.376.2023.06.07.08.17.58; Wed, 07 Jun 2023 08:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=a3UCvWa9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241062AbjFGPIq (ORCPT + 99 others); Wed, 7 Jun 2023 11:08:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240435AbjFGPIo (ORCPT ); Wed, 7 Jun 2023 11:08:44 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B1CD1720; Wed, 7 Jun 2023 08:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686150524; x=1717686524; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6TdsUePGYVEjerNbgyfVc3Eki0F3cK61GqMEgDDK4l4=; b=a3UCvWa9kw0T5727lu0LsLQ+vrkHB5uQuWbP4o/92sZBYNLwgGCAlepd hnEp0hFTj1MNdl6LEYf4zqQg83UjgIr4AlQEC2EC/0HS1MXyYNaNmgV+p UlSNV6qTTtc5RjzjhGgwdmm7SOEZWLpoBsTBhc5vC2/76t8TbFbeZ9SMw njSBwqeVEycPyA7DAJ6g0Flr9ZwK0Le4li2kDKEnhv5F0nfSM1C+fNY7h vrwfi/j0DO4ksQU4nPRISkeFVqx4xOF24g9JaeIGNV3jyVVv8FnSt95bD sNL41x/69yFM9IOww/GU2l5rxw6ucY8W2CXnUjcMOH5QwQLqe88X+06uh g==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="443381443" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="443381443" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:06:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="883838935" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="883838935" Received: from akuporos-mobl.ger.corp.intel.com (HELO box.shutemov.name) ([10.251.211.72]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:06:37 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id C2CEA10F0E0; Wed, 7 Jun 2023 18:06:34 +0300 (+03) Date: Wed, 7 Jun 2023 18:06:34 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Chatre, Reinette" , "Christopherson,, Sean" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "Luck, Tony" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" Subject: Re: [PATCH v11 04/20] x86/cpu: Detect TDX partial write machine check erratum Message-ID: <20230607150634.te5u2q5tlwuyni37@box.shutemov.name> References: <86f2a8814240f4bbe850f6a09fc9d0b934979d1b.1685887183.git.kai.huang@intel.com> <20230606123821.exit7gyxs42dxotz@box.shutemov.name> <4e9acea6b956e1fb83b4e49fc8d154295e321f29.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e9acea6b956e1fb83b4e49fc8d154295e321f29.camel@intel.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2023 at 10:58:04PM +0000, Huang, Kai wrote: > So it seems there's no hard rule that all bugs need to be done in > cpu_set_bug_bits(). Yes, CPU identify is a mess, but initcall makes it worse. Initcall is lazy way out that contributes to the mess. Maybe cpu_set_bug_bits() is the wrong place, find the right one. -- Kiryl Shutsemau / Kirill A. Shutemov