Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp909591rwd; Wed, 7 Jun 2023 08:25:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ez+KAh8OoqT8R+0XXvN+5K3jQGD4FrXoUGU7SM4eEqYc6y/Cvjxz9pra/Qu34xtFbBkrU X-Received: by 2002:a25:b946:0:b0:bb8:2eb4:4f08 with SMTP id s6-20020a25b946000000b00bb82eb44f08mr774857ybm.12.1686151534831; Wed, 07 Jun 2023 08:25:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686151534; cv=none; d=google.com; s=arc-20160816; b=GKlMmLUj0OhR6CqK6ftJzeghisBoTduBDTN5jJYekOeIdUjP+xeXxZWpxWRA4ZlkMt mVGBTxHanhl9JjDM1zpp0Ff7r9cEAl5iOywGy58AyEo0f1DCax9bQLPMod94JGd4YasN NhGYOMYS6aq+QspRIiUp1ATzLIYDgfzxg7A+FPWXaQr1WHMif7qYmt1DjDDw9df7Ce2f V/n8+BHhWAPwr3kg568r1OTPhcTBAxlgXrFAzVNQfBv75kB43coT4rWCOfv/TLMilSdu 5nuTRNMiSbnwgFDWTvAaf7sbGlOvF3r/ZAmwEY80sFeMYyjIGUFJHX3f8yf3NIiLdClS +Vog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aYJqhoKXaC4L3HtC31xSAXOYfzHEq2aTFT52lzn1B2s=; b=0R8TgsDx2wQQqzzmedzBdeJNKpWaQWXkw7Qyb8zls8jyZVgZrazOFzYnrgXMO5CQIe IXCT2cv3BG6hDz/gmOlyse48uM93jbZCHHj/8YyojEyQ8RANevNlb2Rv/pxwzrCa1HnI ipOfHvdoMIdRPkVgCtlp1pUDfHayfuflUe3PGSkEl5JUtLgJK5FrhexagBsyWULLBsqk nPmGb83DESrLHZD01Ns8nFv0TALTz27jxD/qiS7SrjrVXEmuiN7DjTSUxWiTar7x4HxD 3vYB+B1F98qlyWJLlDSyT1uHsWJx//uk1GBSum1QQOF2H/7vUn8utOSIM0bHmuYHLwzQ hiDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mgE9+GvQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d11-20020a17090ad98b00b0025042fae398si1239145pjv.45.2023.06.07.08.25.20; Wed, 07 Jun 2023 08:25:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mgE9+GvQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241266AbjFGPKS (ORCPT + 99 others); Wed, 7 Jun 2023 11:10:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241263AbjFGPKQ (ORCPT ); Wed, 7 Jun 2023 11:10:16 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75DFC19A4 for ; Wed, 7 Jun 2023 08:10:15 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-3f732d37d7cso46844755e9.2 for ; Wed, 07 Jun 2023 08:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686150614; x=1688742614; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aYJqhoKXaC4L3HtC31xSAXOYfzHEq2aTFT52lzn1B2s=; b=mgE9+GvQBRH3zIari05XcJlVmTNJTT/WUbO+P+8yk5mZJ1NBrSPBEOXQ1fV+0Vc+z4 FPUIat5OAKcwPP0HGXiIwqKTAsBRB+eHcHmXNiRZnDSZUdFFFLhsBtxQ/DYh9wMA/4Tw fZIgoerToGJ5ro/BxTbuLPQ7XeYlX/hi/8OOuM2qmiLdNW9ifCeT39swFYeIHviabE1A HoMlzIFfiFvFXOIhKCLGLC6XtdfujU5nPTHEyhTmLKMdlQFRNG0IzGNhulsP5Wp07v5e VzuHaHS9mR4JYwb65WVjM+qqO6JWMUqLwr/2wUMXpVMlw7OyF6QnoUfV5yFVWVOMn2mx NZ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686150614; x=1688742614; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aYJqhoKXaC4L3HtC31xSAXOYfzHEq2aTFT52lzn1B2s=; b=LCeSuf43HX+EUmYP/1zMzm2fRVLOSbZOdn9xwBpPwBlkiAjD44zBaVct/BiTLIctYP WsQImY1zsudx+alqesZxPuFYoWh45D+wJKfjzIFdMzRjHGJu/nih5xVTgBZwXBC+Vj6s VsZLqh5bxWUUWvIAadVIycfrGYlBJzMWDzT1UuSWouG+yF4FUXEEKrypdy6Xd5hoCJgT Wp/+c1f8FApF8t3irO5hRk1QbIAkaYoP9dBNeN3kq+Q5m/O164uq4BflEPnVkU9NE7km 87uq0TksHMeBQZ7al2YfLciZMBC/3SYJfNVOsuvRZQJ57H9RsuHg6MyOo0LGLmMQViHW ul6A== X-Gm-Message-State: AC+VfDw9ZhiX9N3wTyswARg7n9cB+D72mxDabUQGgHZO/eJFvXTezEwH VhhaZgdnAu/av/fDUZaxsZ5nhg== X-Received: by 2002:adf:dd06:0:b0:306:3ded:2bf1 with SMTP id a6-20020adfdd06000000b003063ded2bf1mr7476716wrm.60.1686150613947; Wed, 07 Jun 2023 08:10:13 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id h9-20020a056000000900b002f9e04459desm16017306wrx.109.2023.06.07.08.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 08:10:12 -0700 (PDT) Date: Wed, 7 Jun 2023 18:10:09 +0300 From: Dan Carpenter To: Yogesh Hegde Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] Trivial code cleanup patches Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 07, 2023 at 08:31:19PM +0530, Yogesh Hegde wrote: > These patches remove variables in the struct rtllib_device that were > set only once throughout the driver. Instead of using these variables, > the patches modify the relevant code to directly call the corresponding > functions, eliminating unnecessary indirection and removing CamelCase. > The patches are required to be applied in sequence. > > Yogesh Hegde (5): > staging: rtl8192e: Remove variable SetWirelessMode > staging: rtl8192e: Remove variable SetBWModeHandler > staging: rtl8192e: Remove variable LeisurePSLeave > staging: rtl8192e: Remove variable InitialGainHandler > staging: rtl8192e: Remove DRV_NAME definition in rtllib_debug.h > These all look good. Reviewed-by: Dan Carpenter regards, dan carpenter