Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 18:07:22 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Yogesh Hegde <yogi.kernel@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] staging: rtl8192e: Remove variable SetWirelessMode
Message-ID: <01a162c5-f0de-47b1-97e7-8a451a89df80@kadam.mountain>
References: <cover.1686149467.git.yogi.kernel@gmail.com>
 <fba56522e419351b05e33df8cd0ac31806534d8c.1686149467.git.yogi.kernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fba56522e419351b05e33df8cd0ac31806534d8c.1686149467.git.yogi.kernel@gmail.com>
Precedence: bulk

On Wed, Jun 07, 2023 at 08:31:41PM +0530, Yogesh Hegde wrote:
> The variable SetWirelessMode is set in only one place throughout the
> driver. This patch removes the variable and calls the real function
> directly instead, eliminating the unnecessary indirection.
> Additionally, the removal of the variable aligns with the checkpatch
> guidelines by removing the use of CamelCase.
> 
> Signed-off-by: Yogesh Hegde <yogi.kernel@gmail.com>
> ---
> 
> v2: Removed the variable and called the function direction instead of
>     just renaming the variable as suggested by Greg Kroah-Hartman
>     <gregkh@linuxfoundation.org>.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter