Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Benjamin LaHaise <bcrl@kvack.org>,
        linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
        linux-kernel@vger.kernel.org,
        "Venkataramanan, Anirudh" <anirudh.venkataramanan@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Jeff Moyer <jmoyer@redhat.com>,
        Kent Overstreet <kent.overstreet@linux.dev>
Subject: Re: [PATCH v3] fs/aio: Replace kmap{,_atomic}() with kmap_local_page()
Date:   Wed, 07 Jun 2023 16:59:13 +0200
Message-ID: <2287966.ElGaqSPkdT@suse>
In-Reply-To: <ZCGYps2z5IlaEaxU@casper.infradead.org>
References: <20230119162055.20944-1-fmdefrancesco@gmail.com> <2114426.VsPgYW4pTa@suse>
 <ZCGYps2z5IlaEaxU@casper.infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

On luned=EC 27 marzo 2023 15:22:46 CEST Matthew Wilcox wrote:
> On Mon, Mar 27, 2023 at 12:08:20PM +0200, Fabio M. De Francesco wrote:
> > On gioved=EC 19 gennaio 2023 17:20:55 CEST Fabio M. De Francesco wrote:
> > > The use of kmap() and kmap_atomic() are being deprecated in favor of
> > > kmap_local_page().
> > >
> > > [...]
> > >
> > > Therefore, replace kmap() and kmap_atomic() with kmap_local_page() in
> > > fs/aio.c.
>
> Or should we just stop allocating aio rings from HIGHMEM and remove
> the calls to kmap()?  How much memory are we talking about here?

Matthew,

Well, I'll do as you suggested. Actually, I should have made this change wh=
en=20
you suggested it but... well, I think you can easily guess why I did not.

Here it seems that a call of find_or_create_pages() with the GFP_USER flag
instead of GFP_HIGHUSER is all that is required. And then I'll get rid of t=
he
mappings in favor of some straight page_address().

I just gave a look after months, so I could very well have missed something=
=20
else. If what I just saw it's all that must be changed, I'll send the new=20
patch by tomorrow.

Thanks,

=46abio

P.S.: I had sent other patches that must also be changed according to a=20
similar comment you made. Obviously, I'll work also on them (no matter if y=
ou=20
can't probably recall the short series to fs/ufs I'm referring to).