Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp963139rwd; Wed, 7 Jun 2023 09:06:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4B9vj9zbv9Wf5P3woQq5Ff071DBnL9tOdOamAZboYLekXOEXDZjfEsW28IhY0sJcPn+R+q X-Received: by 2002:a05:6a00:c95:b0:655:89f1:2db3 with SMTP id a21-20020a056a000c9500b0065589f12db3mr7581299pfv.3.1686153999528; Wed, 07 Jun 2023 09:06:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686153999; cv=none; d=google.com; s=arc-20160816; b=z4f3mbtwN1vTowA1s2hLAvY683//gAGLrsLFH9ojE2uvrl7eCzap7zwkIRGEnDH33Z M0a3x1u1RGSBk59RFM9BuIz3NcvOgIx6qo/gXeWu4ZYaOKfaCbZ3h1ll6l/i4BOW7KWG kFJHH3rBZ5eUOYDkyi+q4Z8lwiqx+IQtNtSHnjAgFOyAwX8oB3VwlXp1UnFACQYuSwwd qqLmfbCRbIwbN3QVmZxAzyoGW1BfqpbP0W6Sl1etUmbVDnUGGUz7aXzIpUk/d4AA8PSw VdQN074iUdzzz67KotFjZ6ZPitLGUNuyAP7dOJ7jht0WozcpclBHXjgZIt6RWc7uuQT3 IllQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Q6VfE+ktrVxn8khTkfFYSemyvVvnvdhtq7XhJA55Y4I=; b=atzD0Fr/AvoRdyEgCgb4wTegQUytYwjsch6oAGgBjqojMCMwHDGPH+ushAI84v4s1A bE8fpgNntboZ6zkoJKWRe40JAR9OFONHO+PfD12UnVUPSYA7L1hQLImlIhMJyQhF3/7C g8w2GVSAhQnS44IcbRCp+8dW0Sr7cKxVvCY+I6MW9IsPhZU2sTfKQZ+lj47W5XJpZlP2 cbp9J9J7/5U6a7iWIWbsru6gKds+yYxrPaoZGI1hrNWYXYvjSqbCAfAtuikfLynhGH1X ec5lCZGGrQN1Jb0XkkDF44hshB7K4j2aCM2ko6QieMZ+dnt1EOmZXyesFtSmoCU2VP2/ cqHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YtYrGGW5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a185-20020a6390c2000000b0053467c7b635si3162461pge.85.2023.06.07.09.06.24; Wed, 07 Jun 2023 09:06:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YtYrGGW5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241494AbjFGPsK (ORCPT + 99 others); Wed, 7 Jun 2023 11:48:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241453AbjFGPsH (ORCPT ); Wed, 7 Jun 2023 11:48:07 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A9B71BC6; Wed, 7 Jun 2023 08:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686152886; x=1717688886; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=+3vgVO8tJwqTs7HyPalyqiGJn+qGhs2vMFA3uccMokI=; b=YtYrGGW5OpAitLs4GA00RKlwzcyvEc100v8CqZv+x4+zZK44J1FHMtEK PKsqheSegfuRRnWulua2lrM578JF4gBnNBCQpdY2iD0iybOjJjmGXVwbK KVSvG7BGcyDGc2WanZBtkWLe/OaEE0RoIcpQG9TRT/BSYkrLjCtNYxwOC ++T+Ezunv1BJUrNeTANp5AG3t8dDtJW2E1ukg5YDfjDpyzmiQ/wOcsqZv WncuuGZBiaftjQT7fuObU11mP9RuEMf7QMXU2l6RBN98LpHwTOpQ+XLm6 QiMmfkByntBujnfURNQq4G54sVZLUAjA5N2as/Yx3vzVlwom198dq7AqT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="359497523" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="359497523" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:48:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="712712690" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="712712690" Received: from vsmyers-mobl2.amr.corp.intel.com (HELO [10.212.146.233]) ([10.212.146.233]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:48:04 -0700 Message-ID: <97b239b4-7d0d-e5e9-43f5-b9c26d6cd846@intel.com> Date: Wed, 7 Jun 2023 08:48:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v11 09/20] x86/virt/tdx: Use all system memory when initializing TDX module as TDX memory Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <468533166590ff5ed11730350c4af8cdb0b99165.1685887183.git.kai.huang@intel.com> From: Dave Hansen In-Reply-To: <468533166590ff5ed11730350c4af8cdb0b99165.1685887183.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/23 07:27, Kai Huang wrote: > As a step of initializing the TDX module, the kernel needs to tell the > TDX module which memory regions can be used by the TDX module as TDX > guest memory. ... > Signed-off-by: Kai Huang > Reviewed-by: "Huang, Ying" > Reviewed-by: Isaku Yamahata This is rather short on reviews from folks who do a lot of memory hotplug work. Partly because I don't see any of them cc'd. Can you wrangle some mm reviews on this, please? For the x86 side (and because this patch probably took two years to coalesce ): Reviewed-by: Dave Hansen