Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 17:52:19 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Maxime Chevallier <maxime.chevallier@bootlin.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Jon Hunter <jonathanh@nvidia.com>,
        Bhadram Varka <vbhadram@nvidia.com>,
        Samin Guo <samin.guo@starfivetech.com>, netdev@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] stmmac: fix pcs_lynx link failure
Message-ID: <ZICns6xA6geSGobk@corigine.com>
References: <20230607135638.1341101-1-arnd@kernel.org>
 <ZICQMHTowGQTzbxm@shell.armlinux.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZICQMHTowGQTzbxm@shell.armlinux.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/bF8syT/pa0xNk/3bh8dx03kaljdHuQu9FNy844oacEGEqHxhD00n2Bi4+L6?=
 =?us-ascii?Q?2I67xsUwKWHKrO2nf8u95T8yjsjj2LZqyJvnZM4JiRmaOjNkctbo/VAEO9SG?=
 =?us-ascii?Q?evx8EaGbqbpbCTxdMluKHYjDJ8okaGFgCxN2QAuYoAne07aOhVv4a5VGmtQn?=
 =?us-ascii?Q?MrWgnPaUTk6/X+fh4ABi9ZSQMnN1bCAOrXOxBmRzFOwYPZReiqzi2zT9dAUJ?=
 =?us-ascii?Q?iQbDLARKUOexcO80a0GpA7aoUhl8OD/k1p1hP5P0UNyO5vianG6BQyu1Fny6?=
 =?us-ascii?Q?OFpe7vddPCiS7KXtGDIdIvxSR2sDGPiJqdcfet3LRwSUVwuqD6Z1DWMu47OW?=
 =?us-ascii?Q?XwbDE7LAxdgKbSIaNkw48tv4oohA3A627oy2jWQ5XvIUuAGUaLwkkRmlaq1r?=
 =?us-ascii?Q?ol9YoyDC6hxYTruzY9U4/gvn1FUtcmUQ9ZId5eypO1Q4arRGgqMCS5ILEwZr?=
 =?us-ascii?Q?bh94yDzSbdCUxFrgBkK5JiycD7de81HC3Bzy3sG28FwfVExfYkKAqNZ8bMcQ?=
 =?us-ascii?Q?V3dv/bYXpapwlP+YBHXYV7+VxtErzmRKossxq2s/BjU7Mif5VpPNCSmz40DY?=
 =?us-ascii?Q?kArG6pBnsJa5pGCRDlRK8Icz//4f48UN25O8yNDihxJgoHN3CjJpWE/xyQjt?=
 =?us-ascii?Q?N66onI6UxwGvKtAO1YnSw2rGEK27ZH2Q2bGcCq5qpe+1e8CExievKkulC+wE?=
 =?us-ascii?Q?ZYi9S4/cREJPa9bW0covQxCsQdqbGbzL/TfN8EEG1948ukmQOGJrdPL4Xk6d?=
 =?us-ascii?Q?EGzc3Q54AXEJme8r8wn929Ju0PU4Hj8BYDogO+6n9SwcOHrmDJGfQNIC0Y3K?=
 =?us-ascii?Q?7eljQ5xxqysjULhxOH8Le3E5cCHWadZ7Cqkrf+F3twYt6XQU/kbsmDGFmAy+?=
 =?us-ascii?Q?u2BWhtDPviGmx2x98o8rQIlJgTtBpnkLeXBDOu+EfRW4wLfMoAKB4e+bWa4k?=
 =?us-ascii?Q?jdAlMnrf3XmT4vvjjmEzA9SK7MJ0GxEa7SkX9VSIaGmEOQ8LZlL2RRMbqetX?=
 =?us-ascii?Q?agbgOwIzWMQhKISmL4d/IM8DvtYoTzUnAT4Ji+ZRvGOI63DXYKMhEiwGsl3D?=
 =?us-ascii?Q?5I90rTtxHa9aeOs5GrWqtBj2wP9nF6Xy32h28Fu19+ihFsqRG5NqW8vAEgdd?=
 =?us-ascii?Q?rIgwXUHKF9o6+6bIKTgIbPCfoIEPq6i5ouYPZxmoQMZTh0TPESE5QpIJC58u?=
 =?us-ascii?Q?rPbwLkxebmcu4FyzqLnYFsFn0+daew2/LWiDfBiKe03ZEPwppuxOhfasmEsJ?=
 =?us-ascii?Q?wwghzNjMc+smZsTgsixLyL6TTdKUiBkF80HRJ6ZpF66CnR+XCmkkK0p167Vu?=
 =?us-ascii?Q?zDStHPDFg4+eM9NIXX/RRURwRJpDTdAMCgkbi4wL/xE0NJME7G1bEOInhWZs?=
 =?us-ascii?Q?FMQ4F8wZjugUPBu0A+QqzFfJlGyPItUoNTa8FbvdWqtfjIE786MptkGhraIw?=
 =?us-ascii?Q?DhclnJGScv0Xp5uvR420gyUo4tJZgvfxfABnByY70/5UDKwgoY7yulSVW2wa?=
 =?us-ascii?Q?pqSxJGXDdtBtum4HppLHJf5VSMV5zlL3lR4Qek/f/gKUjLbfqHXrcCUKYuna?=
 =?us-ascii?Q?hXGBwE0mG8iCWbSse3NZZPhA7R6lmKKeJkxfKJQMOKNDNI3Jpx+Tt3N+PXSS?=
 =?us-ascii?Q?/xoHxdrhsdMILKhX2tbyeXvNf4iNJ4zAOqPPKaVIA2qttxnI2jma2A2D42e0?=
 =?us-ascii?Q?LMmE/w=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d9f4182-5338-449e-891b-08db676f314a
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 15:52:27.0765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xq3a9JN528NXtzcv/Mf5le5DeftEI87i+na1tYJAr8YR5bEmTPJ9NNDU86ZVMDhXbXm04WGJWASJCHkZmQ1RDPX9/91Nf/ywSisIt5adtBc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR13MB6302
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 07, 2023 at 03:12:00PM +0100, Russell King (Oracle) wrote:
> On Wed, Jun 07, 2023 at 03:56:32PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > The mdio code in stmmac now directly links into both the lynx_pcs and
> > the xpcs device drivers, but the lynx_pcs dependency is only enforced
> > for the altera variant of stmmac, which is the one that actually uses it.
> > 
> > Building stmmac for a non-altera platform therefore causes a link
> > failure:
> > 
> > arm-linux-gnueabi-ld: drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.o: in function `stmmac_mdio_unregister':
> > stmmac_mdio.c:(.text+0x1418): undefined reference to `lynx_pcs_destroy'
> > 
> > I've tried to come up with a patch that moves this dependency back into
> > the dwmac-socfpga.c file, but there was no easy and obvious way to
> > do this. It also seems that this would not be a proper solution, but
> > instead there should be a real abstraction for pcs drivers that lets
> > device drivers handle this transparently.
> 
> There is already a patch set on netdev fixing this properly.

Yes, let's focus on the solution proposed here:
https://lore.kernel.org/netdev/20230607135941.407054-1-maxime.chevallier@bootlin.com/T/#t

-- 
pw-bot: reject