Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iac594737:Fastmail
Date:   Wed, 7 Jun 2023 12:01:11 -0400
From:   Demi Marie Obenour <demi@invisiblethingslab.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>,
        Jens Axboe <axboe@kernel.dk>,
        Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>, xen-devel@lists.xenproject.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been
 opened
Message-ID: <ZICpyBl9/Beq46ad@itl-email>
References: <20230601214823.1701-1-demi@invisiblethingslab.com>
 <20230601214823.1701-3-demi@invisiblethingslab.com>
 <ZIA1yLiJyfcJ45vD@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="WgIi5Tes309KNxkl"
Content-Disposition: inline
In-Reply-To: <ZIA1yLiJyfcJ45vD@infradead.org>
Precedence: bulk


--WgIi5Tes309KNxkl
Content-Type: text/plain; protected-headers=v1; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Wed, 7 Jun 2023 12:01:11 -0400
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Roger Pau =?utf-8?B?TW9ubsOp?= <roger.pau@citrix.com>,
	Jens Axboe <axboe@kernel.dk>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>,
	xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been
 opened

On Wed, Jun 07, 2023 at 12:46:16AM -0700, Christoph Hellwig wrote:
> > --- a/drivers/block/xen-blkback/xenbus.c
> > +++ b/drivers/block/xen-blkback/xenbus.c
> > @@ -3,6 +3,20 @@
> >      Copyright (C) 2005 Rusty Russell <rusty@rustcorp.com.au>
> >      Copyright (C) 2005 XenSource Ltd
> > =20
> > +In addition to the Xenstore nodes required by the Xen block device
> > +specification, this implementation of blkback uses a new Xenstore
> > +node: "opened".  blkback sets "opened" to "0" before the hotplug script
> > +is called.  Once the device node has been opened, blkback sets "opened"
> > +to "1".
>=20
> This is a really odd comment style, and a really strange place for it.
> To me it feels like this should just be a file in Documentation as it
> relates to how to use the driver, and doesn't really explain the code.

Will fix in v3.
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--WgIi5Tes309KNxkl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmSAqckACgkQsoi1X/+c
IsGmCg/+PbmcJVAb/MiNuNHzPQ/Vq7YzVW9qFtwIrvQC5Eb7EjXPWQ4P5TRbBdZS
tH4aoGHWANtB8/M1Gh8GmtYHttitFzuO7oe22pIisvOAM4+28uvXojLN3v4SjrhE
/Dn7xkvivLfKKqmTUbyv5cPbhZVc96VeZ5mn0Gt57+oGMQU+DE4BAG8rRicYW2Ok
isEAlvI+V08xKVW0dOYu9Qis/Qm48kQhbCZHWTuXlIrKBgcTYu40LQMrYg9nd8YB
9uQ75fyAiuZMM55fu54spREudNDP1FkFX5uuXj2A1M8Yjl7G93RMaizvUrjPLeUO
fKbiWrk8Nlc0OKnS4WOAYtnvsTpH6LaJuZA7/IT5sYG7fXT0B0krVxvZsgInNxKJ
nsbr46g4Sv2LoJTifF8rrF+ujGBWceDkB5VIo6bhYqNbJ8xLGfaFEYrF7XcliWf0
RstpIOa7kKVA0GV/l8HezD+Iez1BoUatPsPq1cdzp7bTsN2rgG6VK+0jWmV01n/N
8wyHxfXU8Z3NpTNFPJXgjTu4zqcLsKpmpsbP5Ee7W3bKNrUZXIRL6spGRJcOxcsi
POrPJ72Zf8Sw+vULlK0+hKSf3BtckaTVmCU9e3qJE+4ukrzpoFVvf96mPVaXLMaT
OLY/3zj/5bNxCzSC+GWKTMTg2lL6Txbyfyht0YkfmUL3Rgh9i9Y=
=nc8R
-----END PGP SIGNATURE-----

--WgIi5Tes309KNxkl--