Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a45e22d7-9178-ebb5-ef4b-691606dd7560@intel.com>
Date:   Wed, 7 Jun 2023 18:18:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2 bpf 03/11] bpftool: use a local bpf_perf_event_value to
 fix accessing its fields
Content-Language: en-US
To:     Nick Desaulniers <ndesaulniers@google.com>
CC:     Alexander Lobakin <alobakin@pm.me>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Song Liu <songliubraving@fb.com>,
        Kumar Kartikeya Dwivedi <memxor@gmail.com>,
        <bpf@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <tpgxyz@gmail.com>
References: <20220421003152.339542-1-alobakin@pm.me>
 <20220421003152.339542-4-alobakin@pm.me> <ZH+e9IYk+DIZzUFL@google.com>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <ZH+e9IYk+DIZzUFL@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y05KU0V6bG9wdWhFUWtSUS83YTVXdjdVZ1lKeHJUN2JCSW5TS01MbkNkRXRV?=
 =?utf-8?B?QXdlZUtEWk8rRFZEKzgwd2dNR2xwZHJNTi9OVm5UdkF2Y2Vkc1pvUm9nck9s?=
 =?utf-8?B?L3praDBzWnkxeUdqYVF5QUVlUUkxMHNtQTUwdGtLRzFrMEd3THFFK2NnbEEr?=
 =?utf-8?B?RmhDeW5EbzNMZXUvazUxellnemg3TURFaEJsWE5TYXNKOEtha0tPSjFZQmx2?=
 =?utf-8?B?Qy9SRlZJOCtZb2d6UlpIdDMxWmM5WG8zY01KY0FXRWlCbW5EeHQ0MjJFWW52?=
 =?utf-8?B?SXdJbGZFYTA3bkZVd0o1eFhoVzlNY2JPUXJ1VUl5amFKa0gvZXZHNEkvU2g5?=
 =?utf-8?B?bmVpQkdxbHBIUDFKR1NjeFRpT2lxNjBHc2lMeXhuUUhPVDZVOGFuRE5kUnRF?=
 =?utf-8?B?SUNBMUlrb1BxSk5pWGZ4aG5IVjFJbmZyMUxKM0I5blZxb3d4ckFLc1NvQTJm?=
 =?utf-8?B?b3dvZ3hjZHBWbW12akpYYjVqRVlZdFZyYXY5TDEvckNBc0l3Qml1OUFWeEF1?=
 =?utf-8?B?SU5VYzVZVXMwenJEMnRBZVRnaSttSVdUNjd4WVl2aVRSOXBtZ1IxbVdtMGtR?=
 =?utf-8?B?OEZmK0FlVXQ1bDVBTWVmRVhvdE8rQW5YZmdML0lVbzZEdFhwZTVaNEVteFRZ?=
 =?utf-8?B?a05pTE9yWkpPUHRFVUVnazVkT1dMbzFPY0YrSTlnb1hmMkx1ZlVTK0N3R29H?=
 =?utf-8?B?OW9YaTlHOVdTNk1PQlpKZzluZ3ZUTjkyNmpPNGY4a3hpUllFWElTTWMwUDJN?=
 =?utf-8?B?T3NJV2QvcUlyeU5QbFFoR0daZVFZdnJaZWE5MWRhTHExQUhZUVQ0cWZjdVEz?=
 =?utf-8?B?NmIrczRjSmJSR2V4czIxRm1CUWIrclV6SmQxQ0JXc3BSdCtYTmdhSmt6aEly?=
 =?utf-8?B?Q2grQlJsekpuWmo3djRSZzNyZ0RkQ0Y0M0JOYWc1elBhRW5WU3NieTVzL0JZ?=
 =?utf-8?B?a0FRZjBuaDBmSmtLTkQ5UFJsQm9XUCtFcjAyU05lQ0VBdDJmdVpCUnNmbk9Y?=
 =?utf-8?B?d0wvcnlPV3Q3QzBlRE1sNS9mUnNSdUtVM1RxOVZuVmhSdjZRck5TYm5mL0tx?=
 =?utf-8?B?Y0FFU2w5NGltaEh4VFNrb1FWK0x3OHk0YkV6UDd1TU9USmhIM1V2OEEvb2Ry?=
 =?utf-8?B?N0xBN0VqcEZMQjJBWHJKcWc3RkZ6NkRwc05weWFaRmxRVERIZFlSb2wrWFNG?=
 =?utf-8?B?bVF2bUxEZEM2YkQ4b1pCVVRXdkE3S3krVGNEcGZVaUxyOUJ6SHZ3bGxRTkpk?=
 =?utf-8?B?VEJYKzRUOW9JRERQZ3ZKeW91QVpmcFMvSzk5UWNGVEZRVUl5bHY1bXY4c1dj?=
 =?utf-8?B?MFQ5NUtNS0FpbUMzWS80c1pMd1l4Tk1IWVJiVTJKNVpWcGVCRXlDSXQ0Tlhw?=
 =?utf-8?B?LzVQNXJ1cVhFWFJqTjB5Nng2V2QyekZRc3JGVGo0N3JDRkFPL1N1QjZuKzNY?=
 =?utf-8?B?d2h1VXJ2MTVMTGs1VG9aMHVMdXJTNlBveE95ckhCV3BlV20raHp5MEk2MnEy?=
 =?utf-8?B?aXVhN0hWeVB4bkRNelZoZHY1WE9jc09tNGh2V1lRakQyK1krdkZ6MklueTM2?=
 =?utf-8?B?dEdIQnJ3MkpKZ3lGdmlRc2w0VWlSaExRWXZzS1JmRmRVUitQdDBFUjVTYmhP?=
 =?utf-8?B?YmRneFBLZm0vdEJlZHBZRDZRUHhVZ1NpWjNnYSt1UHZVZW55YnI4N0FPMGp4?=
 =?utf-8?B?TndWc1pMaGxwSjFmbEROeHpSRTJYV3oxS1U2enI4aXFsOHFMa1NsSDh6ZXB5?=
 =?utf-8?B?YjZMUDZ1UXJKR3BYd1A5WnJIZFJlZFQvdlo4S0RXR2dqTFdDaWY2YkF6Skcz?=
 =?utf-8?B?cFgrWmp4L3pHWHM4WmVhL0U2M0QwUUw0VGZacyswaDNEMjMwVDUxdlYyaHhN?=
 =?utf-8?B?T3gvbFZNRnFvcVFlRTJTUnhHQ1pEekxKUnFuTlVkcVJVYk1wb05ST3pKdU0w?=
 =?utf-8?B?aUQwem4rRG9nMDY3bnlOa3dmRGlwV2hRVXJXYmZsS0FGMUxLNngwU0hvaXpB?=
 =?utf-8?B?UFM5aEZadEF3M0MrODRzSE9Ha0EzeG5GMmZqemc5Y2E0YlZxbDJJa0Jjc2lS?=
 =?utf-8?B?ZkhvL3FlR0lma0ovZURaL2ROVDlCcnBqU2hVMUc1RWZ4b0NmR2Zmc01GaGww?=
 =?utf-8?B?WFZVLzkzWVZ1QkZ2b0ltaUthVWpxYmNEZ0JWV2Q5dHlTaXBkT3ZNaFZGTm9n?=
 =?utf-8?B?b1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8aef559c-224e-4f32-f78a-08db67731661
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 16:20:19.9863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s4efYJnKxClm9lr2aLaVxG9ScJok9/aHH9ZOzAQ6ebTdp7pJQ2NjboPb+uIFtyTfEidbt+tGgoMNmPysOUWhpPpNT4C+ksj9Ue+ME+VsW/0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4611
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Nick Desaulniers <ndesaulniers@google.com>
Date: Tue, 6 Jun 2023 14:02:44 -0700

> On Thu, Apr 21, 2022 at 12:39:04AM +0000, Alexander Lobakin wrote:
>> Fix the following error when building bpftool:
>>
>>   CLANG   profiler.bpf.o
>>   CLANG   pid_iter.bpf.o
>> skeleton/profiler.bpf.c:18:21: error: invalid application of 'sizeof' to an incomplete type 'struct bpf_perf_event_value'
>>         __uint(value_size, sizeof(struct bpf_perf_event_value));
>>                            ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> tools/bpf/bpftool/bootstrap/libbpf/include/bpf/bpf_helpers.h:13:39: note: expanded from macro '__uint'
>> tools/bpf/bpftool/bootstrap/libbpf/include/bpf/bpf_helper_defs.h:7:8: note: forward declaration of 'struct bpf_perf_event_value'
>> struct bpf_perf_event_value;
>>        ^
>>
>> struct bpf_perf_event_value is being used in the kernel only when
>> CONFIG_BPF_EVENTS is enabled, so it misses a BTF entry then.
>> Define struct bpf_perf_event_value___local with the
>> `preserve_access_index` attribute inside the pid_iter BPF prog to
>> allow compiling on any configs. It is a full mirror of a UAPI
>> structure, so is compatible both with and w/o CO-RE.
>> bpf_perf_event_read_value() requires a pointer of the original type,
>> so a cast is needed.
>>
> 
> Hi Alexander,
> What's the status of this series? I wasn't able to find a v3 on lore.

Hi,

Sorry, I haven't been working on my private/home kernel projects for
quite a long. As Quentin mentioned, he took some patches from the series
into his own set. I'd support that one rather than mine.

> 
> We received a report that OpenMandriva is carrying around this patch.
> https://github.com/ClangBuiltLinux/linux/issues/1805.
> 
> + Tomasz
> 
> Tomasz, do you have more info which particular configs can reproduce
> this issue? Is this patch still necessary?
> 
>> Fixes: 47c09d6a9f67 ("bpftool: Introduce "prog profile" command")
>> Suggested-by: Andrii Nakryiko <andrii@kernel.org>
>> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
Thanks,
Olek