Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20230607160528.20078-1-kuniyu@amazon.com>
References: <20230607160528.20078-1-kuniyu@amazon.com> <20230607140559.2263470-10-dhowells@redhat.com>
To:     Kuniyuki Iwashima <kuniyu@amazon.com>
Cc:     dhowells@redhat.com, axboe@kernel.dk, borisp@nvidia.com,
        chuck.lever@oracle.com, cong.wang@bytedance.com,
        davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
        john.fastabend@gmail.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        netdev@vger.kernel.org, pabeni@redhat.com, tom@herbertland.com,
        tom@quantonium.net, torvalds@linux-foundation.org,
        willemdebruijn.kernel@gmail.com, willy@infradead.org
Subject: Re: [PATCH net-next v5 09/14] kcm: Use splice_eof() to flush
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2288535.1686157805.1@warthog.procyon.org.uk>
Date:   Wed, 07 Jun 2023 18:10:05 +0100
Message-ID: <2288536.1686157805@warthog.procyon.org.uk>
Precedence: bulk

Kuniyuki Iwashima <kuniyu@amazon.com> wrote:

> > +	if (skb_queue_empty(&sk->sk_write_queue))
> 
> nit: would be better to use skb_queue_empty_lockless().

Ok.

David