Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1073550rwd; Wed, 7 Jun 2023 10:34:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ61vc9fdb/7zkOU16Un6cL6N6gxoykB5rhjJCbGhnZnGL/X+8BUgrklvUNV198YTwHC3Qz2 X-Received: by 2002:a05:6a20:5496:b0:10c:1b38:c89d with SMTP id i22-20020a056a20549600b0010c1b38c89dmr2105994pzk.2.1686159241898; Wed, 07 Jun 2023 10:34:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686159241; cv=none; d=google.com; s=arc-20160816; b=WQvvHehPeZa0BIlIdKJJkj72ZeZsJO/Ntm1IbV0m3WKyWjzxpX7FIclkpUllnrkDSx q+X35fjZgqj/9mOTo4mAKVr1Qt01NcLnbbLHRzXAtaXTgfXRwXdGEuDtRh+q0kjr1PBX gW26c7sxri7nqEutOgezOy7isPXbUi6y1kIj1avq8yCridqGflM2er6KB2H1zNOFu52L TSb9dxrr/hSuNtFTjA8YkTtaDUVc5VEHVVa/Ee8fdEYKh+e3/Zs5kuCj+rf+Crzc4kMj sKCuvlbx3CClf2LKaO2nJciqsoQXvk5NwzFZvOZORzJitHxpjhvn5FzgApBMpvGEME9q CRJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=mp4qHtlJS2jk9b2saG3EpebfyEBIrlg2e46Lmm6jsVY=; b=CldtiNiht7BvWr631rKUwTCRNkhOQZ07kL3Nw16tQDEjTmU7D1Id2rChM39Zwpq8Na SlvopU480UUIhG2tRB2FKl0l3XpcpwSA7dall3WDzXhGXutk/1Ej/+bENqSH4YgkI5CO Bz9HZQNnQcRIz5OuKucS02r9lyQ/+03w98QMTwvLfDiNcgIgIVMsBQaqvO4Slp4XwCzN Z4Ehd3BVfa85/t0zVd8ob2IZMHnliIWYLWLvwkNuDHAlAdJh9ZWGzPbigFcMDWAurayw tsGiOBnrTNhJ2ZVX9J3+sxlEToyV1YcY2tl+23NZX/bdSBzFKCDMhvBO8NsXJ0ifUyOs BtLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QrgEDUrp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k64-20020a633d43000000b005347efdfecbsi9467656pga.111.2023.06.07.10.33.49; Wed, 07 Jun 2023 10:34:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QrgEDUrp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231584AbjFGRU2 (ORCPT + 99 others); Wed, 7 Jun 2023 13:20:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231586AbjFGRU0 (ORCPT ); Wed, 7 Jun 2023 13:20:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C8E1E62 for ; Wed, 7 Jun 2023 10:20:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 113C763B0E for ; Wed, 7 Jun 2023 17:20:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C17FDC433EF; Wed, 7 Jun 2023 17:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686158424; bh=adqvDA+1TjaAGnTMKfAosw2t+UHx0gdR3o+C9+WLfas=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QrgEDUrpuvtjtYYXyNXRk1dM2+tU5LatKXwXs/1xrXOOFssrCslRRsYtUyt3hdrkn Dh+x3YRI3wjtLLcilrzbAlRVvaLYnG0rcVd/Zq5rTIqTJb/bk6b2AdJhN2Jwvr5VQy Y+psu3Ozz53QvE8pkOaoGyFJra9fJeporG6xTn4ngLRRqX0uGjaWkRdg3rbA0NO/bn Ou7iQI5PFw3OR4mfe5YqMygaocJk4FR2iqfVb4093jkA93CKs5hB+FL+jEI4h/LAmU z/1SnG7PASoJh0YamOmuhju0WO98sy0xlKkuv/wDL7v5AV7XKcTVyZ4CA0JS3GEw1z tKCVsbaX9/Elg== Date: Wed, 7 Jun 2023 10:20:22 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next v5 12/14] tls/sw: Convert tls_sw_sendpage() to use MSG_SPLICE_PAGES Message-ID: <20230607102022.42498d4d@kernel.org> In-Reply-To: <20230607140559.2263470-13-dhowells@redhat.com> References: <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-13-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Jun 2023 15:05:57 +0100 David Howells wrote: > Convert tls_sw_sendpage() and tls_sw_sendpage_locked() to use sendmsg() > with MSG_SPLICE_PAGES rather than directly splicing in the pages itself. > > [!] Note that tls_sw_sendpage_locked() appears to have the wrong locking > upstream. I think the caller will only hold the socket lock, but it > should hold tls_ctx->tx_lock too. > > This allows ->sendpage() to be replaced by something that can handle > multiple multipage folios in a single transaction. Reviewed-by: Jakub Kicinski