Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1080586rwd; Wed, 7 Jun 2023 10:40:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5QjW0+V//lKDClbz4mZuNfn+LQXjNOQ6IHaemeXixrJ4FH2JnhqahThCRJMorqjbWc6b02 X-Received: by 2002:a05:6a21:2d0b:b0:111:997d:d203 with SMTP id tw11-20020a056a212d0b00b00111997dd203mr1493720pzb.37.1686159640185; Wed, 07 Jun 2023 10:40:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686159640; cv=none; d=google.com; s=arc-20160816; b=eWGUbw0i90sqoiHp+zRoN5ba/hgrgMKAzlsieti8ZVM45HhJCqk5W3LwMVZ1iRlwjc BKYqvJFA91aheK+kR/54izHOzaOrsssZbKHZoJQtJwFdMOkEF3oXp4yX5vD80zzJSb5K PkQQYK711d2nxQ0XsWRnK/anK/bJKzXc9SkHMEFMdwMAccv+YV5tlVjkSgvRpD0hh14i Xgs4QydNjxNgpcYp4yqv0T6dvzUGk6nzkwSs7Od6UAqbrZKplIhhmXwbO+bNwXzmMCuR lR2tTpgORy+dATSppTvSugz9w3pY2B+nQiYvIrq3ObgHHyXdSLZSfB+0kCr4pwMjcQDJ Icrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Tw5o6fPw9gyzLqlDqc81hSMsgIXuIKAfkg7pFLSJhc8=; b=zpUbXnqSXCebrSCiLdVX22cckzdc6CjfC2QU4GDQsbrqpj7ecoLBUXEqLlaPgMGrrp lZVJrS/t2AeTGeLFm13mFlOtX/GT9NjD3AGGd137poEovJpxcrAbmrGRZrXJxuooL3qA ucRIdGtExZi/MKTTmoW3lKCIMT6psCpfSHTnvuevVlrsorQxfFz4HHdWv0k2v+PZnLBv bUW3Yl53PsLxOhFzRINWn7sOW6uUSsFWz5iY6i/RxoqkUHiEsSSSgkEq+07XUvRcjgWx xxWBbKGQ6cHFHukK2nHcNoML2H41VPnLej3xkH+7CIuEtwnqEsTi7Dj6jnZ36A6SZYDf Ap6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NYJztc6K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h3-20020a056a00000300b0065d87744215si4405342pfk.198.2023.06.07.10.40.26; Wed, 07 Jun 2023 10:40:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NYJztc6K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231388AbjFGR0P (ORCPT + 99 others); Wed, 7 Jun 2023 13:26:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231545AbjFGR0D (ORCPT ); Wed, 7 Jun 2023 13:26:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 970B81FE9 for ; Wed, 7 Jun 2023 10:26:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33EBE641ED for ; Wed, 7 Jun 2023 17:26:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05812C433D2; Wed, 7 Jun 2023 17:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686158761; bh=0MBhuEUX2bktmVFKRPGnv8oU9W5tm0XrwIeAW9OBqu4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NYJztc6K5jZaEpT5qmYChibBOYzwSAkpmz4luHH2EERw0PJbUy4NdUK7sOHmMohEv L4Y7jZiccYhyhFR5ioEP01GXWEyxpDJ73Gab/BxVRJhCWxnFAvzE29QxtsB3IuT1xn qTcuRgtm/jMMrfC+i53EtgpTUIBBrnLMh+sI0NfGT4IFKTnbOOgHyY6BB+ny035F9E av80Tcccr/PaZaKHCB3HTiybgCAWkD4ePOn5L4H0tXwCaTFgXNFkqzK4UldjZtsxwy rbwwSEegzCShGku9llVhj8mpPI6xq3GpFvw8RP/8sQpd1zt7NT2VqVpvzleaooJKow euaKcvwu3sxTw== Date: Wed, 7 Jun 2023 10:26:00 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 14/14] tls/device: Convert tls_device_sendpage() to use MSG_SPLICE_PAGES Message-ID: <20230607102600.07d16cf0@kernel.org> In-Reply-To: <20230607140559.2263470-15-dhowells@redhat.com> References: <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-15-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Jun 2023 15:05:59 +0100 David Howells wrote: > Convert tls_device_sendpage() to use sendmsg() with MSG_SPLICE_PAGES rather > than directly splicing in the pages itself. With that, the tls_iter_offset > union is no longer necessary and can be replaced with an iov_iter pointer > and the zc_page argument to tls_push_data() can also be removed. > > This allows ->sendpage() to be replaced by something that can handle > multiple multipage folios in a single transaction. Acked-by: Jakub Kicinski