Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1081952rwd; Wed, 7 Jun 2023 10:41:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ67dHZDF19IiTkHef9qZxIMfdJLCfMnwA469mSeHwdL2jxRGR/wOuNDvA5ZzG/KpFKuR33/ X-Received: by 2002:a17:902:ea0e:b0:1b1:4801:f522 with SMTP id s14-20020a170902ea0e00b001b14801f522mr2890275plg.59.1686159718603; Wed, 07 Jun 2023 10:41:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686159718; cv=none; d=google.com; s=arc-20160816; b=ye+WpVwh2lRToAhUFHRXvlcHJYU1rTWuMEUXCxLIElKa4z2bjuFFt2PU0ptaqh1GLR nqAtwtCk4xHpPYG+jwM5RtJ3YA+pC2R9MwqyOdoUKB/+T8EUbKCXvMGrRGW3AxneJH+A 1IRR+IpceeKd4iW5Jku/ZNXmoNpbNTIhJCp6S73BwUQ0bCt1yLdb3O6TNVUkgeByqdQM ySnBngwyEPtf+rg78OKPO2QnM9+rH1B/68IH1j8ZleA0ygrKWeD64alOXGC7KwKsS5fV EnSVfqUn8fhbw8I7Yf/20eppFjCXcI0xatdxiYwJuNFrdoMd+wxF9cPTIU5f5EOYz7mE 0RtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=3l9BAB0RpRyc51f36wJTHJ5qug4Zex49rbXvz/nzH6A=; b=fMdNM6RWcU5WT7Rcg51+goxChT5mXb+wd6MBrUdGMS3tGv2eQ8eHqmZWxphv2iHit9 mJi0XK2Ne7Uzr6U4K0lj5zF88UxqO2rLoWWzU0bASh3zoUQoPopGGp2YZMr9BbA7HdHx alqIcgTE6MhK6qTK7N5zExfNPkoaro27pFPIYx/YXNUQFjKwSPaO/nIJ4fGqYi4VEwsB MH6uC62gtzYt3efUx7611aQZUQtFeFcl8JhgcI7d7VZTJB/8Ck4n1hq+cKqrh+DvDtpD e9c/ifrlP05EyQv75EvrpEf6fmIrmpCLy4ofqgTlEUFcUT8mmsB0u4a4dLAHB7F9h7KP p4HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a2SiPzTR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020a170902e5c400b001afc438f915si9269797plf.626.2023.06.07.10.41.43; Wed, 07 Jun 2023 10:41:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a2SiPzTR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231901AbjFGRas (ORCPT + 99 others); Wed, 7 Jun 2023 13:30:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231935AbjFGRab (ORCPT ); Wed, 7 Jun 2023 13:30:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 604E4210C for ; Wed, 7 Jun 2023 10:30:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DFCE8641FD for ; Wed, 7 Jun 2023 17:30:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4F66FC433EF; Wed, 7 Jun 2023 17:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686159025; bh=rMJ3ZHFNgdmlUuFM0xas0L1YWaRZl3xS0/0vxWWbySo=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=a2SiPzTR8J6pyrOsbeOb69AYtOBZmdC0ghJT8cV6J2ILLBxbTxW/qb7N5euoDTGQm Z9b6877HcuZCQBmtOwc5JSlt+iznnLD8XhQVTgXDgZrDQlDSkXOHQBX0fyqcuH8Gdl hnPonUmxhxXtTcRQ7lp0ev0lAW/+0/9HrijJnWU4BTmGMNzamvvr3Q0nfcWOW9wbqb fLkjJpYtveFZjYRlmfPCoUwZWaxccxkBU2FALAVNP+VurWZcv1TKButLIOdNwpUgSK C5fyYBEMMmtP/PtPSWSWg7NC55FqxyCSKREQC+jwMgnoQh+dGfH5Fty5a2IzUPCnLB ok7KLYWvaL3Qg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 24B87E4D016; Wed, 7 Jun 2023 17:30:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode From: patchwork-bot+f2fs@kernel.org Message-Id: <168615902514.7521.467509343163618820.git-patchwork-notify@kernel.org> Date: Wed, 07 Jun 2023 17:30:25 +0000 References: <20230531014055.3904072-1-chao@kernel.org> In-Reply-To: <20230531014055.3904072-1-chao@kernel.org> To: Chao Yu Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 31 May 2023 09:40:55 +0800 you wrote: > There are several issues in sanity_check_inode(): > - The code looks not clean, it checks extra_attr related condition > dispersively. > - It missed to check i_extra_isize w/ lower boundary > - It missed to check feature dependency: prjquota, inode_chksum, > inode_crtime, compression features rely on extra_attr feature. > - It's not necessary to check i_extra_isize due to it will only > be assigned to non-zero value if f2fs_has_extra_attr() is true > in do_read_inode(). > > [...] Here is the summary with links: - [f2fs-dev,v2] f2fs: do more sanity check on inode https://git.kernel.org/jaegeuk/f2fs/c/3ef38938753c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html