Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <94f78001-13df-8c39-4771-7842dc94195e@roeck-us.net>
Date:   Wed, 7 Jun 2023 10:33:11 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] hwmon: (oxp-sensors) Add tt_toggle attribute on supported
 boards
Content-Language: en-US
To:     Joaquin Aramendia <samsagax@gmail.com>
Cc:     derekjohn.clark@gmail.com, jdelvare@suse.com,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230527012206.133464-1-samsagax@gmail.com>
 <8ae3e2ad-27ff-4339-88d4-504c2f59e501@roeck-us.net>
 <CABgtM3h8DXs0swGQth=dcE3J_W8k8iejvfFgjVSm9nKbRmxHDQ@mail.gmail.com>
 <820cef00-4768-46ae-c5a5-ea7c0dff71c5@roeck-us.net>
 <CABgtM3h0KMsOzZZvYKZLsFXn9A81V59ygSKizoF3TTkraMWr-Q@mail.gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <CABgtM3h0KMsOzZZvYKZLsFXn9A81V59ygSKizoF3TTkraMWr-Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/7/23 05:40, Joaquin Aramendia wrote:
> Hello again. And sorry for my late reply. I'm struggling to find a
> good solution to this functionality. It most definitely feels icky to
> be attached to the hwmon driver so it should be a different driver for
> those devices. Would misc be a good place for that single toggle? or
> maybe platform? The latter seems most fitting since is very device
> specific.
> 
>> You are attaching the attribute to the hwmon device. Moving the driver
>> to another directory would just be an attempt to avoid review by a
>> hwmon maintainer. Just for that reason I would NACK such an attempt.
> 
> By no means I intend to avoid review. Don't get me wrong. I'm trying
> to understand what the best practice would be in this scenario. The
> driver is part reverse engineering and part asking contacts from the
> manufacturer (who is no longer in the company so it is reverse
> engineering at this point). So any new functionality we find might be
> a different driver for what i gather since it is not related to
> hardware monitoring. The oxp-sensors as is now it is mostly done and
> it works well for the users.
> 

Why don't you just attach the attribute to the platform device as I
had suggested earlier ?

Guenter