Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1142545rwd; Wed, 7 Jun 2023 11:36:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6mAnmnCZAhFX2Sb7+C2IN7iTIDkrofQUMRGdTe1Fmt9CSxoR0eczGifor7NDqnR/J+3BCV X-Received: by 2002:a17:90a:6082:b0:256:82a7:e0a9 with SMTP id z2-20020a17090a608200b0025682a7e0a9mr2535783pji.49.1686162998842; Wed, 07 Jun 2023 11:36:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686162998; cv=none; d=google.com; s=arc-20160816; b=Uh1xso+/M7tKRwOOdIp2mqDmzOlhg4gMR7EdRqJoV5sykymMHjbEZ5JioyFEjqnbrP YdcudlUZNEPvgyfUXjkuxSX1A9Llt7+vFsF2lPJ0DPWZx9+emrtWWJQmw+AcjcCcFuJC kPSe20Eci6YTsEyz63J0xdsDEyH/8HiuQMGIGW41zPZERNAnrSuE5E3Ao9ksVGciG38g 6x8MwPBe4u1x1Zi9dcFTRykBy1eR+A5M+dziRnuVYRna2Mb/bsex8Nt4OB96wPhMsR0i 88t742CfDXJDdwcy9/Ixj1o3i56DlSPAEpW5S2KKpZpByvKpUJrrmzeDhdwXwAxLxUa6 XVTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ZRj+mE8jCuZmOYVQqkftbO+ddM2GLO7xQ0oXcx+IVPg=; b=v8s5C+lW6AK5SRyTtK5nBVO+7ZC48HMKwUkoLuEUDZuiTuVo+laahtPJAY5Z1bSu/r e2aRoHqTiY4ilStBbUJq7qZX+oKqZ+Gz/4ovFAwA9ZRtr7SZOhL831RhPnjo9N0Hz8XI kUBo/b8WO127VlrlpVjkxCKE4KzYlbfkbiRRGVETJSdE9XwcM9o11TJAVkYoA5z3KRuA Hvt40Ps3tH9qrQkXUiQJ8wXn3LoOHejrpErzdDPX1x8fH8k4vnUd52Ygt9Jn+5ujEHxA TAnuyz4UhkvKzkKkNshh87HdPZc74cZTGFdd2Qyt6EpEmNw+o5JWPfvp0OR9ZgBHYJHF kHqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pzkOcuk2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id na11-20020a17090b4c0b00b0025023111538si1535853pjb.36.2023.06.07.11.36.14; Wed, 07 Jun 2023 11:36:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pzkOcuk2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbjFGS1V (ORCPT + 99 others); Wed, 7 Jun 2023 14:27:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231792AbjFGS1P (ORCPT ); Wed, 7 Jun 2023 14:27:15 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D99732694 for ; Wed, 7 Jun 2023 11:26:44 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5149c51fd5bso2016703a12.0 for ; Wed, 07 Jun 2023 11:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686162401; x=1688754401; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZRj+mE8jCuZmOYVQqkftbO+ddM2GLO7xQ0oXcx+IVPg=; b=pzkOcuk2QH5o8cSqzHedtXSDBcDhlF3m1WDSJvl7OVrVSK0Q3W5DgsoqMvf5fE6X1O JiAdA/oH10Y2IzEdmhHsNm8PNLmX60mlHAlZAIOXaP2bSe8a+0mEOri7GwAahN3I5w+f 1OL1nbq2JFg8rTKxc6LBUiNSYG4iuckRDEIeTaOeihJgbOKV0yrHA8pB6c9bi1DrhM94 tqerLRwLfB06wLXl+kKoTWrJ4q7Zr+C2dRU4lQUXsjOcOb6mq4R8VySKoRElUYe2vN6X DevUHmBVJ+Pq2mmfVm3H5BZBlHQLtIch9DGumt1Ttpem2iJLme0pspfd6gIMqNQYVqXF 8bqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686162401; x=1688754401; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZRj+mE8jCuZmOYVQqkftbO+ddM2GLO7xQ0oXcx+IVPg=; b=EPorcdcN1DJ2I6OKZYoQk5PgyWiyT1tZRuaAEvlEdGWZp1loYw2RIjyMMnFxOaVU5c MkDji8ArEMG04+cITMK0nYpC3wYJW8IGY96OsHQgavQx01oYWffvfYnCmDfK10dQI7yi +Sbk7FJ/WOCLualJPi6B6JP2t9KgEesUfssqiyUcD6Nk7tK+QKh9qdzPnY0SweI9Kh9E Ny3sEtSNjJzQ+K9STAmVzCaX+fmWIJEwh94SUXimSp0I++LWHltbkqkI3KiXUcvc9KbE n+Tm9uLo2eZm87FzME6kd/M/kM8cPVkMI57aDbNIyykiiGBUKa19cfU7xW2jGYyLXj5k j9Ww== X-Gm-Message-State: AC+VfDz+to94p41psH+oX8fJvf1GXnwYHra05RXRBwHlctoXjXpa5UtG IO38mKajYs4G9RsuGMyvNnxTbw== X-Received: by 2002:a17:907:3e1e:b0:96f:b58e:7e21 with SMTP id hp30-20020a1709073e1e00b0096fb58e7e21mr7507816ejc.52.1686162401374; Wed, 07 Jun 2023 11:26:41 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id bv2-20020a170906b1c200b009659ad1072fsm7215357ejb.113.2023.06.07.11.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 11:26:40 -0700 (PDT) Message-ID: Date: Wed, 7 Jun 2023 20:26:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [v5 3/5] dt-bindings: mfd: Add aspeed pwm-tach binding Content-Language: en-US To: Billy Tsai , Patrick Williams Cc: "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "lee@kernel.org" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "corbet@lwn.net" , "p.zabel@pengutronix.de" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-doc@vger.kernel.org" References: <20230606094535.5388-1-billy_tsai@aspeedtech.com> <20230606094535.5388-4-billy_tsai@aspeedtech.com> <35bf0a69-bcf6-ae35-eb3c-e74cfcf9c571@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2023 08:26, Billy Tsai wrote: >> Missing description. But more important - why do you have such child >> nodes? Your example does not have them. What's the point? Do you expect >> different number of fans per one device (one compatible)? > > In this patch series, I have included examples and descriptions to provide additional information. > The child node is used to enable the channel of this tach controller. Children are not for this. Look for cells examples (e.g. gpio-cells, pwm-cells). It seems this is the same as Nuvoton NCT7362Y, so no. Don't use reg for that purpose. Best regards, Krzysztof