Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230607171159.2019417-1-tharvey@gateworks.com>
 <20230607171159.2019417-2-tharvey@gateworks.com> <CAOMZO5ASwTJpH84SJX78k7MtZzwFc0bnbGqXsSFA6JFGq+0Emg@mail.gmail.com>
In-Reply-To: <CAOMZO5ASwTJpH84SJX78k7MtZzwFc0bnbGqXsSFA6JFGq+0Emg@mail.gmail.com>
From:   Tim Harvey <tharvey@gateworks.com>
Date:   Wed, 7 Jun 2023 11:33:01 -0700
Message-ID: <CAJ+vNU1zCXxiwpkCuYTUocZR6JWAg7wFGR6eQEYwW=ZSd15CGg@mail.gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: freescale: Add imx8mp-venice-gw73xx-2x
To:     Fabio Estevam <festevam@gmail.com>
Cc:     linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 7, 2023 at 10:16=E2=80=AFAM Fabio Estevam <festevam@gmail.com> =
wrote:
>
> Hi Tim,
>
> On Wed, Jun 7, 2023 at 2:12=E2=80=AFPM Tim Harvey <tharvey@gateworks.com>=
 wrote:
>
> > +/* bluetooth HCI */
> > +&uart3 {
> > +       pinctrl-names =3D "default";
> > +       pinctrl-0 =3D <&pinctrl_uart3>, <&pinctrl_bten>;
> > +       cts-gpios =3D <&gpio5 8 GPIO_ACTIVE_LOW>;
> > +       rts-gpios =3D <&gpio5 9 GPIO_ACTIVE_LOW>;
> > +       uart-has-rtscts;
>
> 'uart-has-rtscts' means: use native RTS and CTS lines, but you are
> passing 'cts-gpios/rts-gpios',
> which contradicts that.
>
> I suggest you remove 'uart-has-rtscts'.

Fabio,

Yes - will remove for a v2

Thanks,

Tim