Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 22:36:09 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     "Bhatnagar, Rishabh" <risbhat@amazon.com>
Cc:     sfrench@samba.org, stable@vger.kernel.org,
        linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5.4 0/2] Backport few dfs related fixes to cifs
Message-ID: <2023060752-trespass-hertz-32a4@gregkh>
References: <20230607185313.11363-1-risbhat@amazon.com>
 <2023060750-unpledged-effective-bd95@gregkh>
 <de36d593-5f1e-bb9b-6b70-8be0b783c5f4@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <de36d593-5f1e-bb9b-6b70-8be0b783c5f4@amazon.com>
Precedence: bulk

On Wed, Jun 07, 2023 at 01:20:23PM -0700, Bhatnagar, Rishabh wrote:
> 
> On 6/7/23 12:07 PM, Greg KH wrote:
> > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> > 
> > 
> > 
> > On Wed, Jun 07, 2023 at 06:53:11PM +0000, Rishabh Bhatnagar wrote:
> > > Recently we have been seeing kernel panic in cifs_reconnect function
> > > while accessing tgt_list. Looks like tgt_list is not initialized
> > > correctly. There are fixes already present in 5.10 and later trees.
> > > Backporting them to 5.4
> > > 
> > >   CIFS VFS: \\172.30.1.14 cifs_reconnect: no target servers for DFS
> > >   failover
> > >   BUG: unable to handle page fault for address: fffffffffffffff8
> > >   #PF: supervisor read access in kernel mode
> > >   #PF: error_code(0x0000) - not-present page
> > >   PGD 260e067 P4D 260e067 PUD 2610067 PMD 0
> > >   Oops: 0000 [#1] SMP PTI
> > >   RIP: 0010:cifs_reconnect+0x51d/0xef0 [cifs]
> > >   RSP: 0018:ffffc90000693da0 EFLAGS: 00010282
> > >   RAX: fffffffffffffff8 RBX: ffff8887fa63b800 RCX: fffffffffffffff8
> > >   Call Trace:
> > >   cifs_handle_standard+0x18d/0x1b0 [cifs]
> > >   cifs_demultiplex_thread+0xa5c/0xc90 [cifs]
> > >   kthread+0x113/0x130
> > > 
> > > *** BLURB HERE ***
> > No blurb?
> > 
> > And this says 5.4, yet your patches say 5.10?
> > 
> > Totally confused...
> > 
> > greg k-h
> 
> These patches are applicable for 5.4. Will send another version with that
> fixed.
> Apologies for the mess.

Please resend both series, as this one I already dropped from my queue.

thanks,

greg k-h