Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 16:19:41 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org,
        bhelgaas@google.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        dlemoal@kernel.org, Yang Li <yang.lee@linux.alibaba.com>
Subject: Re: [PATCH v6 8/9] PCI: endpoint: Add PCI Endpoint function driver
 for MHI bus
Message-ID: <20230607211941.GA1176583@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230607204923.GA1174664@bhelgaas>
Precedence: bulk

[+cc Yang Li, sorry I didn't notice your patch earlier:
https://lore.kernel.org/r/20230607093514.104012-1-yang.lee@linux.alibaba.com]

I think we can squash this into the original commit since it hasn't
gone upstream yet.  Also note that removing the dev_err() apparently
makes "dev" unused, so we'd have to remove that as well, based on this
report [2].

[2] https://lore.kernel.org/r/202306080418.i64hTj5T-lkp@intel.com

On Wed, Jun 07, 2023 at 03:49:25PM -0500, Bjorn Helgaas wrote:
> On Fri, Jun 02, 2023 at 05:17:55PM +0530, Manivannan Sadhasivam wrote:
> > Add PCI Endpoint driver for the Qualcomm MHI (Modem Host Interface) bus.
> > The driver implements the MHI function over PCI in the endpoint device
> > such as SDX55 modem. The MHI endpoint function driver acts as a
> > controller driver for the MHI Endpoint stack and carries out all PCI
> > related activities like mapping the host memory using iATU, triggering
> > MSIs etc...
> > ...
> 
> > +static int pci_epf_mhi_bind(struct pci_epf *epf)
> > +{
> > ...
> 
> > +	ret = platform_get_irq_byname(pdev, "doorbell");
> > +	if (ret < 0) {
> > +		dev_err(dev, "Failed to get Doorbell IRQ\n");
> 
> This dev_err() causes this new warning from the 0-day robot [1]:
> 
>   drivers/pci/endpoint/functions/pci-epf-mhi.c:362:2-9: line 362 is redundant because platform_get_irq() already prints an error
> 
> Maybe we could drop it?
> 
> Bjorn
> 
> [1] https://lore.kernel.org/all/20230607163937.ZTc-D%25lkp@intel.com/