Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 14:16:55 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Gerd Hoffmann <kraxel@redhat.com>,
        Junxiao Chang <junxiao.chang@intel.com>,
        kirill.shutemov@linux.intel.com, mhocko@suse.com,
        jmarchan@redhat.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, muchun.song@linux.dev,
        Vivek Kasireddy <vivek.kasireddy@intel.com>,
        Dongwon Kim <dongwon.kim@intel.com>,
        James Houghton <jthoughton@google.com>,
        dri-devel@lists.freedesktop.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] mm: fix hugetlb page unmap count balance issue
Message-ID: <20230607211655.GB4122@monkey>
References: <20230512072036.1027784-1-junxiao.chang@intel.com>
 <CADrL8HV25JyeaT=peaR7NWhUiaBz8LzpyFosYZ3_0ACt+twU6w@mail.gmail.com>
 <20230512232947.GA3927@monkey>
 <20230515170259.GA3848@monkey>
 <20230516223440.GA30624@monkey>
 <20230607120312.6da5cea7677ec1a3da35b92c@linux-foundation.org>
 <20230607205310.GA4122@monkey>
 <20230607140001.6685b0a058511f125a005da4@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230607140001.6685b0a058511f125a005da4@linux-foundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gs0lDhtLX3thdsDT98MgcIEv39wmiPKAyKA32X4PPpA1/Yub+BLcIBK/avIW?=
 =?us-ascii?Q?1Ai3GIAhJA29XyyyWVbO7ryKajPZmnfrtzfAVJtYiC8mltNenNJ65BHfnhDd?=
 =?us-ascii?Q?SLTv5EmrCj/r8C8qh4Rv0UYeFAkylZ07UU4j976X6MKtA+1AHAFtG5bm3X12?=
 =?us-ascii?Q?63cKnWwOBhmjNaMUR6FOouwCp+pVOn7ePqbtBvSjcEWaetlbMrTOnu8LwCOV?=
 =?us-ascii?Q?oVBQggOaDPwJZXx0hra2bL/x7jb6Cn38tHFAtRCIBGD4Xdtz2jsorke95/qc?=
 =?us-ascii?Q?9DbKMNgo3as6isxB/Ttf4OW7LJw3EJDWh2nL5pv9/6cUjmVi88mjCLzCdkmz?=
 =?us-ascii?Q?pm53I7ZMl63cCEorDGC/w47iHP5q8oErL3qFNvuPI2s6/Bo3GmR0xOQnLo6N?=
 =?us-ascii?Q?PfxwsZvcpXi0teVoo90f/Kfa5ZTQMqEe9eH3U8QEURtxJ+SjFx7srxIZ23Wu?=
 =?us-ascii?Q?c9RjiLSmDMstqLk8x5KwQEGHyWme/6GmyQ6VGudaD2YtivX+1doPXHK9hWq3?=
 =?us-ascii?Q?JWYMVSwtgj8KvCuRY2DDP7CCtAB29bQ30BATa3kfpSfqi9uYLzKKTs61DC3W?=
 =?us-ascii?Q?ZqCaVOoNudfMY+L5AZ95peskYjkyu6lrVrLGhm+Fg6Fa0fImB8VBPlDGh9HU?=
 =?us-ascii?Q?cftkjXxL2hcahizdRJfXPUUKz/VacII24j3twK/v5+G8ZfMyui3P4dVR7cpP?=
 =?us-ascii?Q?SY/Q1yv1mpyQRBZEIWjfgK9A+Ih4RIvhZWgfeybbfVLCdo66Hqu43fSWgkMJ?=
 =?us-ascii?Q?ku6aBOiJFRGej4ax1UPqvRS87Gq5VLGPNiehDvpl2ss0gqY0IlcPjqe+QEq5?=
 =?us-ascii?Q?dk5MFsYpm3ObrUNnHtERTU0PJleydWo44/hZhcnjUspsocBvO2pEYYZDa5MA?=
 =?us-ascii?Q?lZBNjyffwKF9aaN9k7eT1g3KtVM9UFTZZMO1zetjjFp6/50shQ22MJzgJtrP?=
 =?us-ascii?Q?8jcUwGr6LMUbDUnZEmG/I5rOeaMUnSaXJR+hCGtD+ASMgL3D0Cqycyeo7xN2?=
 =?us-ascii?Q?dMVpfQW6etgb1lbPctnCS0VR5NU5F7sfhMQplKtzn8lEd+ymGXNNmKQiTK3M?=
 =?us-ascii?Q?Tj3ug3MxvL8MeB2ijxFWqeok39Y+1jbducXTaxPMXk3e3eQJDyG6ksSecW2W?=
 =?us-ascii?Q?2+f09NhvGicnNXjp1zTLZTSHpKGB+xQTpcinuz/sxTwX/VI93ZeCwQfDpZn+?=
 =?us-ascii?Q?aaRBCatfmAZ+Q0zuzEEllDC5dCsrxREYoNVVdSOmVfuGyts6MWLhVKTvNd7r?=
 =?us-ascii?Q?TD9leb/LB9KGcWUZkuqSp+TdhggBuOjwux/RnYx5KRSrFEvC04hOEdyMidlz?=
 =?us-ascii?Q?MotsItQiJjYQQVnGv01ACQqIjxwAQEUjpSJ+YUvz74S2ezcZqpsJOPk3mGYv?=
 =?us-ascii?Q?0LN1ONwmHEJKc0IKW9WbyJMIz1x3wWvyPE44zrhIu9zqdsM7BlK44b/30LY1?=
 =?us-ascii?Q?ysYIRRVO+LkKygppi+4gMPzCuBrsRnvSKBsJrwlsqpPNr2ED4ggX9Tag+JK6?=
 =?us-ascii?Q?zE0hObFdgGpzuuLXqXrc3xdOw22vsK2GwfoSO0l6LxJjAuEmBrqCxZJvV8yD?=
 =?us-ascii?Q?zA6qe7KSmmPW+e7iDQXnEw6/F3fT/5hV9wwV3a+2uzOKWGUc1WxfV64JDFR5?=
 =?us-ascii?Q?iw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?fnT1R+ah+6hd2poJ9E8kxfs8XcuWKbPnh+4KE1cRoXoDaYuQyIw4pU7tgJG1?=
 =?us-ascii?Q?mGzptkKmTgHZyr8MFYozOS4pjB4FlDHKq6q8HIXkev6A46aAtMDKay1xEz1Z?=
 =?us-ascii?Q?MrfN7QJgG0OCzOf+pYnb/TLG2OQoH5mQi8p7OT8vGqFhdmETa39Ldu02S89U?=
 =?us-ascii?Q?mWhTuGZMqj9JivyhXGJ7IBLzLLE7vVIEyB78Xv1uaQlEUAVcbP/vioBL+QvJ?=
 =?us-ascii?Q?FrITlvRk08GhdGz5prroT7udU8KSLr6FxCGB8lUilZmK1IoiBkcrvL6g55xC?=
 =?us-ascii?Q?vFHl61fMvocFAdMVUVfLdjoARr+ycaiobLE6EbeE/x1N3qPbcZfo18phEBQX?=
 =?us-ascii?Q?jsJArwJBJrbYan9myTcpESiWx6LEO/ACNGtfhJUZsSkkFxIddkQ6B2Wudzqz?=
 =?us-ascii?Q?NyOmW0Fk6DMuUfh8vUEgqQrHM4VC4dD6UXygGgwp+BdAqT8IVAtH0jnIBCfB?=
 =?us-ascii?Q?Rsus3OE5WdiKbjSvIgkbBJQWk/2yE0JNvQtPFWgvW5A+9pl/QdPzz1bqKalN?=
 =?us-ascii?Q?lPxYHJrAQ3GFjKtTUOyhsLZVjnQJNnUTRZXXU9K7PPDfLlRkMC7hVnE+go4Z?=
 =?us-ascii?Q?GXsEkDwzjQ7owD2c51o7B2zQFM8lekPDkRZQwHwLYHftpGpSDK7uRy7y3CsX?=
 =?us-ascii?Q?kQaKH3yc6ueKhtN648doN1PpB+30V2hdZoFjWcgHhPIjGsI8fkyNbRNeJj+n?=
 =?us-ascii?Q?paWF0KQYPw7bkivlw+9OKF6/HRXaeUzCZmKb+rixPfxeKMjarZzAzBrShKdw?=
 =?us-ascii?Q?gbI2GSGnBpqqRzDX3kq3RM672tqkI5vIOpeAFzlF/orrWWJ0JZm1COpX1NTm?=
 =?us-ascii?Q?9lRFJTX7ftKV5PktFN4S/yMGFBFlu0TT0F+fLeC4uZnoFAx1lzB/gDQBSnES?=
 =?us-ascii?Q?PXOSBP6kpC32G3uagVMv0NN9bqq6NPPjBeSAngfqZ63JP88e7MPh9KGS9dCd?=
 =?us-ascii?Q?L2RvIj0+EhexwMhNk4odXLiJ3nLjRho0jB5B6ZMSQkFb+5nX1W3jAbUfHJcX?=
 =?us-ascii?Q?aP/UbmuSBlMkOJVYG6GT9SlRHkr6tc9D/JAJipSVPNq3CLJ9/2iTcHKdRad6?=
 =?us-ascii?Q?FAVDEpRa5oRjA+JeK0jVyr5HueyN0Tq+cwfzS8Q6fkbehh3xVdVJwUMJQyyE?=
 =?us-ascii?Q?5O6F0MuFc9tO?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c44dafb-e39a-4fd0-4df2-08db679c8786
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 21:16:59.0643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HE7DDaCXuAL9thsfdqyp6F1jC2RsuAyN/a9WocPOoC3h2DUBb75uSozGaeWYEssVGJjax5wmyoVa5opBTkwKUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4806
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-07_11,2023-06-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 bulkscore=0
 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306070185
X-Proofpoint-GUID: HlSc-Oim8cU-HPMvDPWDzNnOqTg7wyUE
X-Proofpoint-ORIG-GUID: HlSc-Oim8cU-HPMvDPWDzNnOqTg7wyUE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/07/23 14:00, Andrew Morton wrote:
> On Wed, 7 Jun 2023 13:53:10 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> 
> > > 
> > > BUGs aren't good.  Can we please find a way to push this along?
> > > 
> > > Have we heard anything from any udmabuf people?
> > > 
> > 
> > I have not heard anything.  When this issue popped up, it took me by surprise.
> > 
> > udmabuf maintainer (Gerd Hoffmann), the people who added hugetlb support and
> > the list where udmabuf was developed (dri-devel@lists.freedesktop.org) have
> > been on cc.
> 
> Maybe Greg can suggest a way forward.
> 
> > My 'gut reaction' would be to remove hugetlb support from udmabuf.  From a
> > quick look, if we really want this support then there will need to be some
> > API changes.  For example UDMABUF_CREATE should be hugetlb page aligned
> > and a multiple of hugetlb page size if using a hugetlb mapping.
> > 
> > It would be good to know about users of the driver.
> 
> So disabling "hugetlb=on" (and adding an explanatory printk) would
> suffice for now?

I can put together a patch to do that.

-- 
Mike Kravetz