Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b794bccc-0233-4d78-df6f-bf7c688a7d7d@ni.com>
Date:   Wed, 7 Jun 2023 17:07:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RFC PATCH] pps: Increase PPS_MAX_SOURCES value.
Content-Language: en-US
To:     Rodolfo Giometti <giometti@enneenne.com>
Cc:     linux-kernel@vger.kernel.org, brenda.streiff@ni.com
References: <20230605203147.694716-1-charlie.johnston@ni.com>
 <fe435e68-8e05-9078-0fe6-63ef7cce2fc9@enneenne.com>
From:   Charlie Johnston <charlie.johnston@ni.com>
In-Reply-To: <fe435e68-8e05-9078-0fe6-63ef7cce2fc9@enneenne.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3BRUmtIckk3WDlyZituSzZxb1dwMzdYYWdkMVl4QXJlOFh2ZVloWjRJLzVz?=
 =?utf-8?B?RTFnRTBONG5mMmp3d2kyVTgydHNNcS9ZeER5MXdrNmNHcHNFU2k3ZE9qeWF3?=
 =?utf-8?B?SUNPbXNvYkE4S2Z2RGdydVlvNS95UE9RWkdIN2lLOW56VlAwWXRoRE10OGIx?=
 =?utf-8?B?V09qSm1BVkRpWE81SEFVMFcwd0w2VGY0dlF2VFBpaEhPeVZtTHBJMkx0TkF3?=
 =?utf-8?B?N25XL0c2T0Y1c3o1N01palJaRDVMMVFyUFlHUnpRTHFkblE2dGJpQ1JOVk1y?=
 =?utf-8?B?aWhlT1A3c2hHVWZZUUl6S0MvcDdIcVJ6aWVrWk1hTVc2MU9ZZ0ZiNnYxMWNK?=
 =?utf-8?B?SEVJaFpjUEVvL0w1U3NpRE1CdUZCcW0wQnlYaFdoeHdZRU56OUJCcjhrK1JM?=
 =?utf-8?B?elNiNmNzUWhzU2VzMVEyOEpEaUFRaTZvTzVnWGRCUjhxYkZSeXZRb0JjMXV0?=
 =?utf-8?B?TktwRjdMTXJVdERhRFNUSGkyVlNRZGx1SHBPakJ4bmxEYlU3ZTg2WWxCYk1z?=
 =?utf-8?B?YktNUHU4cDlpUGZ2ZDdBWkNmZnZmb1hVTFVHNURtRjBOcWFNaVNYM1h2c0Rx?=
 =?utf-8?B?TUEwY0ZiRFVpSFVaSHZZK1VsMUNBb3pVZmMrS01oZk9MUnlkUVhMaHBrMUd1?=
 =?utf-8?B?RzNnNjU4S2prMTlOT0xvVzJLamY5Y3gzQ1VmU2txYXFLMkFod1JmUUNBZVRS?=
 =?utf-8?B?aDdhS2lmSGNhVm5XZFBDWEF1cWV6aWJmK2x5Qm5LdFltYjFUTTdvTm1hdXBU?=
 =?utf-8?B?YVFXOUdTT0hHV3k4dktmK1ZpOGhLQ3FUcW13VFF2U05INzlGZEdFamsySE5U?=
 =?utf-8?B?RUJlU0lYbXRodnNMZDNoblFZeGNIQTFSY0pvYmxMZGhPY3o2WjVnNjdCS2FV?=
 =?utf-8?B?eCtJV1EwN3lHMGZ5N2ViRWR2QXhBaUFodnlnZUVUNmkramFCaW9Wd1V4UWRj?=
 =?utf-8?B?ZmhBODdrVHkvd3YxMndmV2VzWHdmTWp5RGNyUDQ4QmZNSWRmVTFqQ3BkT0Z0?=
 =?utf-8?B?U3Z6Ni9qemdiNndxVTBxZXFtT1ZVOGNVajNyS29SbDVUbmpEY1YyZ0dJS1ZW?=
 =?utf-8?B?WGFoSFNraU1sTTVhTUFyYkFMeWlVanVQMVp1OXczTjJ4WWdRbWVlSEJLMitV?=
 =?utf-8?B?T0xSV2NXSit6ak5rSkF6YmxNSlVKeGYrOERqQkFpWklZZUpHRmtvQ1IyeWN2?=
 =?utf-8?B?S1hVWEhFRkZpSGxGTkZuS2NrT1pqckFneUtZTUpNYmZScjdYR2ZSR2tuaE9z?=
 =?utf-8?B?dW5HeWEwaGF5MkoyTDVQV3pyZEQreks5bnBFWEZtcTliTXN4N0YrY0JCVmFs?=
 =?utf-8?B?WktUZzJZUk9qTkpoMHhxWGJqRThPVWhMcjBXR1NNcHF6K1NMbllHYTBkc1BM?=
 =?utf-8?B?VGh5bGZBK1NqMzB3ZzVuUW5GTklZMGM5YStaR1Juc2wveDIyVDhsVzc0RW1q?=
 =?utf-8?B?QXQ0eUwxa01rbkJDOGEveGtoMllmTzZKWi94QXlIeWJndVUxU0FxeGxJbzNx?=
 =?utf-8?B?QUlwb1lia09YalJhdGYwd1hMWG1zYXZBYVlnY0s0NTkwR1ptYVpZclZSNTVF?=
 =?utf-8?B?cGlPWEFLZkM3ajBCSEo4L09wbThZYUNzUlN1d2tacGhQdVVieDZFa20zeE9v?=
 =?utf-8?B?OElKd0V0RWN6T29DejZuM1Y3bjFyaDErbFlrVURSWDVVNUxTeUdsOVBxSTNo?=
 =?utf-8?B?M3lNeUtCeDlMbmEweXJ2MGJacDlPZmdtQTN2cXJ3aHdNbENZREZsQUNzMThT?=
 =?utf-8?B?d3FsbHU4QnN6bWtOU3FjSWpWOTV4K1dZT1FZWjBDZWNtaVZ5UURLRGd6ajF1?=
 =?utf-8?B?MjVWU1FoOXhPelorQmRvd3dhRzZ4VE8vK1ByQ3JTSVVyV0RDV1JRdUkyM1dt?=
 =?utf-8?B?SXdZaXlkUlBXTG1tRW44TC9MN3I5VSs3bVZ4VUlJbjIyWHZId3ppSXc5b0VS?=
 =?utf-8?B?dzJmd1VvZXNoSjJkcWp5enV2N2ZIcTFYcGQrSmRUMHA0QzU3VGN4RCtCWTlw?=
 =?utf-8?B?VitmRjFwMy9NQnpLWDdFU3pnOUVmdHJTckhLcE1oeU9pb2JHOHRtWmNnSUFl?=
 =?utf-8?B?TVhkS3JBQXJ2UllLOEllMHVuTkR5WHpXdjZSTVZBd3RpYTJNNDc5cldNR2JM?=
 =?utf-8?B?MVJtR09IRzBaUndoSCtBVXNJTnExemxCTkpJalNZazI4WHppaDEwZCtOZUJ0?=
 =?utf-8?B?QlE9PQ==?=
X-OriginatorOrg: ni.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5148391-a9f0-4a1a-4894-08db67a39c97
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB4879.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 22:07:40.9128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uz6z+awCawEII8U0bDHxeuBBOURI52A6mGBOKZOSJfg56FCMapl+0+3OdRWX7mNDtB+ulJAhaY3UNXkFjKnRWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6928
X-Proofpoint-GUID: NPF67gRx2tnFXjNa2L7K7O4qiP9sfyCq
X-Proofpoint-ORIG-GUID: NPF67gRx2tnFXjNa2L7K7O4qiP9sfyCq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-07_11,2023-06-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30 suspectscore=0
 phishscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=921
 malwarescore=0 bulkscore=0 mlxscore=0 clxscore=1015 adultscore=0
 priorityscore=1501 spamscore=0 classifier=spam adjust=30 reason=mlx
 scancount=1 engine=8.12.0-2305260000 definitions=main-2306070193
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/7/23 02:33, Rodolfo Giometti wrote:
> On 05/06/23 22:31, Charlie Johnston wrote:
>> For consistency with what ptp uses for minors, this
>> change sets PPS_MAX_SOURCES to MINORMASK + 1.
>>
>> The PPS_MAX_SOURCES value is currently set to 16. In
>> some cases this was not sufficient for a system. For
>> example, a system with multiple (4+) PCIe cards each
>> with 4 PTP-capable ethernet interfaces could run out
>> of the available PPS major:minors if each interface
>> registers a PPS source.
>>
>> Signed-off-by: Charlie Johnston <charlie.johnston@ni.com>
>> ---
>>   include/uapi/linux/pps.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/linux/pps.h b/include/uapi/linux/pps.h
>> index 009ebcd8ced5..85f472330da8 100644
>> --- a/include/uapi/linux/pps.h
>> +++ b/include/uapi/linux/pps.h
>> @@ -26,7 +26,7 @@
>>   #include <linux/types.h>
>>     #define PPS_VERSION        "5.3.6"
>> -#define PPS_MAX_SOURCES        16        /* should be enough... */
>> +#define PPS_MAX_SOURCES        (MINORMASK + 1)
>>     /* Implementation note: the logical states ``assert'' and ``clear''
>>    * are implemented in terms of the chip register, i.e. ``assert''
> 
> I have just one question: are you sure that it's safe to call idr_alloc(..., 0, (MINORMASK + 1), ...)?
> 
> Ciao,
> 
> Rodolfo
> 

Thanks for taking a look!

My understanding is that idr_alloc(..., start, end, ...) can take any end value up to INT_MAX. It also handles any values <= 0 by treating them as equal to INT_MAX + 1 since the end value is non-inclusive. I can't think of any reason using MINORMASK + 1 here would be an issue since it's much less than the maximum value idr_alloc() allows.

A number of drivers (e.g. ptp) just explicitly use a start and end value of 0, but I don't think that change would fit here.

Regards,
Charlie