Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Stanley Chu <stanley.chu@mediatek.com>
Cc:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <martin.petersen@oracle.com>, <avri.altman@wdc.com>,
        <alim.akhtar@samsung.com>, <jejb@linux.ibm.com>,
        <bvanassche@acm.org>
Subject: Re: [PATCH v2] ufs: core: Combine ufshcd_mq_poll_cqe functions
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1pm664v14.fsf@ca-mkp.ca.oracle.com>
References: <20230601225048.12228-1-stanley.chu@mediatek.com>
Date:   Wed, 07 Jun 2023 21:12:15 -0400
In-Reply-To: <20230601225048.12228-1-stanley.chu@mediatek.com> (Stanley Chu's
        message of "Fri, 2 Jun 2023 06:50:48 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zX/B4xBWhvJ6U2SoUN69KMvjjgQiQbI5bK5kMFdqbhYdyHFp9bfZFesmzqzm?=
 =?us-ascii?Q?U6XY85UVUa5aGH4vT3yoDAnCAPsJSd+vNIJqn588tW62D4oiyz5P2oW+9xC0?=
 =?us-ascii?Q?BCK/qOOOEAmI2w0AN2c6SQ804YUxM67rzX5h5U1KiWbhwz2iHJcZKUnuvazY?=
 =?us-ascii?Q?r0nZf1rpnnPctX7oYoh58eVPPhawijNb4xerDn4UZlrce9w0VS1nRMXJVNks?=
 =?us-ascii?Q?GzoP5VgnXn7k5GdLZvv//ZVokOwryapthGA8/dWwkV9vRZtUoKOf7llMR7Fy?=
 =?us-ascii?Q?E38ZHEuXs86fJ9e4cDdHI+L4ConVuVkRQ0WDmIQAO6mErDHgQyyr0gdZiP3F?=
 =?us-ascii?Q?Id3gAE3DYFwhDsG/wA5CKvntUbOJHPuDiKGAVFAZ6MDP+ogPoaXSS7DycMaZ?=
 =?us-ascii?Q?emrToNxJ7CUbGeT2/czeoHSckd782P99YfM9TgF5Wn7YsTj4GExsrDBO8Zwd?=
 =?us-ascii?Q?nt2BLSt/cvy7S2bCD6V6NDHrlwkAmR4MSoLmMYeKjDhvqOYYs7vuTRiOpOyZ?=
 =?us-ascii?Q?niVi/Xi9cTLeAFjSF1Miw1FAWlIdoRCaucZE/sPah4Z7mA9rzgK51/Id1dDV?=
 =?us-ascii?Q?/Ub7753K5+Q2hVevx8VM+qPZQ1AI0DgrAPgAFnfJ+E2GJBSEwwLfbDavXiM9?=
 =?us-ascii?Q?9uM8eJtiV2MCinaSYyzOCsHmUaM6Cgp3k0cqyzj1JDKCEc+iZ+KoDGcAyE8d?=
 =?us-ascii?Q?1GdjyUbf3iYOKK79CJijnDy5nDMPOzyWyJzK6vY9XXSmVarsFmT4hN/56Sup?=
 =?us-ascii?Q?DDFzV0QzS+Ou+asiUrXJHpbodA4M9z7+2EZIqRLdeBuF3Bl04j5d/5eZHtDH?=
 =?us-ascii?Q?LjGEBQCOh115PcG10dbh12UryCq13BadcnANFCof5E5pAarHE7ZiOGJ02uHA?=
 =?us-ascii?Q?Q1vbda7esgPAJyYtTi+AnVcBqbM7Zcv0y280AprnA/pwNaxk0kdipVhvTbA3?=
 =?us-ascii?Q?EYJRwZPNH6PIG3BBVzBgW+/T8TIYeqKcRls6xZ557kiRqWMMLOBp5Kc62LTX?=
 =?us-ascii?Q?ZN6pyWDt7iQL8VH1+Xmmm3do9cie5HIcf8i3xMpcDKiEKCYPC/AEhxOMVdw2?=
 =?us-ascii?Q?fuqNoeaJr5uFZC5BXwlNy7ILuH4Ys8jN5GXuhfZX2sHOcd6Ng/FKNSs0GjfC?=
 =?us-ascii?Q?8lzDxXagUvjZBJ2Lf405xgGYl5nYtNtYjQgYD/5aydEXcAaVXsBqs0zK9DtH?=
 =?us-ascii?Q?C/14FqqOyZ74OiV2HIpOo+RpXyYw6sl5tuNYG+TyYeJfw6GZP/GOWfKgXmMC?=
 =?us-ascii?Q?0HcvcQS0q48OAL6/b1ibyCg7B0onfbbQY2L+Mao8cMEeRWJy2dAO80wi/OEr?=
 =?us-ascii?Q?bcKrS+tgCZGfR8J/Vqsx6U1PpG8fc5TNo0WYEwSbiG80PWzxRIHVnUtE0OQ3?=
 =?us-ascii?Q?p9ifZw+lKfxbb42znq2fwhkczkjyDhw5Ot+56FRslGO+QwPduC9wMviRAU7V?=
 =?us-ascii?Q?pYfe7xnjmG1La3NsVVfxt1AEgVHlZdQf6T6nKZVrnYhElPGGSQt/ALVAR7Iv?=
 =?us-ascii?Q?rc0T1efEuM5V+YHwnb7++VdrtJy6p36Ot9Z8J/rph0aIgVgIcQISSrRrzuty?=
 =?us-ascii?Q?nPPNvKOGofKsqF1OSKzEFNSRyI+M6w8u6ADa7CKx9Il/3MO8/g2Lli5wA4p2?=
 =?us-ascii?Q?mw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: sfNgeYuIExm2+XasqoCAVvOxiozeS63Ory9h7Iygt/a3Dsjy/+lcLf0Hc3HI6EnMBFMwD39chfg9VObZro0VINKEJ4Fw7sLa4Fy9jRT1TPi/q3oskMXbjrr0dFm13wN8TCiOYRBFWcUPoI73HMnGAEKgw/k14U2rrU+UU+J5EYOAN5zH7xUsQoJZvxyDYxVyuE52InRmLxHL1vVQKg5IlDvC/wfZVe1TEouAYK2EuvhQI2Fk8++zotW0zgL4c6AqSBmXxuk3FRoZbsN9zOgZfJDX2I93YMNwP3kOGPELYWn3QfJEGpN+9DSIEnQKjslM9pDShGiPqbV1yc5KhGLEhjU2CvRHS6HO5CYM9a6sszjcRAX61ABtOmoFYd1Ik9m4ngig9nEk6jLcHtRoRumABJZpU7Kmkpmcs4M8RITXyKoTs70HNDQes/CU6hrN1HHzNBBQisuJ6nAo5nQDCNS76jcV+PC4C+FHCfjdJNQiRbMZJKfZyvoc36v9dYiQUqz7bJaZOoiSjzKDrAtE8+psydO3Iide4na8f1xDdLMGbWqx5nl0UdmtGX9NvirmCF5kOg0+gFIpAPvwF8C+VytguagRd1G7Swit7WoAvmPDWt8ahjkNK0GD0No2NoE5wpMO9XMksHAD9OOg2ZhxPVMVivsukZ20DBnLN6ph+sWV+tR32iX/NFR9UUR1uZ7zzbqPjTxjF6zAVCf1XHL1eVqv+MwT6oPG/jVSb5tuA6tgE/+2Qy8ZjZYl/pZ+nQ1nJ7LzqI/ozz81Zww3bQfZ2QdXqV/ob5AWt97IqKNhNM9be1rv3kGL7NTrvD5cl5c8z/xhE6k+hKpfr6odRSYEKlWJ1CyYNp3gi6NlqcXYpBma70Ko4MQBJH/4yj6hXdJfsuBUuttRpG2bhl1+UpDx5DuFjA==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 580cf749-9832-479d-a3eb-08db67bd6977
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 01:12:22.0926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oCDFa0zZ80/dBZRmIMVm9sY8MQJuxTAfQFEWQL8zMgWXE6PyMyeoXE7oOBIvKZ0y/1greEsjQb86F2EjeBPo4Vp9qLAtqERRhbn0/7HTFDM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4547
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-07_13,2023-06-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=762
 malwarescore=0 bulkscore=0 adultscore=0 mlxscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306080006
X-Proofpoint-GUID: EyBvwDctXwhAj9Wuvb5LKlHRkRpEJgc1
X-Proofpoint-ORIG-GUID: EyBvwDctXwhAj9Wuvb5LKlHRkRpEJgc1
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Stanley,

> Currently, ufshcd_mcq_poll_cqe_nolock() is only called by
> ufshcd_mcq_poll_cqe_lock() with the addition of a spinlock wrapper
> for ufshcd_mcq_poll_cqe_nolock(). Combining these two functions
> into one would result in cleaner code.

Applied to 6.5/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering