Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Jun 2023 18:11:54 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        Terry Bowman <terry.bowman@amd.com>,
        <alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
        <ira.weiny@intel.com>, <bwidawsk@kernel.org>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>
CC:     <terry.bowman@amd.com>, <rrichter@amd.com>,
        <linux-kernel@vger.kernel.org>, <bhelgaas@google.com>
Subject: RE: [PATCH v5 01/26] cxl/acpi: Probe RCRB later during RCH
 downstream port creation
Message-ID: <64812ada79a39_142af8294e6@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230607221651.2454764-1-terry.bowman@amd.com>
 <20230607221651.2454764-2-terry.bowman@amd.com>
 <648128e846a9_142af82947c@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <648128e846a9_142af82947c@dwillia2-xfh.jf.intel.com.notmuch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7a8IZmnuzBQU45itztsOaE7YdTPRJGi/FF5FSM2nqiSkUud/Zp0fWqr5pRIP?=
 =?us-ascii?Q?JkYRnScTNm5cj+15WhtLzN5PTzO3ABI6rXHuY4PeYuIwLDtiHNSjlKtJEOzc?=
 =?us-ascii?Q?NIB1ekReBMtqO1/+Ioq+M/Eu11XATUZcM4lC/BAkfrgHjibPe+cAA1acJF8z?=
 =?us-ascii?Q?9I99cxi9YtmGoTITy/Sps7aA2dzQ46FF0P7n2kjnxT6rZrcCuwK9vOOdOiOn?=
 =?us-ascii?Q?9UGzjQ06Yx9TgkCNY9yqNDDHiYwDVp1T3bncEMUGaZMvC0iH1FAJ9v17cyIz?=
 =?us-ascii?Q?LgDsysbzSD1XytCCDo45Zk+ZHLgec4UudfESZnxl/QCgGmgWXahZ/SZJLOYk?=
 =?us-ascii?Q?t2m5hUKuWodsSdhlAn6mtrQSwRv4OOSyMLJo14euuK/l116RvA5jYDd4p65F?=
 =?us-ascii?Q?Q9q8OKrvvJhkA+OWA9U5c8GPwawN1LU2VNJfomvqigpLUR7+u89Mkhub8Bzy?=
 =?us-ascii?Q?5ypZ7plx6RHrL78eFngoBP4KA+FfRSl9QSMkbFAW/3NrajWlt3ZPR0jZe628?=
 =?us-ascii?Q?Is33bOhDrSF7PgxHndFKVZdUgPf/Buls64W6PfYlkCZ+k2cdj1Lxe5HJFogz?=
 =?us-ascii?Q?DwQ7GKSAIVPsUDldV2wW/U39stl30rzFOB9eEpdVIyJ9zsYa4r9woVepBD/c?=
 =?us-ascii?Q?kIDuLL3eNC8X5vh4DfWTKJs1tRLIXJXqDLYfCdmHvc/+Y8B2yUuOkYssWE93?=
 =?us-ascii?Q?WWWf3haXP2wMcEqB9+Y+/DlNL//oDwwaIjVt/iPUH1LZkuhebSNAMQi6+N5J?=
 =?us-ascii?Q?Ebgr6lop1SUwrlwVJk1U+K+SuGt3AT497B7iktKnqcf6yj6Cww3xKf+RYUJ6?=
 =?us-ascii?Q?GIqjtJ2jNyt4o8uacxhTNsJb2nRhP2XymXjzc8uiJSZ1c6a7lr4jMd7fUHdT?=
 =?us-ascii?Q?Aut0EkCwaSHIOGlKHLWwkPkHukr6Rf2jlsql/uc0hupqtbop8BoLuWCb3Bx/?=
 =?us-ascii?Q?+jb4F6yF9oD0zUeX1XZCZ+91r1cbiJsfB3nHQNxBp15ZDcSmc3HDgjrCf7C2?=
 =?us-ascii?Q?uZpEQi5hp88tlIM9zbBhwg88APamwpr/9icB6KNpun9wt4ovkThF7tAr/Kzw?=
 =?us-ascii?Q?KZH7XUGjo94Bo4nqYya/B0MXBW+HMNuEHUSGG1Rjc46JazQR7vVU9Htd0r3E?=
 =?us-ascii?Q?Ij0AlKX0ROf2IBgpjz+FzWn4SX4qth0KRFcWX7zecfEWpvFhXJ6/Noi/H7ak?=
 =?us-ascii?Q?WXdaSyN+9Kgzd+nukAjlD1ypSQ5ZkI6/OsitVuFh/HCiRvUy0JaYuhoGF415?=
 =?us-ascii?Q?aIyWFUuNXy7HgJhbdgJcQ5a+4nk5waFT2ePd+EsZ2HO4vq5vz+Z9M5knIWIy?=
 =?us-ascii?Q?1Xp8rQutguFDmKRTOWQjTacy5AFSp3jCX3uPW4nKJaiY4mxPYTnWAyp53VdT?=
 =?us-ascii?Q?oecbbRtwNHyVXpNtL5pwCRDPIEkeYITggRFXw2zU/f1691TB1qBYlGKs0ZYy?=
 =?us-ascii?Q?q0yJvMPTXMpIEM1dKJsVqts6tZOc00gfHLlC68yFpI+nM/w3hDsnkzOw7Fb9?=
 =?us-ascii?Q?xpQ8vkU4fKqbIVF3SNbzGZ10qPe2v0fs8kpI7MaMIRPFfYAojM3e+ytNl/Uu?=
 =?us-ascii?Q?LCv4LHdDhmLhxfEhDSDCxKCRHQMWUPrV2iSY6LNmp6tJD9D/gaN+gp2e0z07?=
 =?us-ascii?Q?YQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6919e2f6-3217-45d3-cdcf-08db67bd5aca
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 01:11:57.5410
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ECZlhfXuiA7YTShMLFLKT07ebzpZPLa2gwii2V13Zw7cBIOBZvXR9M65gj/EmwJs6RKoe70gp0Aj8Emv7ZDi1fyciClMZ6kNXO1Btgt9Wl0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4886
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dan Williams wrote:
> Terry Bowman wrote:
> > From: Robert Richter <rrichter@amd.com>
> > 
> > The RCRB is extracted already during ACPI CEDT table parsing while the
> > data of this is needed not earlier than dport creation. This
> > implementation comes with drawbacks: During ACPI table scan there is
> > already MMIO access including mapping and unmapping, but only ACPI
> > data should be collected here. The collected data must be transferred
> > through a couple of interfaces until it is finally consumed when
> > creating the dport. This causes complex data structures and function
> > interfaces. Additionally, RCRB parsing will be extended to also
> > extract AER data, it would be much easier do this at a later point
> > during port and dport creation when the data structures are available
> > to hold that data.
> > 
> > To simplify all that, probe the RCRB at a later point during RCH
> > downstream port creation. Change ACPI table parser to only extract the
> > base address of either the component registers or the RCRB. Parse and
> > extract the RCRB in devm_cxl_add_rch_dport().
> > 
> > This is in preparation to centralize all RCRB scanning.
> 
> I really like the approach of this patch, the cleanups just make sense,
> the changelog is great...
[..]
> To be clear, I feel this is my maintenance burden to bear, I don't fault
> you for not using cxl_test, but I am invested in keeping it operational.

On to patch2... 

$ stg push
Pushing patch "cxl-rch-prepare-for-caching" ... done (conflict)
Error: 8 merge conflict(s)
       CONFLICT (content): Merge conflict in tools/testing/cxl/test/mock.h
       CONFLICT (content): Merge conflict in tools/testing/cxl/test/mock.c
       CONFLICT (content): Merge conflict in tools/testing/cxl/test/cxl.c
       CONFLICT (content): Merge conflict in tools/testing/cxl/Kbuild
       CONFLICT (content): Merge conflict in drivers/cxl/mem.c
       CONFLICT (content): Merge conflict in drivers/cxl/cxl.h
       CONFLICT (content): Merge conflict in drivers/cxl/core/regs.c
       CONFLICT (content): Merge conflict in drivers/cxl/core/port.c
Now at patch "cxl-rch-prepare-for-caching"

...oh, looks like you are trying to keep cxl_test going. I had stopped
at patch1 because that one already raised a circular dependency build
error:

depmod: ERROR: Cycle detected: cxl_mock -> cxl_core -> cxl_mock

Let me see what's going on here...