Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: [PATCH v4 2/3] bpf: make bpf_dump_raw_ok() based on
 CONFIG_KALLSYMS
Reply-To: maninder1.s@samsung.com
Sender: Maninder Singh <maninder1.s@samsung.com>
From:   Maninder Singh <maninder1.s@samsung.com>
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>
CC:     "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "andrii@kernel.org" <andrii@kernel.org>,
        "martin.lau@linux.dev" <martin.lau@linux.dev>,
        "song@kernel.org" <song@kernel.org>, "yhs@fb.com" <yhs@fb.com>,
        "kpsingh@kernel.org" <kpsingh@kernel.org>,
        "sdf@google.com" <sdf@google.com>,
        "haoluo@google.com" <haoluo@google.com>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>,
        "boqun.feng@gmail.com" <boqun.feng@gmail.com>,
        "vincenzopalazzodev@gmail.com" <vincenzopalazzodev@gmail.com>,
        "ojeda@kernel.org" <ojeda@kernel.org>,
        "jgross@suse.com" <jgross@suse.com>,
        "brauner@kernel.org" <brauner@kernel.org>,
        "michael.christie@oracle.com" <michael.christie@oracle.com>,
        "samitolvanen@google.com" <samitolvanen@google.com>,
        "glider@google.com" <glider@google.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "stephen.s.brennan@oracle.com" <stephen.s.brennan@oracle.com>,
        "alan.maguire@oracle.com" <alan.maguire@oracle.com>,
        "pmladek@suse.com" <pmladek@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        Onkarnath <onkarnath.1@samsung.com>
In-Reply-To: <CAEf4Bzb4B9FxMnf3t81D22FWkciLOvwDPLY0BbEPGGe7R5QPrg@mail.gmail.com>
Message-ID: <20230608031011epcms5p23c6aa244e514729b98df2af7e45db67c@epcms5p2>
Date:   Thu, 08 Jun 2023 08:40:11 +0530
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CAEf4Bzb4B9FxMnf3t81D22FWkciLOvwDPLY0BbEPGGe7R5QPrg@mail.gmail.com>
        <20230606042802.508954-1-maninder1.s@samsung.com>
        <20230606042802.508954-2-maninder1.s@samsung.com>
        <CAEf4BzYavyL431eA_HZ-X8+wTeO4Cyt7tGDUbPB0yqPru=ZUSw@mail.gmail.com>
        <20230607034028epcms5p8ed013806c42bd79b76368ac015a7b6ba@epcms5p8>
        <CGME20230606042819epcas5p4f0601efb42d59007cba023c73fa0624a@epcms5p2>
Precedence: bulk

Hi,

> > also as per below code:
> > (we were not sure whether BPF will work or not with patch 3/3 because of no expertise on BPF code,
> > so we keep the behaviour same)
> 
> I think bpf_dump_raw_ok() is purely about checking whether it's ok to
> return unobfuscated kernel addresses to user/BPF program. So it feels
> like it should be ok to just rely on kallsyms_show_value() and not
> special case here. If some of the code relies on actually having
> CONFIG_KALLSYMS and related functionality, it should be properly
> guarded already (or should enforce `SELECT KALLSYMS` in Kconfig).

Thanks for your confirmation, I will resend patches without bpf change.

Thanks,
Maninder Singh