Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <429589f6-d946-9bc9-d54e-e892d513a91b@amlogic.com>
Date:   Thu, 8 Jun 2023 11:23:46 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with
 zeroes
To:     Arseniy Krasnov <avkrasnov@sberdevices.ru>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     oxffffaa@gmail.com, kernel@sberdevices.ru,
        linux-mtd@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230605191508.1826853-1-AVKrasnov@sberdevices.ru>
 <9319a8f6-3774-0dc8-2262-8033f8016a50@sberdevices.ru>
From:   Liang Yang <liang.yang@amlogic.com>
In-Reply-To: <9319a8f6-3774-0dc8-2262-8033f8016a50@sberdevices.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmNET2YvQjczUHJ2TWczbGFkallnZmlIU1ZKamdKM1VyWThKVlJpRG43aU1K?=
 =?utf-8?B?UURhWnFRMkYyRlk5RTdyUk5zRUZ2eHFUT29uQ0VDdjEySHM4RmRGN2VuMnBv?=
 =?utf-8?B?TkMzSU1xUjRXL2NqZm1jZjErTnVWUVoxMnJ5TW9Ha1cvSmhPL3dBY3NRMS8x?=
 =?utf-8?B?SUh0M0oyRHhWSzFJdG5YSHpsNkJTVnN2ZURmWVVJR2hydGtaeTRDcnI0SzFT?=
 =?utf-8?B?eW84eXJiMyttZzBXQWdoR0J6QXhwaTB6bWFBczU3dzZkaS9VNmNiZHErWjRC?=
 =?utf-8?B?ZzNGMnFJY1RxREJFUy91alZuemZKZ3haMkFCUXc3S3U4Wkhacjc5dEwrMUlD?=
 =?utf-8?B?aHdwOEwrQUJUa0VveG1OQXlBU3VWdnVvRmhaejBaOVM3TGxJZ1FNYStoMmpt?=
 =?utf-8?B?eGxlbG13ZnpMelZOUXRxVGNOQnB1TlpRLzZlMFU5dE5jbnZ6cDJpN002Y0I3?=
 =?utf-8?B?YXNaQTBJaDJ3K3lYalI5TUdGM05OVmRVZWZHUStWM1hXTmFjR2NRdnhIV3RG?=
 =?utf-8?B?QjdXSXJGeTlDN0JPS2NmaTA4Yk5qQWlTYi9yYU9DQTRLWWxhcTFKbGNMOE0r?=
 =?utf-8?B?ZU1aem9LOVRpRW1YcURpcHNWVGxwSm5JVmNoeDBGc3l6T2xkWE1kd2JpQWVO?=
 =?utf-8?B?Qm80YnNOWFphb3RHdGlONlZmMUVWR1VPa1hPRUpUdFgrTFV3RjlxOEZ5bzBW?=
 =?utf-8?B?NHNrMlR2L3dwQ1ZGWUl2S25oeDZ3bkRYRm8rcFFiYVpYSHhDeVE4Wlo0Ukti?=
 =?utf-8?B?ZDF3a3UzYk12TU12Q1gzV1NydzVFYitYZUthQXlWVjc1MmJtMTdubmFvcUt5?=
 =?utf-8?B?RTEwMFh6MUIwUVQ5UVdWei8veWpta2I4UDFBSXpiM1RIa1Q4TnlZcnlFZFR6?=
 =?utf-8?B?VklVQUV5aTgyMmNoUE1oZTlSZXlPVWE4c1h4Q3JJbWZ2SERtMlFvL3JGc2Vo?=
 =?utf-8?B?dDhZVVdNVG03NW5aTTl6SUMxUDUxSDZQeVRpeUduSWpuT1dCRUFNd3BtL2cy?=
 =?utf-8?B?dWR5MjJZM2N5cHhXc1dqRWlhN2t3UEdVNDZ6MldlTzM1RExtK3ZuZ2hnZ0NK?=
 =?utf-8?B?VEh5eDV4OXY0MllFY3RobDNYOTFhY0IrY25vYm8wbzVCUnEwMG5JMWZiRTdB?=
 =?utf-8?B?eTE3eU9QOGNuc3NENnM2a0ttYlV5RVNwNDhFVlBqRjcrd1hIdWtSZG5ldzBx?=
 =?utf-8?B?RXNheFpmZmxibWhKYVE0dUJxWGFlMDV5azlFZVpXblQ3RjBoTUdQWFQ0ckhE?=
 =?utf-8?B?bXQ4Tk5LRythaUpwNlV1R0pWa1ZXaFh1MU9nSFJVMVVnRW01K2FIYkNHeWJF?=
 =?utf-8?B?aENjSEJMRXBsNHdiMTYxOEhvYW9hNHVPSWpvblIxUW1SdHRORDMwT25TYXR0?=
 =?utf-8?B?cnQwSjVYMDdzUlBhRmRJcnArSnJXY1lqRkp6MjBIREJNVE9TVDJYdXR2ZHZE?=
 =?utf-8?B?Q3d6Znpxa2tVM3pjejRxaWt4ZXFWL3F2RGt3TzhxNHlHaFpWRWdSbmdHVUw5?=
 =?utf-8?B?TWJ6NEUxWUcwaEhqVFVrUm1PY0huVWErUXRqYVhyUzI0ZGR2bkxLM2ZLQ2Jh?=
 =?utf-8?B?cDZCNGFSN3A3MGdxQjRJMlhQOWJLRUxZSldYWWJFM2l5RXg1Nnp1aDdyS2JB?=
 =?utf-8?B?SWtsUExJci9wcnZDQmpJSVpKVFNzV1RwUklraFFack5uMjhvNWlxODdSbWtS?=
 =?utf-8?B?V1NSNkhUMVBuK2ZYYTFvTUxJWlVaZjhUSHkvSThWdFJBTXpKc2NVLzZhMUM0?=
 =?utf-8?B?NWFGeFVhUjVOcWUvRGlOeEZNU2JCRnVZZnhhVHIvYnVhdmRTU1d3WXRGVGx2?=
 =?utf-8?B?UnNWY1NBQXByLzF1VkJ6VFJ6WGdkODR3enROalhPMDMxNjVHRDJLR21zVkhk?=
 =?utf-8?B?SVZ3ZDZ1SjliN0R2R0FRa040dmNacVRsTXc2dFE4TVZNUXhHSnc0b0g4Slgy?=
 =?utf-8?B?QndLUGdVOFBQK1ZqcXY1NWViZmttVjkzSTc3a0luMEg2dHM4VjBHRnMwM1Fa?=
 =?utf-8?B?WVdNcFIxUS8wVlRhTm1JL2lJRXEyWVVDS1AxT2M2SXhrUXg4ZW5LTGNqaDNQ?=
 =?utf-8?B?WlQxUENYaFdONEI3UkVrU0hGczZaN245WWV6Y1E3WmZncVBQNWZkMkFHV29J?=
 =?utf-8?Q?sdO46fdDNdXt+5968Z0RqaVl1?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 441669c6-aa3e-4536-37eb-08db67cfd823
X-MS-Exchange-CrossTenant-AuthSource: JH0PR03MB7495.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 03:24:18.8429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZQPVrSFOeWzra7SVwxgFKLXxtcgmJKyno4fKiuBBeoPQXBrkZvweXVeUAPVCI917sRdPPGxEdst+bMqVPEJElw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB6451
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2023/6/8 5:18, Arseniy Krasnov wrote:
> [ EXTERNAL EMAIL ]
> 
> Hi again Miquel, Liang!
> 
> What do You think about this patch?
> 
> Thanks, Arseniy
> 
> On 05.06.2023 22:15, Arseniy Krasnov wrote:
>> Both operations have no effect.
>>
>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
>> ---
>>   drivers/mtd/nand/raw/meson_nand.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>> index 074e14225c06..50d3110ad321 100644
>> --- a/drivers/mtd/nand/raw/meson_nand.c
>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand,
>>        cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN;
>>        nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0;
>>
>> -     addrs[0] = cs | NFC_CMD_ALE | 0;
>> +     addrs[0] = cs | NFC_CMD_ALE;
>>        if (mtd->writesize <= 512) {
>>                cmd_num--;
>>                row_start = 1;
>>        } else {
>> -             addrs[1] = cs | NFC_CMD_ALE | 0;
>> +             addrs[1] = cs | NFC_CMD_ALE;
>>                row_start = 2;
>>        }
Hi Arseniy and Miquel,

The two zeros indcates two column address. maybe we could use the micro 
"COLUMN_ADDR_0" and "COLUMN_ADDR_1" to keep the nfc command format "CE | 
ALE | addr" consistency and also let function 
"meson_nfc_rw_cmd_prepare_and_execute" be more readable.

Thanks,
Liang

>>