Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05cc07ce-f412-456f-74c0-57bfebe660da@sberdevices.ru>
Date:   Thu, 8 Jun 2023 07:37:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v1] mtd: rawnand: meson: remove unneeded bitwise OR with
 zeroes
Content-Language: en-US
To:     Liang Yang <liang.yang@amlogic.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
CC:     <oxffffaa@gmail.com>, <kernel@sberdevices.ru>,
        <linux-mtd@lists.infradead.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20230605191508.1826853-1-AVKrasnov@sberdevices.ru>
 <9319a8f6-3774-0dc8-2262-8033f8016a50@sberdevices.ru>
 <429589f6-d946-9bc9-d54e-e892d513a91b@amlogic.com>
From:   Arseniy Krasnov <avkrasnov@sberdevices.ru>
In-Reply-To: <429589f6-d946-9bc9-d54e-e892d513a91b@amlogic.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 08.06.2023 06:23, Liang Yang wrote:
> 
> 
> On 2023/6/8 5:18, Arseniy Krasnov wrote:
>> [ EXTERNAL EMAIL ]
>>
>> Hi again Miquel, Liang!
>>
>> What do You think about this patch?
>>
>> Thanks, Arseniy
>>
>> On 05.06.2023 22:15, Arseniy Krasnov wrote:
>>> Both operations have no effect.
>>>
>>> Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
>>> ---
>>>   drivers/mtd/nand/raw/meson_nand.c | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>>> index 074e14225c06..50d3110ad321 100644
>>> --- a/drivers/mtd/nand/raw/meson_nand.c
>>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>>> @@ -595,12 +595,12 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struct nand_chip *nand,
>>>        cmd0 = in ? NAND_CMD_READ0 : NAND_CMD_SEQIN;
>>>        nfc->cmdfifo.rw.cmd0 = cs | NFC_CMD_CLE | cmd0;
>>>
>>> -     addrs[0] = cs | NFC_CMD_ALE | 0;
>>> +     addrs[0] = cs | NFC_CMD_ALE;
>>>        if (mtd->writesize <= 512) {
>>>                cmd_num--;
>>>                row_start = 1;
>>>        } else {
>>> -             addrs[1] = cs | NFC_CMD_ALE | 0;
>>> +             addrs[1] = cs | NFC_CMD_ALE;
>>>                row_start = 2;
>>>        }
> Hi Arseniy and Miquel,
> 
> The two zeros indcates two column address. maybe we could use the micro "COLUMN_ADDR_0" and "COLUMN_ADDR_1" to keep the nfc command format "CE | ALE | addr" consistency and also let function "meson_nfc_rw_cmd_prepare_and_execute" be more readable.

Liang, done in v2:)

Thanks, Arseniy

> 
> Thanks,
> Liang
> 
>>>