Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp206347rwd; Wed, 7 Jun 2023 22:34:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7pgll2ZS1/zW6U/6Bj7JIT1p/9XEy9JukZxRbhvgJCc5RM3bPqHCklRY0Z1cmcBYawXA9Q X-Received: by 2002:a05:6830:1b6c:b0:6a6:3e1b:6d97 with SMTP id d12-20020a0568301b6c00b006a63e1b6d97mr8039366ote.6.1686202449436; Wed, 07 Jun 2023 22:34:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686202449; cv=none; d=google.com; s=arc-20160816; b=Tv/NToshghG/5Q+v0gnkb/9nD+FHXDld3VXK/Tj3qtjJVdl8P6cyHjG5hgyEyk2jBz 42EbYxPUO3AhUIzxcQ3uamFhygU1SfrL5/JUMZelFxh4+1g+I8V52aHzfeWfsDsl1KIX ZqFEEoHymTG/3AtKU9nGFMp1JtCi4/od5rm60c8vFN/olu6wYPnxfsBOvHo6ojc+RPvD OXCG75KFZooKFVqWWBEKkuaY6XLGnxZB4RILOMwZjwwHJ237ohd5gmhTKgcTxXCDL+XM rPOivBQmkn4Kc2GFPF2Z93RyFuV5jy0gddP48R4xB/Qqx4gw3xWz+kRXAMIWiWDc+uB+ qIfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Hboq8DS3pZaL6NixiwlkXIeXNphhjLHYiMYmQAdycXs=; b=fZB1vSFadGbLGWgWbZCdSfenY5WO2Esncly2dshtlo0oHdSQpxfiHwctCwUchjQJ5+ nsUKIxcWASgHnHl/Ebcylrfkh+V0/apUZ4riP25Va7FdSP494KvhRQwphrVSdT5GXsY5 dUESMkM7P8SN3bQoQTJ9MEp1onpXTB6r9q3cVTq4+Wl5KbRsA5qQhqfl54ea2MGw4gLV jJpR70Fk1ADIBYAbNbvspo/xxY+Ul92lpd4OcnbOCMAkdaaGiyoah/YZvstQj3QEqbIR RxoZN0TiHvXPgPzB3VoG3YI4Au/dbupArWn33uzTiDGvt6SWH9Dyxce3mx+8ZM2e+2Eu KpUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Q00dNRef; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n127-20020a632785000000b0053b28418df7si466058pgn.249.2023.06.07.22.33.57; Wed, 07 Jun 2023 22:34:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Q00dNRef; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234276AbjFHFGJ (ORCPT + 99 others); Thu, 8 Jun 2023 01:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232031AbjFHFGI (ORCPT ); Thu, 8 Jun 2023 01:06:08 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59C8E13D; Wed, 7 Jun 2023 22:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Hboq8DS3pZaL6NixiwlkXIeXNphhjLHYiMYmQAdycXs=; b=Q00dNRefDVcWXDKo3oxAmnUK+Y sFTBS9bSwpbmXHCG4EwlX1qCnlzqbGWQsmpLWsmcQNpJIDuFuAmPmaiSu/Ez4Y+nR7oqcjaYVnjTL /hJgcPMiA6CUfQD8W0cHCxVsx91YthI/i4ySXHwZlzl1JdbZMgWoVJWPGcZmuW+c+tw5ZUIgCSx+G hEKfIC7v+UW9YzJSEvPdIYBOHx+5Kr5JBOr7C1BZm1iYmpP+QQ87LkvH3Fj96JJTRGHlr/9v5++Lx m7z9EUWwWFCkzXdzm6ujtDRDiVLy0haNZr6abgK6mGvbUTtE5Kv1mqV2mAKhLj5rzHMHjUxPf5J8X JkuoWFJA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q77qE-00878e-2Q; Thu, 08 Jun 2023 05:05:46 +0000 Date: Wed, 7 Jun 2023 22:05:46 -0700 From: Christoph Hellwig To: Luis Chamberlain Cc: hch@infradead.org, djwong@kernel.org, sandeen@sandeen.net, song@kernel.org, rafael@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, jack@suse.cz, jikos@kernel.org, bvanassche@acm.org, ebiederm@xmission.com, mchehab@kernel.org, keescook@chromium.org, p.raghav@samsung.com, da.gomez@samsung.com, linux-fsdevel@vger.kernel.org, kernel@tuxforce.de, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] fs: add frozen sb state helpers Message-ID: References: <20230508011717.4034511-1-mcgrof@kernel.org> <20230508011717.4034511-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508011717.4034511-3-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 07, 2023 at 06:17:13PM -0700, Luis Chamberlain wrote: > Provide helpers so that we can check a superblock frozen state. > This will make subsequent changes easier to read. This makes > no functional changes. I'll look at the further changes, but having frozen/unfrozen helpers that sound binary while we have 4 shades of gray seems rather confusing to me.