Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763496AbXJORqN (ORCPT ); Mon, 15 Oct 2007 13:46:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932956AbXJORpo (ORCPT ); Mon, 15 Oct 2007 13:45:44 -0400 Received: from gateway-1237.mvista.com ([63.81.120.158]:53302 "EHLO gateway-1237.mvista.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932942AbXJORpl (ORCPT ); Mon, 15 Oct 2007 13:45:41 -0400 Subject: Re: [PATCH] RT: fix spin_trylock_irq From: Daniel Walker To: Steven Rostedt Cc: =?ISO-8859-1?Q?S=E9bastien_Dugu=E9?= , Ingo Molnar , Thomas Gleixner , Linux RT Users , linux-kernel In-Reply-To: References: <20071011142417.1d965820@bull.net> Content-Type: text/plain Date: Mon, 15 Oct 2007 10:44:06 -0700 Message-Id: <1192470246.17527.15.camel@imap.mvista.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-4.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 46 On Thu, 2007-10-11 at 10:49 -0400, Steven Rostedt wrote: > > --- > > include/linux/spinlock.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: linux-2.6.23-rc9-rt2/include/linux/spinlock.h > > =================================================================== > > --- linux-2.6.23-rc9-rt2.orig/include/linux/spinlock.h > > +++ linux-2.6.23-rc9-rt2/include/linux/spinlock.h > > @@ -501,7 +501,7 @@ do { \ > > > > #define spin_trylock_irq(lock) \ > > __cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irq, \ > > - __spin_trylock_irq, lock)) > > + _spin_trylock_irq, lock)) > > > > #define spin_trylock_irqsave(lock, flags) \ > > __cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irqsave, \ > > Thanks! Applied. > > Daniel, this BUG was introduced by your conversion to PICK_FUNCTION patch. > Please be more careful, and do an audit of your patch. (I don't have time > ATM). This could also be the source of other bugs I've been chasing. > > I might be pulling the PICK_FUNCTION patches if there's more bugs like > this. This is the second fix for this .. The first was in this email (over a month ago) http://lkml.org/lkml/2007/8/31/318 The above was emailed to Thomas, but I also sent you that link in IRC as a link of patches to include .. I'll be happy to audit my code better, but you should also audit your inclusion process better.. There have been too many missed patches, and too many double and triples fixes.. Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/